Re: Problem with xman-1.1.3-1

[Jon TURNEY <jon.turney@dronecode.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

On 18/02/2014 07:56, Doran Kangwai wrote:
> When I use xman 1.1.3-1 to view man pages it renders the pages as
> postscript. It seems to omit the step to process the PS.

Close, but not quite right.  groff is not being given the -T option to set the
output format, so it's producing the default, ps

> So I see stuff like this
> %!PS-Adobe-3.0
> %%Creator: groff version 1.22.2
> ...
> ...
> 
> Using man to display the page works fine.
> 
> When I use xman 1.1.2-1 the man page is also rendered correctly.
Thanks for reporting this problem, and the clear reproduction steps.

I can reproduce the problem, and bisecting points to this commit [1], which
changes the formatting command used by xman.

Yaakov,

Attached is trivial patch to fix.  If it looks good to you can you apply and
rebuild xman?

[1]
http://cgit.freedesktop.org/xorg/app/xman/commit/?id=d25a3b87ce9fdf950b42f45b644242d72e7167b3


[-- Attachment #2: 0001-Use-same-FORMAT-command-on-cygwin-as-on-linux-in-HAN.patch --]
[-- Type: text/plain, Size: 807 bytes --]

>From ea0ecbfa007e03e29f80f976472a28e37cf59931 Mon Sep 17 00:00:00 2001
From: Jon TURNEY <jon.turney@dronecode.org.uk>
Date: Wed, 19 Feb 2014 14:51:34 +0000
Subject: [PATCH app/xman] Use same FORMAT command on cygwin as on linux in
 HANDLE_ROFFSEQ case as well

Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
---
 vendor.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vendor.h b/vendor.h
index 548ded6..06df38f 100644
--- a/vendor.h
+++ b/vendor.h
@@ -159,7 +159,7 @@ from the X Consortium.
 # define REFER		"refer"
 # if defined(CSRG_BASED)
 #  define FORMAT	"nroff -mandoc"
-# elif defined(linux)
+# elif defined(linux) || defined(__CYGWIN__)
 #  define FORMAT	"GROFF_NO_SGR= groff -Tlatin1 -mandoc"
 # elif defined(__DARWIN__)
 #  define FORMAT	"nroff -man"
-- 
1.8.3.4



[-- Attachment #3: Type: text/plain, Size: 223 bytes --]

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://x.cygwin.com/docs/
FAQ:                   http://x.cygwin.com/docs/faq/