From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8512 invoked by alias); 4 Mar 2002 10:08:07 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Received: (qmail 8410 invoked from network); 4 Mar 2002 10:08:04 -0000 Received: from unknown (HELO pomello.wdg.uk.ibm.com) (194.196.100.50) by sources.redhat.com with SMTP; 4 Mar 2002 10:08:04 -0000 Received: from pomello ([127.0.0.1]) by pomello.wdg.uk.ibm.com with Microsoft SMTPSVC(6.0.2600.28); Mon, 4 Mar 2002 10:07:58 +0000 Message-ID: <001901c1c364$75c1b6e0$d1228d09@wdg.uk.ibm.com> From: "Max Bowsher" To: Subject: Re: setup.exe (cinstall) bugfixes + minor new feature Date: Mon, 04 Mar 2002 02:08:00 -0000 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="----=_NextPart_000_0014_01C1C364.726A0060"; micalg=SHA1; protocol="application/x-pkcs7-signature" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2600.0000 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 X-OriginalArrivalTime: 04 Mar 2002 10:07:58.0286 (UTC) FILETIME=[75C1B6E0:01C1C364] X-SW-Source: 2002-03/txt/msg00164.txt.bz2 ------=_NextPart_000_0014_01C1C364.726A0060 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-length: 2762 I did notice that setup-20020225.exe does not have the shortcut creation bug - do you have some fixes which haven't made it to CVS yet? Re Feature Addition - is the objection that you don't want to set a precedent for lots of placeholder files in /etc/setup ? This I can understand, but I don't see what 'it will only remember turning them off' means - what else should it remember? Max. ----- Original Message ----- From: "Robert Collins" To: "Max Bowsher" ; Sent: Sunday, March 03, 2002 9:15 PM Subject: RE: setup.exe (cinstall) bugfixes + minor new feature > > > Thanks Max. > > > -----Original Message----- > > From: Max Bowsher [mailto:maxb@ukf.net] > > Sent: Monday, March 04, 2002 4:54 AM > > To: cygwin@cygwin.com > > Subject: setup.exe (cinstall) bugfixes + minor new feature > > > > > > I've been working with the setup code, and have discovered > > some bugs in the current (just updated) CVS version. > > > > I'm posting a patch here for comments, whilst I join > > cygwin-patches, and study the Contributing instructions. > > > > The patch does the following: > > > > BugFix: io_stream::mkpath_p(isadir, path) misuse > > mkpath_p is supposed to take a path with either a file:// or > > a cygfile:// prefix, but it is fed a path with no prefix in > > some places. The patch adds a file:// prefix where needed. > > This was causing some directories not to be created, > > including the Cygwin directory in the start menu. > > I know about these - they are fixed in setup200202 - when that goes live > I'll be backporting some key bugs. > > > BugFix: add backslash call to make_link, in desktop.cc > > This was causing the start menu shortcut to be called > > 'Programs/Cygwin/Cygwin Bash Shell' instead of being in the > > correct directory structure > > Does this affect setup200202? I haven't checked yet. I'm trying to > encpasulate the path specific knowledge - so whilst this solution works, > I'd rather refactor make_link to leverage io_stream, and make this a > method or variant of the file:// io_stream. Also '/' separated paths are > valid to pass to the WIN32 API, so I'm curious why this is suddenly > become a problem. (Quite a lot of setup expects '/' separated paths, and > I see no reason to change that at this point. > > > Feature Addition: Use files > > /etc/setup/inhibit-{startmenu,desktop}-icon to remeber user > > de-selection of the create icon checkboxes on the last page of setup. > > This approach is too simple - it will only remember turning them off. > The settings should go in /etc/setup/setup.conf as something like > "desktop_icon = yes|no". > > Thanks for the patch though, I look forward to an update. > > Cheers, > Rob > > > ------=_NextPart_000_0014_01C1C364.726A0060 Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-length: 3644 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEH AQAAoIIIijCCAr8wggIooAMCAQICAQAwDQYJKoZIhvcNAQEFBQAwSjELMAkG A1UEBhMCVUsxHjAcBgNVBAMTFU1heCBCb3dzaGVyIChSb290IENBKTEbMBkG CSqGSIb3DQEJARYMbWF4YkB1a2YubmV0MB4XDTAyMDIxMzEzMjA0MloXDTAz MDIxMzEzMjA0MlowSjELMAkGA1UEBhMCVUsxHjAcBgNVBAMTFU1heCBCb3dz aGVyIChSb290IENBKTEbMBkGCSqGSIb3DQEJARYMbWF4YkB1a2YubmV0MIGf MA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCvJQJS//LZa4lT4ZRe3SKcfco5 BE5vmQdp70grCuEFOJl5/Kkhb6p0PZXkkgA3thAFZqB/KOAOF6hwodazx+es VfV9PIKkTG+KhXaQvmmN01SjLRqg7anDxSTDJJf8mwE6YJtVJ03C8aZm4TXX jenr+cIIUSPcOuRPUZYgQAh0fwIDAQABo4G0MIGxMAsGA1UdDwQEAwIBBjAP BgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBQ3L9Yr4kasW7LXjBABnnzw4Kz5 TjByBgNVHSMEazBpgBQ3L9Yr4kasW7LXjBABnnzw4Kz5TqFOpEwwSjELMAkG A1UEBhMCVUsxHjAcBgNVBAMTFU1heCBCb3dzaGVyIChSb290IENBKTEbMBkG CSqGSIb3DQEJARYMbWF4YkB1a2YubmV0ggEAMA0GCSqGSIb3DQEBBQUAA4GB AFLF2iYrCF9dYm2bOuFP2cUUzeHzPrpnJLVvSriegYckvYIyMQbBf1DMvjur uh6SKxeQYjz5wMKyG/B1kCTarDaz0N/YYmpnmq/sx6g0acNe/J0oPd5zxNH2 Oa7kf7PjtnxhyJG3psyUAIS1ePO5YxUcJUfcobBSEQdJ4yfAnCf3MIIC2zCC AkSgAwIBAgIBATANBgkqhkiG9w0BAQUFADBQMQswCQYDVQQGEwJVSzEkMCIG A1UEAxMbTWF4IEJvd3NoZXIgKEVtYWlsIFJvb3QgQ0EpMRswGQYJKoZIhvcN AQkBFgxtYXhiQHVrZi5uZXQwHhcNMDIwMjEzMTMyODA5WhcNMDMwMjEzMTMy ODA5WjBPMQswCQYDVQQGEwJVSzEjMCEGA1UEAxQaTWF4IEJvd3NoZXIgKG1h eGJAdWtmLm5ldCkxGzAZBgkqhkiG9w0BCQEWDG1heGJAdWtmLm5ldDCBnzAN BgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEA5j0b8K8SJpRsErvliFmhwml/nnYV JfMVi105HLix9sNjYZccl3FSn9w0ghVQbLCsgIpwI8XFGirCbL6CEF+5dmmG L//3+wazwOakI+BQBX4yGwnSnNSkgtcW6jhbyjKPMrA4pMX8urKdRLsGkwrd uTNQRaS3xAMBLfdCBJk6nqUCAwEAAaOBxTCBwjAOBgNVHQ8BAf8EBAMCBPAw HQYDVR0lBBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMB0GA1UdDgQWBBQmoaNs NxILLHDF4PHVWadROFddiTByBgNVHSMEazBpgBRuq2TkAovVqlSOcVqj0e0n Ye5OfqFOpEwwSjELMAkGA1UEBhMCVUsxHjAcBgNVBAMTFU1heCBCb3dzaGVy IChSb290IENBKTEbMBkGCSqGSIb3DQEJARYMbWF4YkB1a2YubmV0ggEBMA0G CSqGSIb3DQEBBQUAA4GBANfKJjcZ4VWugIDoc20n0UgeowVdgJVxdjZ5FGb3 02L/ihgFpGnx7Wfw1GmvK4W7YQS6X6gJoYCcmtAMLV+GpPLAvPnGJcPvK13F 0lhEKwslYQF0RBSYzZasX8jF+dbVGNOsU2UgDVFUKITk9UZ2K2GoXzVqZNN3 bMxEJZqxzW5vMIIC5DCCAk2gAwIBAgIBATANBgkqhkiG9w0BAQUFADBKMQsw CQYDVQQGEwJVSzEeMBwGA1UEAxMVTWF4IEJvd3NoZXIgKFJvb3QgQ0EpMRsw GQYJKoZIhvcNAQkBFgxtYXhiQHVrZi5uZXQwHhcNMDIwMjEzMTMyMDQ3WhcN MDMwMjEzMTMyMDQ3WjBQMQswCQYDVQQGEwJVSzEkMCIGA1UEAxMbTWF4IEJv d3NoZXIgKEVtYWlsIFJvb3QgQ0EpMRswGQYJKoZIhvcNAQkBFgxtYXhiQHVr Zi5uZXQwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAOMLbe/pTtdIyBaN 8snkYvW7tGabtQb44iJ3ZHFUpB1G6v9rpLqDgyvC3SvZI/1w+tliSfY88HVY vG9qjRHapw+YHyBzGkMy+yqoq3lihtOAc3V8VYbREgGvCodSPs5/kZUPoL4J ME86MWe5wxd/IclDg08IV3rBYV5YgELWDR3fAgMBAAGjgdMwgdAwCwYDVR0P BAQDAgEGMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEFBQcDBDAPBgNVHRMB Af8EBTADAQH/MB0GA1UdDgQWBBRuq2TkAovVqlSOcVqj0e0nYe5OfjByBgNV HSMEazBpgBQ3L9Yr4kasW7LXjBABnnzw4Kz5TqFOpEwwSjELMAkGA1UEBhMC VUsxHjAcBgNVBAMTFU1heCBCb3dzaGVyIChSb290IENBKTEbMBkGCSqGSIb3 DQEJARYMbWF4YkB1a2YubmV0ggEAMA0GCSqGSIb3DQEBBQUAA4GBAIhvdbvj xuM1hF5EeRCvd6h21yTvjctwO1Preokrv0ukVkhYNvNOaciOV4VGx0tCrBIp 88vjNTND1H2Ih1V9e+fg+zmccSqY6SMDkGfbsmP8bh8IhQezGlKElyHcXknE 3VpFT70FALI6XOB5EC1vV0QRZzs0ZRCnuLQf9F0hptWyMYIBuDCCAbQCAQEw VTBQMQswCQYDVQQGEwJVSzEkMCIGA1UEAxMbTWF4IEJvd3NoZXIgKEVtYWls IFJvb3QgQ0EpMRswGQYJKoZIhvcNAQkBFgxtYXhiQHVrZi5uZXQCAQEwCQYF Kw4DAhoFAKCBujAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3 DQEJBTEPFw0wMjAzMDQxMDA3NTJaMCMGCSqGSIb3DQEJBDEWBBRxFi0ulPaS TY5HDX5w7hdoYeUarjBbBgkqhkiG9w0BCQ8xTjBMMAoGCCqGSIb3DQMHMA4G CCqGSIb3DQMCAgIAgDANBggqhkiG9w0DAgIBQDAHBgUrDgMCBzANBggqhkiG 9w0DAgIBKDAHBgUrDgMCHTANBgkqhkiG9w0BAQEFAASBgD7iz/PmKQhLVqtz 1LB8O06iWI9+Zx5ncrsld7t9V8v9IHOWFrvKtJvLFLadxkvRUjP3DdTOF6Is eJMnou5NlMxRjMWkTysPiFJtc8aqId8buWYUtVqfuhH6M3NyibInt9iVYehu hD40kXGRpDBhGwkFx4b0nfFDCrZVRB4kUmiKAAAAAAAA ------=_NextPart_000_0014_01C1C364.726A0060--