public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
* cygwin download incomplete - try again - loop?
@ 2002-06-07  1:31 Ralf Hauser
  2002-06-07  2:07 ` Pavel Tsekov
  0 siblings, 1 reply; 30+ messages in thread
From: Ralf Hauser @ 2002-06-07  1:31 UTC (permalink / raw)
  To: cygwin

Hi, when I use cygwin's setup.exe. to try to "install from Internet" -
System - setup 2.218.2.9-1, I get a "download incomplete - try again?" error
loop with serveral download sites.
Does it intentionally choke on itself?

Rgds r.  (hauser@acm.org)





--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 30+ messages in thread
* RE: Re[3]: cygwin download incomplete - try again - loop?
@ 2002-06-07  8:04 Kilroy, David
  2002-06-07  8:40 ` Robert Collins
  0 siblings, 1 reply; 30+ messages in thread
From: Kilroy, David @ 2002-06-07  8:04 UTC (permalink / raw)
  To: 'cygwin@cygwin.com'

> Its easy to kludge round this, but it strikes me that the 
> problem would be
> better solved by finding out why a null pointer is being 
> passed in the first
> place. Maybe this weekend :-).

I found this lot out a while ago, but thought a fix had been identified by
Pavel/Max and applied in 2.249.xxx. You guys seemed perfectly on track to
identifying the bug in

http://www.cygwin.com/ml/cygwin/2002-05/msg01527.html

So here goes.

What I found is as follows (setup 2.218... files named, in sq bracket are
the files the code was relocated to in 2.249...)

The null pointer is there because the find routines return the path to
setup.ini relative to your local package directory. This is typically

 [rfc1738 encoded ftp site name]/setup.ini

but for the setup.ini in your local package directory, this is

 setup.ini

In ini.c [IniParseFindVisitor.c], you strip /setup.ini from the end of the
path, and pass the remaining string to rfc1738 to decode the ftp location.
You then store the return string as your mirror site.

In the case of the Local Package directory (and 2.218...), you pass null to
the rfc 1738 routines, and they crash.

I haven't checked lately, but I think in 2.249 you may pass "" to rfc1738 to
avoid crashing - however if you do this, a crash occurs later in install.cc
when you ask rfc1738 to encode an empty string (the mirror site you stored
in ini.cc). I'm not sure, but if you pass "setup.ini" to rfc1738  in ini.cc
[IniParseFindVisitor.cc] the correct behaviour occurs. (I chose to pass
"setup.ini" because this is what the pre md5 checksum setup.exe did).

In my opinion, the rfc1738 code should be fixed so it doesn't choke on null
or empty strings (which I think is reasonable), and then you don't need
special code to identify your local cache.

If I am correct, then ralfs crash [in 2.249.xx] occurs after he has selected
everything, and the install is about to take place.

Hope that helps.


Dave.


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 30+ messages in thread
* RE: Re[3]: cygwin download incomplete - try again - loop?
@ 2002-06-07 15:29 Heribert Dahms
  2002-06-08  7:19 ` Robert Collins
  0 siblings, 1 reply; 30+ messages in thread
From: Heribert Dahms @ 2002-06-07 15:29 UTC (permalink / raw)
  To: 'Robert Collins', 'Kilroy, David', cygwin

Hi Rob,

unless I lost track in the thread,
wouldn't rfc1738 simply need
to check right at the beginning something like
	if (!ptr || !*ptr) return ptr;
and how many million times does setup call it
that it makes a noteable difference to the user?
Or do you re-install cygwin hundred times a day 8-)

Bye, Heribert (heribert_dahms@icon-scm.com)

> -----Original Message-----
> From:	Robert Collins [SMTP:robert.collins@syncretize.net]
> Sent:	Friday, June 07, 2002 17:11
> To:	'Kilroy, David'; cygwin@cygwin.com
> Subject:	RE: Re[3]: cygwin download incomplete - try again - loop?
> 
> >  On Behalf Of Kilroy, David
> 
> > In my opinion, the rfc1738 code should be fixed so it doesn't 
> > choke on null
> > or empty strings (which I think is reasonable), and then you 
> > don't need
> > special code to identify your local cache.
> 
> Yes but.... The rfc1738 code is ok, it's the C++ <string> classes that
> are choking, and fixing them is a little harder. Adding overhead to
> rfc1738 is not good either though :[.
> 

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 30+ messages in thread
* RE: Re[3]: cygwin download incomplete - try again - loop?
@ 2002-06-09  7:42 Arthur I Schwarz
  2002-06-10  3:33 ` Max Bowsher
  0 siblings, 1 reply; 30+ messages in thread
From: Arthur I Schwarz @ 2002-06-09  7:42 UTC (permalink / raw)
  To: cygwin
  Cc: 'Robert Collins', 'Heribert Dahms',
	'Kilroy, David'


Ah, gentlemen, you've saved me some time
The thought that I'd failed, was not sublime
And I spent my poor hours trying to find
  Why.
But, you've saved me some time.

I too have a little bone to pick
A (so sad) setup to kick
I tried and tried to beat the odds
But was lost when 'NULL' did arise
You've saved me some time.

Amidst this doggeral and other things you find
I have an issue which stands up and is not kind
I installed, or uninstalled, valuable things
To find that failure dogged my wings.

Tail dragging,
  feet of lead
I plead and ask
  with heart of dread
When, and where,
  will this damn'd bug be fixed
So when next I setup
  I can say "Setup I did".

art



--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 30+ messages in thread
[parent not found: <OF1B74C8BE.C203451D-ON88256BD4.00570484@rsc.raytheon.com>]
end of thread, other threads:[~2002-06-11  9:20 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-06-07  1:31 cygwin download incomplete - try again - loop? Ralf Hauser
2002-06-07  2:07 ` Pavel Tsekov
2002-06-07  2:09   ` Roberto Morello
2002-06-07  6:35     ` Nicholas Wourms
2002-06-07  6:50       ` robertc
2002-06-07  2:09   ` Ralf Hauser
2002-06-07  3:05     ` Re[2]: " Pavel Tsekov
2002-06-07  4:31       ` Ralf Hauser
2002-06-07  5:08     ` Max Bowsher
2002-06-07  5:09       ` Re[2]: " Pavel Tsekov
2002-06-07  5:20         ` Re[3]: " Pavel Tsekov
2002-06-07  6:04           ` Max Bowsher
2002-06-07  6:40             ` Re[5]: " Pavel Tsekov
2002-06-07  6:48               ` Max Bowsher
2002-06-07  6:58                 ` Max Bowsher
2002-06-07  9:13             ` Re[3]: " Robert Collins
2002-06-07  9:17               ` Re[5]: " Pavel Tsekov
2002-06-07 10:37               ` Re[3]: " Max Bowsher
2002-06-08  8:27                 ` Robert Collins
2002-06-10  3:31                   ` Max Bowsher
2002-06-10  3:49                     ` Robert Collins
2002-06-10  5:37                       ` Max Bowsher
2002-06-07  8:04 Kilroy, David
2002-06-07  8:40 ` Robert Collins
2002-06-07 15:29 Heribert Dahms
2002-06-08  7:19 ` Robert Collins
2002-06-08  7:58   ` Robert Collins
2002-06-09  7:42 Arthur I Schwarz
2002-06-10  3:33 ` Max Bowsher
     [not found] <OF1B74C8BE.C203451D-ON88256BD4.00570484@rsc.raytheon.com>
2002-06-11  5:21 ` Max Bowsher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).