cygwin download incomplete - try again - loop?

cygwin download incomplete - try again - loop?

[Ralf Hauser]

Hi, when I use cygwin's setup.exe. to try to "install from Internet" -
System - setup 2.218.2.9-1, I get a "download incomplete - try again?" error
loop with serveral download sites.
Does it intentionally choke on itself?

Rgds r.  (hauser@acm.org)





--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: cygwin download incomplete - try again - loop?

[Pavel Tsekov]

Hello Ralf,

Try a snapshot version of the installer. You can get one from
http://www.cygwin.com/setup-snapshots. The latest binary
there is setup-2.249.2.1.exe

RH> Hi, when I use cygwin's setup.exe. to try to "install from Internet" -
RH> System - setup 2.218.2.9-1, I get a "download incomplete - try again?" error
RH> loop with serveral download sites.


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: cygwin download incomplete - try again - loop?

[Ralf Hauser]

Thanks, 2.249.2.1 seems to work fine for downloading what I said, but when I
use it to install from my local directory, it crashes "Instruction at
"0x00434679" referenced memory at "0x000000000". The memory could not be
"read".
...
-----Original Message-----
From: Pavel Tsekov [mailto:ptsekov@syntrex.com]
Sent: Freitag, 7. Juni 2002 10:32
To: Ralf Hauser
Cc: cygwin@cygwin.com
Subject: Re: cygwin download incomplete - try again - loop?


Hello Ralf,

Try a snapshot version of the installer. You can get one from
http://www.cygwin.com/setup-snapshots. The latest binary
there is setup-2.249.2.1.exe

RH> Hi, when I use cygwin's setup.exe. to try to "install from Internet" -
RH> System - setup 2.218.2.9-1, I get a "download incomplete - try again?"
error
RH> loop with serveral download sites.


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re[2]: cygwin download incomplete - try again - loop?

[Pavel Tsekov]

Hello Ralf,

Friday, June 07, 2002, 10:47:49 AM, you wrote:

RH> Thanks, 2.249.2.1 seems to work fine for downloading what I said, but when I
RH> use it to install from my local directory, it crashes "Instruction at
RH> "0x00434679" referenced memory at "0x000000000". The memory could not be
RH> "read".

On which page of the installer does it crash ? Which is your OS
version ?


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Re[2]: cygwin download incomplete - try again - loop?

[Ralf Hauser]

Pavel,

OS-Version:
<<rhauser@6657:~/MyDocRalf> cygcheck -s

Cygwin Win95/NT Configuration Diagnostics
Current System Time: Fri Jun 07 10:17:05 2002

Windows 2000 Professional Ver 5.0 Build 2195 Service Pack 2
....>>

Page:
After "Select Local Package Directory" in "Progress - This page displays the
progress in downloading or installing ..."

Rgds r.
-----Original Message-----
From: Pavel Tsekov [mailto:ptsekov@syntrex.com]
Sent: Freitag, 7. Juni 2002 11:10
To: Ralf Hauser
Cc: Pavel Tsekov; hauser@acm.org
Subject: Re[2]: cygwin download incomplete - try again - loop?


Hello Ralf,

Friday, June 07, 2002, 10:47:49 AM, you wrote:

RH> Thanks, 2.249.2.1 seems to work fine for downloading what I said, but
when I
RH> use it to install from my local directory, it crashes "Instruction at
RH> "0x00434679" referenced memory at "0x000000000". The memory could not be
RH> "read".

On which page of the installer does it crash ? Which is your OS
version ?


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: cygwin download incomplete - try again - loop?

[Max Bowsher]

Ralf Hauser <ralfhauser@gmx.ch> wrote:
> Thanks, 2.249.2.1 seems to work fine for downloading what I said, but when I
> use it to install from my local directory, it crashes "Instruction at
> "0x00434679" referenced memory at "0x000000000". The memory could not be
> "read".

This is caused to the presence of a setup.ini in the root of the local package
directory and a string-handling bug in the rfc1738 code.

Max.



--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re[2]: cygwin download incomplete - try again - loop?

[Pavel Tsekov]

Hello Max,

Friday, June 07, 2002, 11:46:54 AM, you wrote:

MB> Ralf Hauser <ralfhauser@gmx.ch> wrote:
>> Thanks, 2.249.2.1 seems to work fine for downloading what I said, but when I
>> use it to install from my local directory, it crashes "Instruction at
>> "0x00434679" referenced memory at "0x000000000". The memory could not be
>> "read".

MB> This is caused to the presence of a setup.ini in the root of the local package
MB> directory and a string-handling bug in the rfc1738 code.


Hmm... Maybe not. The latest setup source I have here (fetched from
HEAD, not a branch)is 2.249 and the fix for that problem is there. And
this was fetched some time ago - so I suppose all the latest and
greatest setup.exe should have this fix also.

I can't check right now though because I'm behind a firewall.


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re[3]: cygwin download incomplete - try again - loop?

[Pavel Tsekov]

MB>> This is caused to the presence of a setup.ini in the root of the local package
MB>> directory and a string-handling bug in the rfc1738 code.


PT> Hmm... Maybe not. The latest setup source I have here (fetched from
PT> HEAD, not a branch)is 2.249 and the fix for that problem is there. And
PT> this was fetched some time ago - so I suppose all the latest and
PT> greatest setup.exe should have this fix also.

PT> I can't check right now though because I'm behind a firewall.

It appears that Max is right - without setup.ini in the local package
directory everything is fine, if you put one, setup.exe crashes :(

So, Ralf, if you remove the setup.ini from the local package
directory, setup.exe won't crash.


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: Re[3]: cygwin download incomplete - try again - loop?

[Max Bowsher]

Pavel Tsekov <ptsekov@syntrex.com> wrote:
> MB>> This is caused to the presence of a setup.ini in the root of the local
package
> MB>> directory and a string-handling bug in the rfc1738 code.
>
> It appears that Max is right - without setup.ini in the local package
> directory everything is fine, if you put one, setup.exe crashes :(

Backtrace from the crash below.

strlen(url) is called with url = NULL on line 92.

Its easy to kludge round this, but it strikes me that the problem would be
better solved by finding out why a null pointer is being passed in the first
place. Maybe this weekend :-).

(gdb) bt
#0  0x004346d3 in rfc1738_do_escape (url=0x0, encode_reserved=1)
    at ../setup/rfc1738.cc:92
#1  0x0043484c in rfc1738_escape_part (url=@0x13785c8)
    at ../setup/rfc1738.cc:187
#2  0x0040c5ef in check_for_cached (pkgsource=@0x12f48e0)
    at ../setup/download.cc:91
#3  0x004043e6 in scan_downloaded_files () at ../setup/choose.cc:471
#4  0x004045f1 in ChooserPage::OnInit (this=0x23fb60) at ../setup/choose.cc:517
#5  0x00434112 in PropertyPage::DialogProc (this=0x23fb60, message=272,
    wParam=0, lParam=2461248) at ../setup/proppage.cc:114
#6  0x0043404d in PropertyPage::FirstDialogProcReflector (hwnd=0x30556,
    message=272, wParam=0, lParam=2461248) at ../setup/proppage.cc:86



--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re[5]: cygwin download incomplete - try again - loop?

[Pavel Tsekov]

Hello Max,

Friday, June 07, 2002, 2:31:56 PM, you wrote:

MB> Backtrace from the crash below.

MB> strlen(url) is called with url = NULL on line 92.

MB> Its easy to kludge round this, but it strikes me that the problem would be
MB> better solved by finding out why a null pointer is being passed in the first
MB> place. Maybe this weekend :-).

MB> (gdb) bt
MB> #0  0x004346d3 in rfc1738_do_escape (url=0x0, encode_reserved=1)
MB>     at ../setup/rfc1738.cc:92
MB> #1  0x0043484c in rfc1738_escape_part (url=@0x13785c8)
MB>     at ../setup/rfc1738.cc:187
MB> #2  0x0040c5ef in check_for_cached (pkgsource=@0x12f48e0)
MB>     at ../setup/download.cc:91
MB> #3  0x004043e6 in scan_downloaded_files () at ../setup/choose.cc:471
MB> #4  0x004045f1 in ChooserPage::OnInit (this=0x23fb60) at ../setup/choose.cc:517
MB> #5  0x00434112 in PropertyPage::DialogProc (this=0x23fb60, message=272,
MB>     wParam=0, lParam=2461248) at ../setup/proppage.cc:114
MB> #6  0x0043404d in PropertyPage::FirstDialogProcReflector (hwnd=0x30556,
MB>     message=272, wParam=0, lParam=2461248) at ../setup/proppage.cc:86

Ah, this is another one! :) Btw I recall you reported something like
this some weeks ago.

I'll take a look at it too.


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: Re[5]: cygwin download incomplete - try again - loop?

[Max Bowsher]

Pavel Tsekov <ptsekov@syntrex.com> wrote:
> Hello Max,
>
> Friday, June 07, 2002, 2:31:56 PM, you wrote:
>
> MB> strlen(url) is called with url = NULL on line 92.
>
> MB> Its easy to kludge round this, but it strikes me that the problem would be
> MB> better solved by finding out why a null pointer is being passed in the
first
> MB> place. Maybe this weekend :-).
>
> Ah, this is another one! :) Btw I recall you reported something like
> this some weeks ago.

I'm pretty sure it is the same one. I kludged around it in my local copy, by
returning a null string, without calling strlen(), but I didn't submit a patch,
because the very fact that a NULL pointer is being passed in is a bug elsewhere
in the code, which I have not been able to find and squish, because I have not
yet invested the time to fully understnd the control flow of this part of setup.

Max.



--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: Re[5]: cygwin download incomplete - try again - loop?

[Max Bowsher]

Pavel Tsekov <ptsekov@syntrex.com> wrote:
> Hello Max,
>
> Friday, June 07, 2002, 2:31:56 PM, you wrote:
>
> MB> strlen(url) is called with url = NULL on line 92.
>
> MB> Its easy to kludge round this, but it strikes me that the problem would be
> MB> better solved by finding out why a null pointer is being passed in the
first
> MB> place. Maybe this weekend :-).
>
> Ah, this is another one! :) Btw I recall you reported something like
> this some weeks ago.

I'm pretty sure it is the same one. I kludged around it in my local copy, by
returning a null string, without calling strlen(), but I didn't submit a patch,
because the very fact that a NULL pointer is being passed in is a bug elsewhere
in the code, which I have not been able to find and squish, because I have not
yet invested the time to fully understnd the control flow of this part of setup.

Max.



--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Re[3]: cygwin download incomplete - try again - loop?

[Robert Collins]

I can't duplicate this. Is this from HEAD or setup-200206?

Also, can you use 'bt full' not 'bt' when getting a back trace?

Thanks,
Rob

> -----Original Message-----
> From: cygwin-owner@cygwin.com 
> [mailto:cygwin-owner@cygwin.com] On Behalf Of Max Bowsher
> Sent: Friday, 7 June 2002 10:32 PM
> To: cygwin@cygwin.com
> Subject: Re: Re[3]: cygwin download incomplete - try again - loop?
> 
> 
> Pavel Tsekov <ptsekov@syntrex.com> wrote:
> > MB>> This is caused to the presence of a setup.ini in the 
> root of the local
> package
> > MB>> directory and a string-handling bug in the rfc1738 code.
> >
> > It appears that Max is right - without setup.ini in the 
> local package
> > directory everything is fine, if you put one, setup.exe crashes :(
> 
> Backtrace from the crash below.
> 
> strlen(url) is called with url = NULL on line 92.
> 
> Its easy to kludge round this, but it strikes me that the 
> problem would be
> better solved by finding out why a null pointer is being 
> passed in the first
> place. Maybe this weekend :-).
> 
> (gdb) bt
> #0  0x004346d3 in rfc1738_do_escape (url=0x0, encode_reserved=1)
>     at ../setup/rfc1738.cc:92
> #1  0x0043484c in rfc1738_escape_part (url=@0x13785c8)
>     at ../setup/rfc1738.cc:187
> #2  0x0040c5ef in check_for_cached (pkgsource=@0x12f48e0)
>     at ../setup/download.cc:91
> #3  0x004043e6 in scan_downloaded_files () at ../setup/choose.cc:471
> #4  0x004045f1 in ChooserPage::OnInit (this=0x23fb60) at 
> ../setup/choose.cc:517
> #5  0x00434112 in PropertyPage::DialogProc (this=0x23fb60, 
> message=272,
>     wParam=0, lParam=2461248) at ../setup/proppage.cc:114
> #6  0x0043404d in PropertyPage::FirstDialogProcReflector 
> (hwnd=0x30556,
>     message=272, wParam=0, lParam=2461248) at ../setup/proppage.cc:86
> 
> 
> 
> --
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
> Bug reporting:         http://cygwin.com/bugs.html
> Documentation:         http://cygwin.com/docs.html
> FAQ:                   http://cygwin.com/faq/
> 
> 


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re[5]: cygwin download incomplete - try again - loop?

[Pavel Tsekov]

Hello Robert,

Friday, June 07, 2002, 5:33:57 PM, you wrote:

RC> I can't duplicate this. Is this from HEAD or setup-200206?

RC> Also, can you use 'bt full' not 'bt' when getting a back trace?

2.249.2.1 blows here but I dont have a debuggable exe right now.
When Max reported this crash for the first time I wasn't able to
reproduce it.

I'm running the XP Home with all critical updates, etc.


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: Re[3]: cygwin download incomplete - try again - loop?

[Max Bowsher]

Robert Collins <robert.collins@syncretize.net> wrote:
> I can't duplicate this. Is this from HEAD or setup-200206?

HEAD, checked out from an rsync local replica of the cvs tree. Updated within 15
mins of this mail.

Placing a setup.ini file in the root of the local package directory duplicates
the crash reliably for me.

> Also, can you use 'bt full' not 'bt' when getting a back trace?

(gdb) bt full
#0  0x004346d3 in rfc1738_do_escape (url=0x0, encode_reserved=1)
    at ../setup/rfc1738.cc:92
        url = 0x0
        buf = 0x0
        bufsize = 0
        p = 0x12f4790 "hJ/\001"
        q = 0x0
        i = 0
        do_escape = 0
#1  0x0043484c in rfc1738_escape_part (url=@0x13784d0)
    at ../setup/rfc1738.cc:187
        url = (String &) @0x0: Cannot access memory at address 0x0
(gdb) bt
#0  0x004346d3 in rfc1738_do_escape (url=0x0, encode_reserved=1)
    at ../setup/rfc1738.cc:92
#1  0x0043484c in rfc1738_escape_part (url=@0x13784d0)
    at ../setup/rfc1738.cc:187
#2  0x0040c5ef in check_for_cached (pkgsource=@0x12f47a0)
    at ../setup/download.cc:91
#3  0x004043e6 in scan_downloaded_files () at ../setup/choose.cc:471
#4  0x004045f1 in ChooserPage::OnInit (this=0x23fb60) at ../setup/choose.cc:517
#5  0x00434112 in PropertyPage::DialogProc (this=0x23fb60, message=272,
    wParam=0, lParam=2461248) at ../setup/proppage.cc:114
#6  0x0043404d in PropertyPage::FirstDialogProcReflector (hwnd=0xf064a,
    message=272, wParam=0, lParam=2461248) at ../setup/proppage.cc:86

> Thanks,
> Rob




--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Re[3]: cygwin download incomplete - try again - loop?

[Robert Collins]

> -----Original Message-----
> From: Max Bowsher [mailto:maxb@ukf.net] 
> Sent: Saturday, 8 June 2002 2:13 AM
> To: Robert Collins; cygwin@cygwin.com
> Subject: Re: Re[3]: cygwin download incomplete - try again - loop?
> 
> 
> Robert Collins <robert.collins@syncretize.net> wrote:
> > I can't duplicate this. Is this from HEAD or setup-200206?
> 
> HEAD, checked out from an rsync local replica of the cvs 
> tree. Updated within 15
> mins of this mail.
> 
> Placing a setup.ini file in the root of the local package 
> directory duplicates
> the crash reliably for me.
> 
> > Also, can you use 'bt full' not 'bt' when getting a back trace?
> 
> (gdb) bt full
> #0  0x004346d3 in rfc1738_do_escape (url=0x0, encode_reserved=1)
>     at ../setup/rfc1738.cc:92
>         url = 0x0
>         buf = 0x0
>         bufsize = 0
>         p = 0x12f4790 "hJ/\001"
>         q = 0x0
>         i = 0
>         do_escape = 0
> #1  0x0043484c in rfc1738_escape_part (url=@0x13784d0)
>     at ../setup/rfc1738.cc:187
>         url = (String &) @0x0: Cannot access memory at address 0x0
> (gdb) bt
> #0  0x004346d3 in rfc1738_do_escape (url=0x0, encode_reserved=1)
>     at ../setup/rfc1738.cc:92
> #1  0x0043484c in rfc1738_escape_part (url=@0x13784d0)
>     at ../setup/rfc1738.cc:187
> #2  0x0040c5ef in check_for_cached (pkgsource=@0x12f47a0)
>     at ../setup/download.cc:91

In here, (pkgsource.sites[n]->key ) is apparently evaluating as a zero
length string. This should never happen (key must have a value).

However, I'm pretty sure the sites class allows key to have no value, so
what you need to do is to go to frame 2 or 3 and identify the package
and site count that it's got. And then work backwards to find out when
the invalid site is created. 

Can you do that? I'll offer what email assistance I can, but until we
have enough detail to reproduce here, that's all I can offer. I'm
obviously keen to get this bug fixed...

Rob


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: Re[3]: cygwin download incomplete - try again - loop?

[Max Bowsher]

Robert Collins <robert.collins@syncretize.net> wrote:
>> (gdb) bt full
>> #0  0x004346d3 in rfc1738_do_escape (url=0x0, encode_reserved=1)
>>     at ../setup/rfc1738.cc:92
>>         url = 0x0
>>         buf = 0x0
>>         bufsize = 0
>>         p = 0x12f4790 "hJ/\001"
>>         q = 0x0
>>         i = 0
>>         do_escape = 0
>> #1  0x0043484c in rfc1738_escape_part (url=@0x13784d0)
>>     at ../setup/rfc1738.cc:187
>>         url = (String &) @0x0: Cannot access memory at address 0x0
>> (gdb) bt
>> #0  0x004346d3 in rfc1738_do_escape (url=0x0, encode_reserved=1)
>>     at ../setup/rfc1738.cc:92
>> #1  0x0043484c in rfc1738_escape_part (url=@0x13784d0)
>>     at ../setup/rfc1738.cc:187
>> #2  0x0040c5ef in check_for_cached (pkgsource=@0x12f47a0)
>>     at ../setup/download.cc:91
>
> In here, (pkgsource.sites[n]->key ) is apparently evaluating as a zero
> length string. This should never happen (key must have a value).
>
> However, I'm pretty sure the sites class allows key to have no value, so
> what you need to do is to go to frame 2 or 3 and identify the package
> and site count that it's got. And then work backwards to find out when
> the invalid site is created.

Your email and my 'Diagnosis of setup crash' one crossed. In that, I came to the
same conclusion of zero-length pkgsource.sites[n]->key values being the problem.

Here is a section from that email of mine:
| The site objects with a key of "" are created somewhere
| in the yacc/lex stuff (of which I know nothing) based upon the mirror value
| produced in IniParseFindVisitor::visitFile(). Changing < mirror = String (); >
| to < mirror = String ("."); > on line 69 of IniParseFindVisitor.cc eliminates
| the crash.

I'd also like to add - the empty keys are directly related to having a setup.ini
in the root dir of the package directory - just as having
<pkgdir>/misc/setup.ini causes sites with key 'misc' to be created.

Hopefully, that will mean something to you. If not, I guess its time for me to
learn about yyparse() and friends :-).

> Can you do that? I'll offer what email assistance I can, but until we
> have enough detail to reproduce here, that's all I can offer.

Sure, I understand that you cannot debug a bug that you can't reproduce.
But, if you copy the setup.ini from any mirror-site-named directory up 1
directory to the root of the local package dir, does that not reproduce the bug?

> I'm obviously keen to get this bug fixed...

Me too, but the key of "." as suggested in my other mail seems to work.

Max.




--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Re[3]: cygwin download incomplete - try again - loop?

[Robert Collins]

> -----Original Message-----
> From: Max Bowsher [mailto:maxb@ukf.net] 
> Sent: Monday, 10 June 2002 8:00 PM

> Your email and my 'Diagnosis of setup crash' one crossed. In 
> that, I came to the
> same conclusion of zero-length pkgsource.sites[n]->key values 
> being the problem.

Yes :}. I didn't correctly fix in back in may, String() == String (0);
:[.
 
> I'd also like to add - the empty keys are directly related to 
> having a setup.ini
> in the root dir of the package directory - just as having
> <pkgdir>/misc/setup.ini causes sites with key 'misc' to be created.

Hm. I thought they might be related to the 'download incomplete' message
for some reason. Ah well.

Anyway, I've corrected my incorrect fix.
 
Rob


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: Re[3]: cygwin download incomplete - try again - loop?

[Max Bowsher]

Robert Collins <robert.collins@syncretize.net> wrote:
>> -----Original Message-----
>> From: Max Bowsher [mailto:maxb@ukf.net]
>> Sent: Monday, 10 June 2002 8:00 PM
> 
>> Your email and my 'Diagnosis of setup crash' one crossed. In
>> that, I came to the
>> same conclusion of zero-length pkgsource.sites[n]->key values
>> being the problem.
> 
> Yes :}. I didn't correctly fix in back in may, String() == String (0);
> :[.
> 
>> I'd also like to add - the empty keys are directly related to
>> having a setup.ini
>> in the root dir of the package directory - just as having
>> <pkgdir>/misc/setup.ini causes sites with key 'misc' to be created.
> 
> Hm. I thought they might be related to the 'download incomplete' message
> for some reason. Ah well.
> 
> Anyway, I've corrected my incorrect fix.
> 
> Rob

I confirm this bug is squished in cvs.

Max.




--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: cygwin download incomplete - try again - loop?

[Roberto Morello]

Hello,

I have had similar issues with ALL versions within the snapshot directory.
In all cases I was trying to download everything, ie selecting INSTALL 
at the root of the tree.

roberto


Pavel Tsekov wrote:

>Hello Ralf,
>
>Try a snapshot version of the installer. You can get one from
>http://www.cygwin.com/setup-snapshots. The latest binary
>there is setup-2.249.2.1.exe
>
>RH> Hi, when I use cygwin's setup.exe. to try to "install from Internet" -
>RH> System - setup 2.218.2.9-1, I get a "download incomplete - try again?" error
>RH> loop with serveral download sites.
>  
>



--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: cygwin download incomplete - try again - loop?

[Nicholas Wourms]

Simple,

When you install everthing, make sure to scroll down to the setup entry
and change it to "Skip"...  That should fix the problem...

Cheers,
Nicholas
--- Roberto Morello <rmo@adelaide.on.net> wrote:
> Hello,
> 
> I have had similar issues with ALL versions within the snapshot
> directory.
> In all cases I was trying to download everything, ie selecting INSTALL 
> at the root of the tree.
> 
> roberto
> 
> 
> Pavel Tsekov wrote:
> 
> >Hello Ralf,
> >
> >Try a snapshot version of the installer. You can get one from
> >http://www.cygwin.com/setup-snapshots. The latest binary
> >there is setup-2.249.2.1.exe
> >
> >RH> Hi, when I use cygwin's setup.exe. to try to "install from
> Internet" -
> >RH> System - setup 2.218.2.9-1, I get a "download incomplete - try
> again?" error
> >RH> loop with serveral download sites.
> >  
> >
> 
> 
> 
> --
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
> Bug reporting:         http://cygwin.com/bugs.html
> Documentation:         http://cygwin.com/docs.html
> FAQ:                   http://cygwin.com/faq/
> 


__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: cygwin download incomplete - try again - loop?

[robertc]

The setup.exe source should work fine. I fixed that bug on the 20th may.
I just tried, and it works fone for me.

Rob

> -----Original Message-----
> From: cygwin-owner@cygwin.com 
> [mailto:cygwin-owner@cygwin.com] On Behalf Of Nicholas Wourms
> Sent: Friday, 7 June 2002 11:16 PM
> To: Roberto Morello; Pavel Tsekov
> Subject: Re: cygwin download incomplete - try again - loop?
> 
> 
> Simple,
> 
> When you install everthing, make sure to scroll down to the 
> setup entry
> and change it to "Skip"...  That should fix the problem...
> 
> Cheers,
> Nicholas
> --- Roberto Morello <rmo@adelaide.on.net> wrote:
> > Hello,
> > 
> > I have had similar issues with ALL versions within the snapshot
> > directory.
> > In all cases I was trying to download everything, ie 
> selecting INSTALL 
> > at the root of the tree.
> > 
> > roberto
> > 
> > 
> > Pavel Tsekov wrote:
> > 
> > >Hello Ralf,
> > >
> > >Try a snapshot version of the installer. You can get one from
> > >http://www.cygwin.com/setup-snapshots. The latest binary
> > >there is setup-2.249.2.1.exe
> > >
> > >RH> Hi, when I use cygwin's setup.exe. to try to "install from
> > Internet" -
> > >RH> System - setup 2.218.2.9-1, I get a "download incomplete - try
> > again?" error
> > >RH> loop with serveral download sites.
> > >  
> > >
> > 
> > 
> > 
> > --
> > Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
> > Bug reporting:         http://cygwin.com/bugs.html
> > Documentation:         http://cygwin.com/docs.html
> > FAQ:                   http://cygwin.com/faq/
> > 
> 
> 
> __________________________________________________
> Do You Yahoo!?
> Yahoo! - Official partner of 2002 FIFA World Cup
> http://fifaworldcup.yahoo.com
> 
> --
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
> Bug reporting:         http://cygwin.com/bugs.html
> Documentation:         http://cygwin.com/docs.html
> FAQ:                   http://cygwin.com/faq/
> 
> 


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Re[3]: cygwin download incomplete - try again - loop?

[Kilroy, David]

> Its easy to kludge round this, but it strikes me that the 
> problem would be
> better solved by finding out why a null pointer is being 
> passed in the first
> place. Maybe this weekend :-).

I found this lot out a while ago, but thought a fix had been identified by
Pavel/Max and applied in 2.249.xxx. You guys seemed perfectly on track to
identifying the bug in

http://www.cygwin.com/ml/cygwin/2002-05/msg01527.html

So here goes.

What I found is as follows (setup 2.218... files named, in sq bracket are
the files the code was relocated to in 2.249...)

The null pointer is there because the find routines return the path to
setup.ini relative to your local package directory. This is typically

 [rfc1738 encoded ftp site name]/setup.ini

but for the setup.ini in your local package directory, this is

 setup.ini

In ini.c [IniParseFindVisitor.c], you strip /setup.ini from the end of the
path, and pass the remaining string to rfc1738 to decode the ftp location.
You then store the return string as your mirror site.

In the case of the Local Package directory (and 2.218...), you pass null to
the rfc 1738 routines, and they crash.

I haven't checked lately, but I think in 2.249 you may pass "" to rfc1738 to
avoid crashing - however if you do this, a crash occurs later in install.cc
when you ask rfc1738 to encode an empty string (the mirror site you stored
in ini.cc). I'm not sure, but if you pass "setup.ini" to rfc1738  in ini.cc
[IniParseFindVisitor.cc] the correct behaviour occurs. (I chose to pass
"setup.ini" because this is what the pre md5 checksum setup.exe did).

In my opinion, the rfc1738 code should be fixed so it doesn't choke on null
or empty strings (which I think is reasonable), and then you don't need
special code to identify your local cache.

If I am correct, then ralfs crash [in 2.249.xx] occurs after he has selected
everything, and the install is about to take place.

Hope that helps.


Dave.


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Re[3]: cygwin download incomplete - try again - loop?

[Robert Collins]

> -----Original Message-----
> From: cygwin-owner@cygwin.com 
> [mailto:cygwin-owner@cygwin.com] On Behalf Of Kilroy, David

> In my opinion, the rfc1738 code should be fixed so it doesn't 
> choke on null
> or empty strings (which I think is reasonable), and then you 
> don't need
> special code to identify your local cache.

Yes but.... The rfc1738 code is ok, it's the C++ <string> classes that
are choking, and fixing them is a little harder. Adding overhead to
rfc1738 is not good either though :[.

> Hope that helps.

It does, thanks.

Rob


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Re[3]: cygwin download incomplete - try again - loop?

[Heribert Dahms]

Hi Rob,

unless I lost track in the thread,
wouldn't rfc1738 simply need
to check right at the beginning something like
	if (!ptr || !*ptr) return ptr;
and how many million times does setup call it
that it makes a noteable difference to the user?
Or do you re-install cygwin hundred times a day 8-)

Bye, Heribert (heribert_dahms@icon-scm.com)

> -----Original Message-----
> From:	Robert Collins [SMTP:robert.collins@syncretize.net]
> Sent:	Friday, June 07, 2002 17:11
> To:	'Kilroy, David'; cygwin@cygwin.com
> Subject:	RE: Re[3]: cygwin download incomplete - try again - loop?
> 
> >  On Behalf Of Kilroy, David
> 
> > In my opinion, the rfc1738 code should be fixed so it doesn't 
> > choke on null
> > or empty strings (which I think is reasonable), and then you 
> > don't need
> > special code to identify your local cache.
> 
> Yes but.... The rfc1738 code is ok, it's the C++ <string> classes that
> are choking, and fixing them is a little harder. Adding overhead to
> rfc1738 is not good either though :[.
> 

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Re[3]: cygwin download incomplete - try again - loop?

[Robert Collins]

> -----Original Message-----
> From: cygwin-owner@cygwin.com 
> [mailto:cygwin-owner@cygwin.com] On Behalf Of Heribert Dahms
> Sent: Saturday, 8 June 2002 6:12 AM
> To: 'Robert Collins'; 'Kilroy, David'; cygwin@cygwin.com
> Subject: RE: Re[3]: cygwin download incomplete - try again - loop?
> 
> 
> Hi Rob,
> 
> unless I lost track in the thread,
> wouldn't rfc1738 simply need
> to check right at the beginning something like
> 	if (!ptr || !*ptr) return ptr;
> and how many million times does setup call it
> that it makes a noteable difference to the user?
> Or do you re-install cygwin hundred times a day 8-)

Its more a fix the actual bug location thing. Rfc1738's code is (in this
instance) correct. It's a system library that is buggy. Do we work
around the bug or correct it?

Rob


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Re[3]: cygwin download incomplete - try again - loop?

[Robert Collins]

> -----Original Message-----
> From: cygwin-owner@cygwin.com 
> [mailto:cygwin-owner@cygwin.com] On Behalf Of Robert Collins
> Sent: Saturday, 8 June 2002 11:53 PM
> To: 'Heribert Dahms'; 'Kilroy, David'; cygwin@cygwin.com
> Subject: RE: Re[3]: cygwin download incomplete - try again - loop?
> 
> 
> 
> 
> > -----Original Message-----
> > From: cygwin-owner@cygwin.com 
> > [mailto:cygwin-owner@cygwin.com] On Behalf Of Heribert Dahms
> > Sent: Saturday, 8 June 2002 6:12 AM
> > To: 'Robert Collins'; 'Kilroy, David'; cygwin@cygwin.com
> > Subject: RE: Re[3]: cygwin download incomplete - try again - loop?
> > 
> > 
> > Hi Rob,
> > 
> > unless I lost track in the thread,
> > wouldn't rfc1738 simply need
> > to check right at the beginning something like
> > 	if (!ptr || !*ptr) return ptr;
> > and how many million times does setup call it
> > that it makes a noteable difference to the user?
> > Or do you re-install cygwin hundred times a day 8-)
> 
> Its more a fix the actual bug location thing. Rfc1738's code 
> is (in this
> instance) correct. It's a system library that is buggy. Do we work
> around the bug or correct it?

And this is me eating my words. It's a different bug than the zero
length strcmp issue identified before.

Rob


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: Re[3]: cygwin download incomplete - try again - loop?

[Arthur I Schwarz]

Ah, gentlemen, you've saved me some time
The thought that I'd failed, was not sublime
And I spent my poor hours trying to find
  Why.
But, you've saved me some time.

I too have a little bone to pick
A (so sad) setup to kick
I tried and tried to beat the odds
But was lost when 'NULL' did arise
You've saved me some time.

Amidst this doggeral and other things you find
I have an issue which stands up and is not kind
I installed, or uninstalled, valuable things
To find that failure dogged my wings.

Tail dragging,
  feet of lead
I plead and ask
  with heart of dread
When, and where,
  will this damn'd bug be fixed
So when next I setup
  I can say "Setup I did".

art



--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: Re[3]: cygwin download incomplete - try again - loop?

[Max Bowsher]

Arthur I Schwarz <Arthur_I_Schwarz@raytheon.com> wrote:
<snip content=poetry/>
>
> art

Are you talking about the null-pointer-causes-crash problem (sounds like it), or
the download incomplete loop mentioned in the subject (I know, we really should
have reset the subject when this thread wandered onto another bug)?

If it is the former, please send me the output of a 'ls -R' command of your
local package directory at a Cygwin prompt. If you haven't get cygwin working at
all, then use a windows 'dir /s' command instead.

Max.




--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: Re[3]: cygwin download incomplete - try again - loop?

[Max Bowsher]

I'm forwarding this to the cygwin list - its generally not a good idea to use
private mail.

I'm a relative newcomer to cygwin - congratulations belong far more to all the
Cygwin maintainers.

Arthur I Schwarz <Arthur_I_Schwarz@raytheon.com> wrote:
> Max;
>
> Sorry. I was talking about the 'null pointer' problem. The fix was to
> download and install from the 'net.

Should be fixed properly as of setup-2.249.2.2

> However, now that we're talking about wishes (or now that I'm going to
> start to talk about the same), what I like to do is to download the sources
> and executable from the net and then install locally. In the process, I try
> to remove old sources and executables so that, at each upgrade, I have the
> minimum amount of data to support the current installation. For me, the
> idea of being able to support different downloads from different sources in
> different directories is a nuisance because after the build I have to
> migrate the files from their downloaded directory to a common directory. It
> is confusing since I can not then do another install because the original
> directories are purged, and I have no idea what to do about the log and
> .ini files. So my wish is that a 'merge' option be made available. The
> merge would:
>
> [1] Migrate all code from the download directory(ies) to some common
> directory.
> [2] The log an .ini files be merged in like fashion.
> [3] Following the merge, it becomes possible to do an install from this
> common branch.

For [1] and [3], Michael Chase has a Perl script called clean_setup.pl which
does this: http://home.ix.netcom.com/~mchase/zip/

As for [2], the log files don't need merging (There are only two sets, one in
the package directory and one in /var/log), setup.inis from the cygwin mirrors
all contain the same content anyway (assuming all the copies of it are up to
date.

If you also download non-official cygwin packages via setup, then I suggest
using the ignore option of clean_setup.pl to ignore those directories. Setup.exe
will dynamically pick up setup.ini files in subdirs of it package cache, so by
leaving the non-official stuff in its own tree, it doesn't muddle up the main
tree.

> Somewhere in the mailing list there is a thread which addresses the
> multiple directories as an issue, and other threads address the 'null
> pointer' problem, the confusion issues, the 'Download incomplete' problem,
> and other things which seem to be incident in the current release.
>
> My frustration is that I am currently trying to change the (local)
> corporate mindset to use Cygwin (and maybe get paid support). I am, oh, I
> don't know, frustrated in that I don't understand the process of
> installation any more. The other day I copied to CD-ROM my 'stuff' and
> attempted to install it onto a WinNT machine. After the 'blue screen of
> death (BSOD), I downloaded all files from a mirror site and completed the
> install. Even at mega-speeds it takes a while to download 4-500 megabytes.

Hmm. If you still have the CD around, please ls -R or dir /s it, and send the
output of one of those commands to me be private mail (no need to spam the list
with that).
What you are trying to do is certainly possible, though.

> And after all this griping, thanks. I can't tell you how many times my
> epidermis was mildly gratified with Cygwin.
>
> art

Max.





--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/