Re: indent.exe strangeness

Re: indent.exe strangeness

[Robert Collins]

===
----- Original Message -----
From: "Christopher Faylor" <cgf@redhat.com>
To: <cygwin@cygwin.com>
Sent: Friday, November 16, 2001 6:21 AM
Subject: Re: indent.exe strangeness


> On Thu, Nov 15, 2001 at 11:19:12PM +1100, Robert Collins wrote:
> >> What about a patch that would fopen() every file in binmode and
write it
> >> back according to the mount?
> >
> >I think that textmode.o is the correct tool rather than a patch -
read
> >every file in textmode (they are source after all :]) and write in
> >textmode.
>
> No.  That would end up putting CRLF on every file.  I doubt that
people
> with binmode mounts would be pleased.

They shouldn't care if all the text process tools have been ported
correctly. Thats the whole point of textmode and binmode ain't it?

Certinaly squid _always_ writes text data with textmode, and binary data
with binmode, and I've heard no complaints w.r.t this.

> automode.o should take any file and create a file with only LF line
> endings.  This will be correctly interpreted by just about every tool
> except older versions of notepad.exe.

FWIW my win2k notepad still chokes. Anyway, I've start to be picky here,
so I'll just be quite now :}.

Rob


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: indent.exe strangeness

[Kevin Schnitzius]

Are your source drives mounted as binary or text?

Kevin

 -----Original Message-----
From: 	BMetzenthen@cochlear.com.au [mailto:BMetzenthen@cochlear.com.au] 
Sent:	Wednesday, November 14, 2001 21:58
To:	cygwin@cygwin.com
Subject:	indent.exe strangeness

I've tried a few approaches with obtaining (or building) indent.exe but the
executable always seems to include extra ^M characters (usually following
the whitespace which is inserted at the start of lines) to the beautified
output.

Does anyone know if this is:
(a) a run-time configuration problem,
(b) a corrupted/out-of-date dll, or
(c) a known bug with indent?


Bill

============================================================================
==========

"The information contained in this e-mail message may be confidential
information, and may also be privileged. If you are not the intended
recipient, any use, interference with, disclosure or copying of this
material is unauthorised and prohibited.  If you have received this message
in error, please notify us by return email and delete the original message."

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: indent.exe strangeness

[Christopher Faylor]

On Wed, Nov 14, 2001 at 10:05:14PM -0500, Kevin Schnitzius wrote:
>Are your source drives mounted as binary or text?

Actually if you add /usr/lib/automode.o it might just cause this to be
a non-issue.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: indent.exe strangeness

[Robert Collins]

----- Original Message -----
From: "Christopher Faylor" <cgf@redhat.com>
To: <cygwin@cygwin.com>
Sent: Thursday, November 15, 2001 2:08 PM
Subject: Re: indent.exe strangeness


> On Wed, Nov 14, 2001 at 10:05:14PM -0500, Kevin Schnitzius wrote:
> >Are your source drives mounted as binary or text?
>
> Actually if you add /usr/lib/automode.o it might just cause this to be
> a non-issue.

Won't this do the wrong thing on text mode mounts? (ie write in binary
not text mode).

Rob


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: indent.exe strangeness

[Gerrit P. Haase]

Hallo Robert,

2001-11-15 12:14:29, du schriebst:

>> On Wed, Nov 14, 2001 at 10:05:14PM -0500, Kevin Schnitzius wrote:
>>>Are your source drives mounted as binary or text?
>>
>> Actually if you add /usr/lib/automode.o it might just cause this to be
>> a non-issue.

> Won't this do the wrong thing on text mode mounts? (ie write in binary
> not text mode).

On textmounts it works with every kind of file, though binmode files
will be converted to texmode files.
On binmode mounts, it doesn't work as expected with textmode files.

automode.o linked in causes that every output file is in binmode, but
then it works without additional ^M's for every kind of file.

That is how Robert said the wrong thing here.

What about a patch that would fopen() every file in binmode and write it
back according to the mount?

Gerrit
-- 
convey Information Systems GmbH                   http://www.convey.de/
                                                  Vitalisstraße 326-328
Gerrit P. Haase                                   D-50933 Köln
gerrit.haase@convey.de                            Fon: ++49 221 6903922


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: indent.exe strangeness

[Robert Collins]

----- Original Message -----
From: "Gerrit P. Haase" <freeweb@nyckelpiga.de>
To: <cygwin@cygwin.com>
Sent: Thursday, November 15, 2001 10:40 PM
Subject: Re: indent.exe strangeness


> Hallo Robert,
>
> 2001-11-15 12:14:29, du schriebst:
...
> >> Actually if you add /usr/lib/automode.o it might just cause this to
be
> >> a non-issue.
>
> > Won't this do the wrong thing on text mode mounts? (ie write in
binary
> > not text mode).
>
...> automode.o linked in causes that every output file is in binmode,
but
> then it works without additional ^M's for every kind of file.
>
> That is how Robert said the wrong thing here.

Uhmm I said "write in binary mode" and thats what you just said "output
file is in binmode". I don't understand where I was wrong.

> What about a patch that would fopen() every file in binmode and write
it
> back according to the mount?

I think that textmode.o is the correct tool rather than a patch - read
every file in textmode (they are source after all :]) and write in
textmode.

Rob


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: indent.exe strangeness

[Christopher Faylor]

On Thu, Nov 15, 2001 at 11:19:12PM +1100, Robert Collins wrote:
>> What about a patch that would fopen() every file in binmode and write it
>> back according to the mount?
>
>I think that textmode.o is the correct tool rather than a patch - read
>every file in textmode (they are source after all :]) and write in
>textmode.

No.  That would end up putting CRLF on every file.  I doubt that people
with binmode mounts would be pleased.

automode.o should take any file and create a file with only LF line
endings.  This will be correctly interpreted by just about every tool
except older versions of notepad.exe.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: indent.exe strangeness

[Gerrit P. Haase]

Hallo Christopher,

Am 2001-11-15 um 20:21 schriebst du:

> On Thu, Nov 15, 2001 at 11:19:12PM +1100, Robert Collins wrote:
>>> What about a patch that would fopen() every file in binmode and write it
>>> back according to the mount?
>>
>>I think that textmode.o is the correct tool rather than a patch - read
>>every file in textmode (they are source after all :]) and write in
>>textmode.

> No.  That would end up putting CRLF on every file.  I doubt that people
> with binmode mounts would be pleased.

> automode.o should take any file and create a file with only LF line
> endings.  This will be correctly interpreted by just about every tool
> except older versions of notepad.exe.

But every file that is in textmode with CR/LF will be converted to binmode
lineendings then?

Ciao,

Gerrit P. Haase                            mailto:gp@familiehaase.de
-- 
=^..^=


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: indent.exe strangeness

[Christopher Faylor]

On Thu, Nov 15, 2001 at 10:11:34PM +0100, Gerrit P. Haase wrote:
>Am 2001-11-15 um 20:21 schriebst du:
>>automode.o should take any file and create a file with only LF line
>>endings.  This will be correctly interpreted by just about every tool
>>except older versions of notepad.exe.
>
>But every file that is in textmode with CR/LF will be converted to
>binmode lineendings then?

...and...?  You're rephrasing what I said above.  What are you not
understanding?  A file that *possibly* used to have lines ending
with \r\n will be converted to using \n instead.

We've had many discussions about this in the past and it seems like
this is the best compromise solution.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: indent.exe strangeness

[Gerrit P. Haase]

Hallo Robert,

2001-11-15 16:31:49, du schriebst:

>>>> Actually if you add /usr/lib/automode.o it might just cause this to

> Uhmm I said "write in binary mode" and thats what you just said "output
> file is in binmode". I don't understand where I was wrong.

>> What about a patch that would fopen() every file in binmode and write
> it
>> back according to the mount?

> I think that textmode.o is the correct tool rather than a patch - read
> every file in textmode (they are source after all :]) and write in
> textmode.

Oops sorry, I meant open() in textmode and write according to the mounttype,
in binmode or in textmode.
If I use textmode as default wouldn't every file be written in textmode?

I patched only two lines now and it works ok., well if you open a file it
is read in textmode and on a textmount it will be written in textmode, on
a binmode mount it will be written in binmode. Vice versa for texmode files.

Then it depends on the mount type and not on how the lineendings of the input
file were.

Gerrit
-- 
convey Information Systems GmbH                   http://www.convey.de/
                                                  Vitalisstraße 326-328
Gerrit P. Haase                                   D-50933 Köln
gerrit.haase@convey.de                            Fon: ++49 221 6903922


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: indent.exe strangeness

[Christopher Faylor]

On Thu, Nov 15, 2001 at 12:40:23PM +0100, Gerrit P. Haase wrote:
>Hallo Robert,
>
>2001-11-15 12:14:29, du schriebst:
>
>>> On Wed, Nov 14, 2001 at 10:05:14PM -0500, Kevin Schnitzius wrote:
>>>>Are your source drives mounted as binary or text?
>>>
>>> Actually if you add /usr/lib/automode.o it might just cause this to be
>>> a non-issue.
>
>> Won't this do the wrong thing on text mode mounts? (ie write in binary
>> not text mode).
>
>On textmounts it works with every kind of file, though binmode files
>will be converted to texmode files.

That's not how automode.o works.

cgf


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: indent.exe strangeness

[Christopher Faylor]

On Fri, Nov 16, 2001 at 08:45:48AM +1100, Robert Collins wrote:
>
>===
>----- Original Message -----
>From: "Christopher Faylor" <cgf@redhat.com>
>To: <cygwin@cygwin.com>
>Sent: Friday, November 16, 2001 6:21 AM
>Subject: Re: indent.exe strangeness
>
>
>> On Thu, Nov 15, 2001 at 11:19:12PM +1100, Robert Collins wrote:
>>>>What about a patch that would fopen() every file in binmode and write
>>>>it back according to the mount?
>>>
>>>I think that textmode.o is the correct tool rather than a patch - >read
>>>every file in textmode (they are source after all :]) and write in
>>>textmode.
>>
>>No.  That would end up putting CRLF on every file.  I doubt that people
>>with binmode mounts would be pleased.
>
>They shouldn't care if all the text process tools have been ported
>correctly.  Thats the whole point of textmode and binmode ain't it?

Well, *I* care if a system which purports to emulate linux outputs
text files with CRLF line endings with no way to control this.

I would think that someone who is using binmode defaults would prefer
that their files not be translated from LF to CRLF line endings.  That
would bypass the whole point of the mount settings.  It would mean
that if you were trying to share files with UNIX, you'd have to
run the files through a "strip the CR" converter.

Maybe you could say the same thing for people who have text files in
MS-DOS format.  I'm sure that there is some other bit of crucial
software out there that croaks unless it is fed a text file with CRLF
endings but it is certainly not going to be a UNIX program.

As I said, the last I heard this was only an issue for notepad.
Although, I will admit to the horrifying possibility that it is all
versions of notepad, not just older versions.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: indent.exe strangeness

[Larry Hall (RFK Partners, Inc)]

At 05:08 PM 11/15/2001, Christopher Faylor wrote:
>On Fri, Nov 16, 2001 at 08:45:48AM +1100, Robert Collins wrote:
> >
> >===
> >----- Original Message -----
> >From: "Christopher Faylor" <cgf@redhat.com>
> >To: <cygwin@cygwin.com>
> >Sent: Friday, November 16, 2001 6:21 AM
> >Subject: Re: indent.exe strangeness
> >
> >
> >> On Thu, Nov 15, 2001 at 11:19:12PM +1100, Robert Collins wrote:
> >>>>What about a patch that would fopen() every file in binmode and write
> >>>>it back according to the mount?
> >>>
> >>>I think that textmode.o is the correct tool rather than a patch - >read
> >>>every file in textmode (they are source after all :]) and write in
> >>>textmode.
> >>
> >>No.  That would end up putting CRLF on every file.  I doubt that people
> >>with binmode mounts would be pleased.
> >
> >They shouldn't care if all the text process tools have been ported
> >correctly.  Thats the whole point of textmode and binmode ain't it?
>
>Well, *I* care if a system which purports to emulate linux outputs
>text files with CRLF line endings with no way to control this.
>
>I would think that someone who is using binmode defaults would prefer
>that their files not be translated from LF to CRLF line endings.  That
>would bypass the whole point of the mount settings.  It would mean
>that if you were trying to share files with UNIX, you'd have to
>run the files through a "strip the CR" converter.
>
>Maybe you could say the same thing for people who have text files in
>MS-DOS format.  I'm sure that there is some other bit of crucial
>software out there that croaks unless it is fed a text file with CRLF
>endings but it is certainly not going to be a UNIX program.
>
>As I said, the last I heard this was only an issue for notepad.
>Although, I will admit to the horrifying possibility that it is all
>versions of notepad, not just older versions.



At the risk of this becoming a "me too" message, I agree with Chris on
the text/binary issue here.  As far as Notepad goes, it is apparently
one application that MS refuses to fix and also refuses to stop 
delivering! ;-)



Larry Hall                              lhall@rfk.com
RFK Partners, Inc.                      http://www.rfk.com
838 Washington Street                   (508) 893-9779 - RFK Office
Holliston, MA 01746                     (508) 893-9889 - FAX


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: indent.exe strangeness

[Robert Collins]

I'm not sure. Squid 'knows' which fils are which by virtue of what they
are needed for - ie config files - text, cached data - binary, output
logs - text, cache data log - binary.

Rob
===
----- Original Message -----
From: "Gerrit P. Haase" <gp@familiehaase.de>
To: "Robert Collins" <robert.collins@itdomain.com.au>
Sent: Friday, November 16, 2001 9:43 AM
Subject: Re: indent.exe strangeness


> Hallo Robert,
>
> Am 2001-11-15 um 22:45 schriebst du:
>
> > They shouldn't care if all the text process tools have been ported
> > correctly. Thats the whole point of textmode and binmode ain't it?
>
> > Certinaly squid _always_ writes text data with textmode, and binary
data
> > with binmode, and I've heard no complaints w.r.t this.
>
> How do I detect if a file is in text or in binmode (the easy way)?
>
> Ciao,
>
> Gerrit P. Haase                            mailto:gp@familiehaase.de
> --
> =^..^=
>
>


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

indent.exe strangeness

[BMetzenthen]

I've tried a few approaches with obtaining (or building) indent.exe but the
executable always seems to include extra ^M characters (usually following
the whitespace which is inserted at the start of lines) to the beautified
output.

Does anyone know if this is:
(a) a run-time configuration problem,
(b) a corrupted/out-of-date dll, or
(c) a known bug with indent?


Bill

======================================================================================

"The information contained in this e-mail message may be confidential information, and may also be privileged. If you are not the intended recipient, any use, interference with, disclosure or copying of this material is unauthorised and prohibited.  If you have received this message in error, please notify us by return email and delete the original message."

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

RE: indent.exe strangeness

[BMetzenthen]

Bingo!  That was the problem.  Thanks.

I was using /cygdrive/..., which are binmode.

Mounting the win directories under the cygwin heirarchy in text mode solved
that little problem.

I operate cygwin the same way as I use Linux, ignoring binmode/textmode
until it bites me (usually, this means ^M characters appear at line
endings, not in the middle of lines).  I assume that the appropriate thing
to do here would be to patch the indent sources to make it work as expected
when using binary mounted directories.

Bill


                                                                                                                 
                    Kevin Schnitzius                                                                             
                    <kevin.schnitzius@c        To:     "'BMetzenthen@cochlear.com.au'"                           
                    itrix.com>                 <BMetzenthen@cochlear.com.au>, cygwin@cygwin.com                  
                                               cc:                                                               
                    15/11/2001 14:05           Subject:     RE: indent.exe strangeness                           
                                                                                                                 
                                                                                                                 




Are your source drives mounted as binary or text?

Kevin

 -----Original Message-----
From:           BMetzenthen@cochlear.com.au
[mailto:BMetzenthen@cochlear.com.au]
Sent:           Wednesday, November 14, 2001 21:58
To:        cygwin@cygwin.com
Subject:        indent.exe strangeness

I've tried a few approaches with obtaining (or building) indent.exe but the
executable always seems to include extra ^M characters (usually following
the whitespace which is inserted at the start of lines) to the beautified
output.

Does anyone know if this is:
(a) a run-time configuration problem,
(b) a corrupted/out-of-date dll, or
(c) a known bug with indent?


Bill

============================================================================

==========

"The information contained in this e-mail message may be confidential
information, and may also be privileged. If you are not the intended
recipient, any use, interference with, disclosure or copying of this
material is unauthorised and prohibited.  If you have received this message
in error, please notify us by return email and delete the original
message."

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/




======================================================================================

"The information contained in this e-mail message may be confidential information, and may also be privileged. If you are not the intended recipient, any use, interference with, disclosure or copying of this material is unauthorised and prohibited.  If you have received this message in error, please notify us by return email and delete the original message."

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/