From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20720.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eae::720]) by sourceware.org (Postfix) with ESMTPS id 6CEA93857C79 for ; Tue, 11 Aug 2020 11:14:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6CEA93857C79 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gcgn5XhhfaACNC/SYyxE/oWGt0pxHJjWWbznQaB1di/rdlrlyQIWEYk41Mofl4vN7d177wdcBZawOXtYTRNTDPxAvxTlrNX+zuvTMqCUvRhcxjuqcxo+p0ZGMOisThgY4DBxP2fvEUMRIFiLfkI3HLYDDJL07cj/9HjvbCHsdi/VsPF7y1qeBO5DHmJFHkabQGq4IxHUZn9ipbDLChrmYcCcKfkDu1SRBfY/0DUSM4W4fQeu3yhvwSx686ZOt7/7FHLmpuNFHyniHvxYcXduBatrVmT0B18ssIPK4iifMJwI4NSy49vwjONeDUPm+AEJV9DHtzdvL9I405xThLzD1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C12j0tOu5B7GeRXJtu08cQyoTUWmcHNY98pHIlsOYeE=; b=UWLcrMByrCH09K6ThALhQESaEm6LwZnNubyH1+MxeJSUKx7LA09pjUHu36R7qYHAWNQuUgf3/VAX4MevK/QB9NcVJbw5whW+H72DPtwCdJ0tIBmz5bglXtUcjZPTAJOXv7vofYsgFSyuTCgZ7fZktZU5Bf/sRHLboIObmReMK6DSui+youKIx1rMpbyibqUkTyWx3IJzWw1CJJebT8jF9CO0WhWL41XlnJ5a5c7TnsfFzPC1o/A612wlawkUTE+OEXW8GzmCOjdi6cUHMq0Qbqobz3PtvmDR+kSBvNd0ldrhP3kPal6TBryPZ2u7zoIYUJXPSYIUejI1tmEpB0gcpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none Received: from MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) by MN2PR04MB5744.namprd04.prod.outlook.com (2603:10b6:208:3a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.20; Tue, 11 Aug 2020 11:13:54 +0000 Received: from MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::184d:a265:1d48:499a]) by MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::184d:a265:1d48:499a%7]) with mapi id 15.20.3261.024; Tue, 11 Aug 2020 11:13:54 +0000 Subject: Re: [ANNOUNCEMENT] Updated: curl 7.71.1-1 To: cygwin@cygwin.com References: <4f1d6241-c86b-f2f9-7b49-a9f5b998b0eb@SystematicSw.ab.ca> <53c7f2a7-3bd8-f90c-b574-969d6b31f300@cornell.edu> <71031f78-b1be-aec2-4e54-72ff49e07543@SystematicSw.ab.ca> From: Ken Brown Message-ID: <11d99d00-55fb-f6a2-893d-f5ebb6e7a14b@cornell.edu> Date: Tue, 11 Aug 2020 07:13:51 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 In-Reply-To: <71031f78-b1be-aec2-4e54-72ff49e07543@SystematicSw.ab.ca> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: CH2PR11CA0024.namprd11.prod.outlook.com (2603:10b6:610:54::34) To MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.17] (68.175.129.7) by CH2PR11CA0024.namprd11.prod.outlook.com (2603:10b6:610:54::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.18 via Frontend Transport; Tue, 11 Aug 2020 11:13:53 +0000 X-Originating-IP: [68.175.129.7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d930512-ea62-4b12-09a2-08d83de7a1fe X-MS-TrafficTypeDiagnostic: MN2PR04MB5744: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PK5zG0GvDQTSn0g+flyJZ0hiTZcRPF7smjkD5SdtflvK5efiaObpbsjzU3hDa0vVd6EPIUBtY60Dry+Sf61Bg5CVbnxgrNAt4Ol57p8d79NPV7eDU/WhJMfEqAbH1RfXN7ubdDQG8RwxBUJFf0iGu/VN33cBRELEKoyXJ4xTVu20JoS6hKg7ndj77QGRVGULy7GvN/JHm8sqvOA0p248O1TvyLFahIVBPXqUZF8Rl2/ZMuux4IKL+NygAbF4nslM+8JGBCMyRlt67lBv7LJEvdhE8ghuye00+3lFmi9Pl9/zUWgvdJ3HvP2x4wtWaKl4QuFYzi5y9m7mFdELSecfrjMZwty0AbobJj9yaJe9bi0qQWbGGrC7hk3wqX3wwCEJzFC5MeY3EDlu49MJMJak3A96LEgT5Bo4jWW8imJ4MZJ9M2ttsB42Ddm/R3ZJnFpksrmhrUO4N75LivDoYVuGNA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR04MB6176.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(346002)(39860400002)(396003)(136003)(366004)(186003)(16526019)(52116002)(2616005)(966005)(53546011)(956004)(5660300002)(31696002)(15650500001)(8676002)(83380400001)(36756003)(478600001)(16576012)(31686004)(2906002)(66946007)(75432002)(66556008)(6486002)(86362001)(8936002)(6916009)(26005)(786003)(316002)(66476007)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: CSn8s0QwD7noLWk2aS6YCB9b4NwaA3p2i3CDwUXJaRTFWvaSInAbLFS53pPq1e2zZ8ejvSzCFJ77dpOkXIXBuzKTQv4ohWuKy0Av7ZmSIIV84tN0xU6ZRYenJCJL7ieql+79b8kzJIkB3S5+JJkO5XyLhCBd1pzkSvtY0d6jLxi7ATizfwoRRJNAn6Gbm/Q1nNuJ6AW8oINB8xv7pE/tbJtozvCm0f4B+L4WyA0cgc/14yeizzenfQ3jImBkL9vcBH+TUjHo6/cBGtPTfFf0ONd79nciBIpda9dv5HcbtvWHjcyYTWn1tA9jtz+sfLTN49dEMHgZUg569bbKUVRn/ev0P+e7CRYMCW4xnXUH7kDbNl816iBoOBf8h+3v/+VQthv6pRQcHS0ISPcWBfsjHqTT6nRF8GHoxTGOPvUQAyjLmFuxrntOMobmKiIk2PRVQfDdWvVn4OlA0TeekCM7xu1cKyASgpKP+5DS9+ECmx0Vf3OSMBbsKp8/p1tRYnp9+BaunDFh6giIbYM8Pt5qdKg2hqdgajq64+ppjPdLHZ+EiYyKBtXUWTIG7vmghVPe7RTMKnkG24qY4Vq4EelyqGJJULA3I3B7clVjob3g5pHJq2hF0VH0hLZ6ToA1GqYSTZvk1q95b0y7jzmh5P8dkw== X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 4d930512-ea62-4b12-09a2-08d83de7a1fe X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6176.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2020 11:13:53.9803 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O+ixECgvhKxJB0roq9zIOqwoyArj0V6u9pLEXUQ/0LU0h5ZxUuS9i9g7Qvhi5VJACrbDyWO5lOboq2tqe7KzzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5744 X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00, DKIM_INVALID, DKIM_SIGNED, KAM_DMARC_STATUS, KAM_NUMSUBJECT, KAM_SHORT, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Aug 2020 11:14:07 -0000 On 8/10/2020 9:27 PM, Brian Inglis wrote: > On 2020-08-10 13:14, Ken Brown via Cygwin wrote: >> On 8/10/2020 1:33 PM, Brian Inglis wrote: >>> On 2020-08-10 08:52, Ken Brown via Cygwin wrote: >>>> On 8/9/2020 5:48 PM, Brian Inglis wrote: >>>>> On 2020-08-09 12:28, Adam Dinwoodie wrote: >>>>>> On Fri, 24 Jul 2020 at 13:56, Adam Dinwoodie wrote: >>>>>>> In the failing case, the `/configure` stage includes the following >>>>>>> text: `configure: Setting CURL_LDFLAGS to '-lcurl -lnghttp2 -lidn2 >>>>>>> -lssh -lpsl -lssl -lcrypto -lldap -llber -lbrotlidec -lbrotlidec >>>>>>> -lz'`; in the working case using -7.66.0-1, the corresponding line is >>>>>>> just `configure: Setting CURL_LDFLAGS to '-lcurl'`. >>>> [...] >>>>> Meanwhile, that info likely comes from: >>>>> >>>>> $ tail -vn15 /lib/pkgconfig/libcurl.pc >>>>> ==> /lib/pkgconfig/libcurl.pc <== >>>>> # >>>>> prefix=/usr >>>>> exec_prefix=/usr >>>>> libdir=${exec_prefix}/lib >>>>> includedir=${prefix}/include >>>>> supported_protocols="DICT FILE FTP FTPS GOPHER HTTP HTTPS IMAP IMAPS LDAP LDAPS >>>>> POP3 POP3S RTSP SCP SFTP SMB SMBS SMTP SMTPS TELNET TFTP" >>>>> supported_features="SSL IPv6 UnixSockets libz brotli AsynchDNS IDN PSL NTLM >>>>> NTLM_WB TLS-SRP HTTP2 HTTPS-proxy" >>>>> >>>>> Name: libcurl >>>>> URL: https://curl.haxx.se/ >>>>> Description: Library to transfer files with ftp, http, etc. >>>>> Version: 7.71.1 >>>>> Libs: -L${libdir} -lcurl >>>>> Libs.private: -lnghttp2 -lidn2 -lssh -lpsl -lssl -lcrypto -lldap -llber >>>>> -lbrotlidec -lbrotlidec -lz >>>>> Cflags: -I${includedir} >>>>> >>>>> it looks like your git build should be using Libs for dynamic builds and adding >>>>> Libs.private for static builds >>> >>>> If you look at configure.ac in the git sources, you'll see that it uses >>>> curl-config, not pkg-config.  The former reports: >>>> >>>> $ curl-config --libs >>>> -lcurl -lnghttp2 -lidn2 -lssh -lpsl -lssl -lcrypto -lldap -llber -lbrotlidec >>>> -lbrotlidec -lz >>>> >>>> Yaakov's build of earlier versions of curl used a patch 7.33.0-libdeps.patch to >>>> prevent the unnecessary libs from being listed.  He even had a comment at the >>>> beginning of the patch, explaining the reason for it: "These are needed only for >>>> static linking, but we build with --disable-static". >>> >>> I try to avoid looking at autotools plumbing if I can possibly avoid it! ;^> >>> Someone cleaned up the approach used, as the patch did not apply and was dropped. >> >> My point is that the patch shouldn't have been dropped.  It should have been >> modified to apply to the updated sources.  (I've done this.  See the attached.) >> As Yaakov wrote, the patch is needed to prevent 'curl-config --libs' from >> including libs that are only needed for static linking. >> >> With the modified patch applied, curl-config gives the expected result: >> >> $ curl-config --libs >> -lcurl >> >>> If you look at my later post, cygport git build and tests worked for me with no >>> problems other than at first missing some package build dependencies >> >> Those were not really build dependencies.  They only appeared to be needed >> because 'curl-config --libs' erroneously included libs that are only needed for >> static linking. > > Your patch seems to reproduce exactly what is currently distributed in the > libcurl-devel package: > > $ tail -n7 /lib/pkgconfig/libcurl.pc > Name: libcurl > URL: https://curl.haxx.se/ > Description: Library to transfer files with ftp, http, etc. > Version: 7.71.1 > Libs: -L${libdir} -lcurl > Libs.private: -lnghttp2 -lidn2 -lssh -lpsl -lssl -lcrypto -lldap -llber > -lbrotlidec -lbrotlidec -lz > Cflags: -I${includedir} Are you saying that you still get the Libs.private line in libcurl.pc if you rebuild the curl package with my patch? That's not what I see. > Perhaps I am misunderstanding: I was addressing the OP build issue; are you > perhaps concerned solely with the correct operation of curl-config? The OP build issue resulted from the incorrect operation of curl-config. I gave you a patch that restores the operation of curl-config to the way it was in previous curl builds. That should fix the OP build issue. > In that case, it looks to me as if the generated curl-config --libs statements: > > if test "Xyes" = "Xno" -o "Xyes" = "Xyes"; then > echo ${CURLLIBDIR}-lcurl -lnghttp2 -lidn2 -lssh -lpsl -lssl -lcrypto > -lldap -llber -lbrotlidec -lbrotlidec -lz > > based on curl-config.in: > > if test "X@ENABLE_SHARED@" = "Xno" -o "X@REQUIRE_LIB_DEPS@" = "Xyes"; then > echo ${CURLLIBDIR}-lcurl @LIBCURL_LIBS@ > > REQUIRE_LIB_DEPS should be no, derived from configure.ac: > > if test "X$enable_shared" = "Xyes" -a "X$link_all_deplibs" = "Xno" > then > REQUIRE_LIB_DEPS=no > else > REQUIRE_LIB_DEPS=yes > fi > AC_SUBST(REQUIRE_LIB_DEPS) > AM_CONDITIONAL(USE_EXPLICIT_LIB_DEPS, test x$REQUIRE_LIB_DEPS = xyes) > > but for Cygwin link_all_deplibs remains defaulted to unknown, so either that > variable should be set in configure, or that condition should perhaps be changed > to: > > if test "X$enable_shared" = "Xyes" -a "X$link_all_deplibs" != "Xyes" > > with appropriate bug reports and changes to be made upstream if possible. If you want to look into ways of fixing curl-config different from what Yaakov did, that's fine; you're the maintainer. All I did was look at Yaakov's patch and port it to curl 7.71.1, that being a quick and easy way to fix the reported problem. Ken