From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23284 invoked by alias); 2 Mar 2017 18:45:55 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 21708 invoked by uid 89); 2 Mar 2017 18:45:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1850, H*MI:sk:8c9fefe, H*f:sk:8c9fefe, H*i:sk:8c9fefe X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Mar 2017 18:45:52 +0000 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6763F3D94F for ; Thu, 2 Mar 2017 18:45:53 +0000 (UTC) Received: from [10.10.124.87] (unknown [10.10.124.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id 082082D654 for ; Thu, 2 Mar 2017 18:45:52 +0000 (UTC) Subject: Re: [ANNOUNCEMENT] Updated: dash-0.5.9.1-1 To: cygwin@cygwin.com References: <485AF0C5-7E1B-49AA-BE3E-C3717DA3268B@solidrocksystems.com> <58b811b2.261d9d0a.7c759.299d@mx.google.com> <8c9fefe1-a377-9188-62ac-ef960b639b75@SystematicSw.ab.ca> From: Eric Blake Openpgp: url=http://people.redhat.com/eblake/eblake.gpg Message-ID: <13c0a1ce-e254-4072-170c-f8c88ec06be9@redhat.com> Date: Thu, 02 Mar 2017 18:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <8c9fefe1-a377-9188-62ac-ef960b639b75@SystematicSw.ab.ca> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="exjhqVQ4vwsoV1e7AHGvR2OoveAK2bLX1" X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00025.txt.bz2 --exjhqVQ4vwsoV1e7AHGvR2OoveAK2bLX1 Content-Type: multipart/mixed; boundary="es4AGicmA11X8W1ilRoaofenKkSp9hElJ"; protected-headers="v1" From: Eric Blake To: cygwin@cygwin.com Message-ID: <13c0a1ce-e254-4072-170c-f8c88ec06be9@redhat.com> Subject: Re: [ANNOUNCEMENT] Updated: dash-0.5.9.1-1 References: <485AF0C5-7E1B-49AA-BE3E-C3717DA3268B@solidrocksystems.com> <58b811b2.261d9d0a.7c759.299d@mx.google.com> <8c9fefe1-a377-9188-62ac-ef960b639b75@SystematicSw.ab.ca> In-Reply-To: <8c9fefe1-a377-9188-62ac-ef960b639b75@SystematicSw.ab.ca> --es4AGicmA11X8W1ilRoaofenKkSp9hElJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1851 On 03/02/2017 11:28 AM, Brian Inglis wrote: > summary of checkbashisms -f run on 140 POSIX shell scripts as=20 > identified by file in my Cygwin 64 /bin/ with 784 packages (about 20%=20 > of cygwin-pkg-maint, 8% of setup.ini) installed, 70 possible issues=20 > (some from wrapped scripts because of -f):=20 Looking through some of the output, I already spot a few interesting things: > possible bashism in /bin/autoconf-2.69 line 55 ($BASH_SOMETHING): > if test -z "$BASH_VERSION$ZSH_VERSION" \ > && (test "X`print -r -- $as_echo`" =3D "X$as_echo") 2>/dev/null; then Not a problem - the script is probing whether it needs to do something based on being bash or not, but is written with all shells in mind. > error: /bin/autoconf-2.69: Unterminated quoted string found, EOF reached.= Wanted: <'>, opened in line 429 bug in checkbashisms; looks like it happens in several places in the output > possible bashism in /bin/autopoint line 57 ($RANDOM): > tmp=3D$TMPDIR/gt$$-$RANDOM Not a problem - the script is using $RANDOM for an additional level of safety, but works safely even when $RANDOM is the empty string (as on dash). > possible bashism in /bin/bzgrep line 66 (${parm/?/pat[/str]}): > j=3D${i//\\/\\\\} First real problem. Except that 'grep j=3D /bin/bzgrep' has no hits on my system with bzip2-1.0.6-2 installed; what version was this problem in? > possible bashism in /bin/messagebus-config line 26 (should be '.', not 's= ource'): > source ${CSIH_SCRIPT} Ah - now we get to an example file that is Cygwin-only (part of the Cygwin port of dbus, but reading that file makes it obvious that it is not from upstream) - where changing /bin/sh will cause breakage that we can't rely on Debian to have caught first. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --es4AGicmA11X8W1ilRoaofenKkSp9hElJ-- --exjhqVQ4vwsoV1e7AHGvR2OoveAK2bLX1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 604 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYuGhfAAoJEKeha0olJ0Nq3IQH/3R0td4kQGqTXShSR5kNQWIh K+jfmls9+ARgauHApuRG2batMUST5/7okbgAz/IO2EkvusHgE9Ouq6UBioV5XFLK NVKWQXFZkrtLMDBrHa7b7zirYvOtzJSsopI2pJV9iURpDTjHvxSAMC0InMNcrFrq 57kt8FVkb1CAdhAmqXwEcFLxxWRTQyQ1I1PAY055dA8a+9xfvrJ89rQ+dbfXOp1o t+uqbIzw2ic3GjbWauVUlpTe0mGiWc0DbdaZoiGEBXFspw54OeAwLTKNBhW4/A8C jI2YCqk8FOj8pCBSDgV7gBdt1voFNFc5MnvqmPsHMluiXn2K6dOa+KObcwFqUvo= =B2GF -----END PGP SIGNATURE----- --exjhqVQ4vwsoV1e7AHGvR2OoveAK2bLX1--