From: Andrey Repin <anrdaemon@yandex.ru>
To: Sorin Adrian Savu <sorin@itguy.ro>, cygwin@cygwin.com
Subject: Re: openssl-devel in openssh README
Date: Sun, 26 May 2019 17:50:00 -0000 [thread overview]
Message-ID: <1812401761.20190526204725@yandex.ru> (raw)
In-Reply-To: <CAFeE7Gkavqhw+WWL_17B5fSWADBD9VKxW0tw0XY+9Nb+6OxBQA@mail.gmail.com>
Greetings, Sorin Adrian Savu!
>> Greetings, Sorin Adrian Savu!
>>
>> > Hello!
>>
>> > I had to compile openssh recently, and the README for cygwin is
>> referencing
>> > openssl-devel package which is obsolete now. I spent some time trying to
>> > figure this out. Can you please update
>> >
>> https://github.com/openssh/openssh-portable/blob/85ceb0e64bff672558fc87958cd548f135c83cdd/contrib/cygwin/README#L80
>> > to
>> > mention libssl-devel instead ?
>>
>> > (I would do it, but I can't figure out how to submit a PR to that repo)
>>
>> Clone the repo on github to your account, create branch, make changes,
>> submit
>> a PR.
> As a generic approach, that would do, however openssh-portable has quite a
> few branches and being a security related package I was expecting some
> strict guidelines on how to submit patches (which I can't find).
If there's any guidelines, a bot would mail you once you submit a PR, like it
is so for Symfony subpackages. (When you file a PR against them, a bot comes
in, closes it and tells you to fu... erm, file it against main Symfony repo.)
> Anyhow, I see that all the patches start from master, so I will give it a
> try.
Why I suggest a branch is because somebody could more easily inspect it
locally, when there's doubts.
Checking out from remote's master is a little bit more convoluted and
error-prone, than from a branch.
--
With best regards,
Andrey Repin
Sunday, May 26, 2019 20:43:59
Sorry for my terrible english...
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
next prev parent reply other threads:[~2019-05-26 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 6:19 Sorin Adrian Savu
2019-05-26 7:50 ` Andrey Repin
2019-05-26 17:37 ` Sorin Adrian Savu
2019-05-26 17:50 ` Andrey Repin [this message]
2019-05-26 13:36 ` Brian Inglis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1812401761.20190526204725@yandex.ru \
--to=anrdaemon@yandex.ru \
--cc=cygwin@cygwin.com \
--cc=sorin@itguy.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).