From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66115 invoked by alias); 11 Jan 2019 01:07:50 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 65733 invoked by uid 89); 11 Jan 2019 01:07:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=iswcntrl, Haible, haible, EOF X-HELO: mout.kundenserver.de Received: from mout.kundenserver.de (HELO mout.kundenserver.de) (212.227.17.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Jan 2019 01:07:48 +0000 Received: from [192.168.178.45] ([95.91.209.148]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MaIGB-1gkhHw3H5J-00WCOC for ; Fri, 11 Jan 2019 02:07:45 +0100 Subject: Re: iswcntrl() regression To: cygwin@cygwin.com References: <24530320.43gEWRNkUz@omega> <20181219133711.GJ28727@calimero.vinschen.de> <6550638.IhVCuUnqCC@omega> <20190106202109.GD4430@calimero.vinschen.de> <8758e963-7f32-a3f4-4d66-ce0d0c5f831e@towo.net> From: Thomas Wolff Message-ID: <18c44153-0e69-80f9-81c7-544009f83b8c@towo.net> Date: Fri, 11 Jan 2019 01:07:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <8758e963-7f32-a3f4-4d66-ce0d0c5f831e@towo.net> Content-Type: multipart/mixed; boundary="------------614599C208658FE7244A5A26" X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00066.txt.bz2 --------------614599C208658FE7244A5A26 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-length: 2759 Am 06.01.2019 um 23:39 schrieb Thomas Wolff: > Am 06.01.2019 um 21:21 schrieb Corinna Vinschen: >> On Dec 19 21:57, Bruno Haible wrote: >>> Hello Thomas, >>> >>> Oops 1: I forgot to add the reference to POSIX: >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswcntrl.html >>> >>> Oops 2: >>> The relevant expression is iswcntrl (WEOF), not iswcntrl (EOF). >>> >>>>> Are there any other special requirements concerning EOF? >>> WEOF is a special value. The difference between wint_t and wchar_t is >>> essentially that WEOF fits into wint_t but is not guaranteed to fit >>> in wchar_t. >>> (Like EOF fits into 'int' but usually does not fit in 'unsigned char'.) >>> >>> WEOF is special for all functions declared in , see >>> >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswalnum.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswalpha.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswblank.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswcntrl.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswdigit.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswgraph.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswlower.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswprint.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswpunct.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswspace.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswupper.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswxdigit.html >>> >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswctype.html >>> >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/towlower.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/towupper.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/towctrans.html >>> >>> >>>> this could be fixed in iswcntrl_l.c as a special condition, or >>>> injected as a special case in the categories.t table. >>> Probably, yes. >> Thomas, any input?  Are you going to provide patches? > Well, yes, now I'm assuming that this is the only WEOF special case > and I'll look after it this week. > Thomas The fix should be as attached. However, I don't seem to be able to produce a git format patch; when I `git format-patch -1` (after `git pull` and modifying only the affected file) it produces a patch file Subject: [PATCH] Cygwin: try_to_bin: don't check recycler filename all the time ... Signed-off-by: Corinna Vinschen ---  winsup/cygwin/syscalls.cc | 71 +++++++++++++++++++++------------------ ... which is weird. Thomas --------------614599C208658FE7244A5A26 Content-Type: text/plain; charset=UTF-8; name="0001-iswcntrl-WEOF.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-iswcntrl-WEOF.patch" Content-length: 517 LS0tIG5ld2xpYi9saWJjL2N0eXBlL2NhdGVnb3JpZXMuY34JMjAxOC0wOC0x OCAwOTo1MDoxNi4zOTc5OTcxMDAgKzAyMDAKKysrIG5ld2xpYi9saWJjL2N0 eXBlL2NhdGVnb3JpZXMuYwkyMDE5LTAxLTExIDAxOjU2OjM5LjE1NTczNjcw MCArMDEwMApAQCAtMTksNyArMTksNyBAQCBiaXNlYXJjaF9jYXQod2ludF90 IHVjcywgY29uc3Qgc3RydWN0IF9jCiAgIGludCBtaWQ7CiAKICAgaWYgKHVj cyA8IHRhYmxlWzBdLmZpcnN0IHx8IHVjcyA+IHRhYmxlW21heF0uZmlyc3Qg KyB0YWJsZVttYXhdLmRlbHRhKQotICAgIHJldHVybiAwOworICAgIHJldHVy biAtMTsKICAgd2hpbGUgKG1heCA+PSBtaW4pCiAgICAgewogICAgICAgbWlk ID0gKG1pbiArIG1heCkgLyAyOwo= --------------614599C208658FE7244A5A26 Content-Type: text/plain; charset=us-ascii Content-length: 219 -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple --------------614599C208658FE7244A5A26--