1.3.11(CVS): Possible bug involving temp file generation

1.3.11(CVS): Possible bug involving temp file generation

[Nicholas Wourms]

[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]

Hi,

System: CYGWIN_ME-4.90 DRAGON 1.3.11(0.53/3/2) 2002-06-04 09:27 i686

I just downloaded and compiled the latest CVS sources, and have installed
them.  I'm not sure where this might be occuring, but this is the behavior
I am experiencing that was not happening with CVS sources compiled 2 days
ago.  Here's the error I am getting:

patch: **** can't create `/cygdrive/c/WINDOWS/TEMP/po319437' : Bad file
number

Note:  I have the following set in autoexec.bat for use by other programs,
and I haven't had trouble in the past, so I don't think using that area
for temp files is the problem.

SET TEMP=C:\WINDOWS\TEMP
SET TMP=C:\WINDOWS\TEMP

These directories do exist, and have r/w permissions on them.  I have
plenty of space on the hard drive.

To reproduce the error, download the cygutils-1.0.0-1-src.tar.bz2 file,
untar it.  Make sure you have set the above environmental variables (if
they matter?).  Then run ./cygutils-1.0.0-1.sh prep.  That should
reproduce the error, at least it did on my WinME system.  I then ran:

strace patch -p0 < cygutils-1.0.0-1.patch | cat > strace.log

I then tar'ed it up to /stacktrace.tar and ran:

bzip2 -9 strace.results.tar

producing the this error plus a 0-byte file:

bzip2: Can't create output file strace.results.tar.bz2: Bad file number.

(I had to upload it to a linux box for compression.)

I have attached the stackdump, log, and cygcheck output for your
reference.  If you need anymore information, let me know.



Cheers,
Nicholas


__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com

[-- Attachment #2: strace.results.tar.bz2 --]
[-- Type: application/octet-stream, Size: 8519 bytes --]

[-- Attachment #3: Type: text/plain, Size: 214 bytes --]

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: 1.3.11(CVS): Possible bug involving temp file generation

[Nicholas Wourms]

> strace patch -p0 < cygutils-1.0.0-1.patch | cat > strace.log
> 
> I then tar'ed it up to /stacktrace.tar and ran:

Ooops..that should read:

"I then tar'ed it up to /strace.results.tar and ran:"

Sorry for the confusion...

Cheers,
Nicholas

__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: 1.3.11(CVS): Possible bug involving temp file generation

[Pavel Tsekov]

NW> patch: **** can't create `/cygdrive/c/WINDOWS/TEMP/po319437' : Bad file
NW> number

Try the latest snapshot dll and see if it works now.


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: 1.3.11(CVS): Possible bug involving temp file generation

[Nicholas Wourms]

Pavel,

It worked like a charm :).  What was the problem and how did you solve it,
if I might ask?

Cheers,
Nicholas
--- Pavel Tsekov <ptsekov@syntrex.com> wrote:
> NW> patch: **** can't create `/cygdrive/c/WINDOWS/TEMP/po319437' : Bad
> file
> NW> number
> 
> Try the latest snapshot dll and see if it works now.
> 
> 
> --
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
> Bug reporting:         http://cygwin.com/bugs.html
> Documentation:         http://cygwin.com/docs.html
> FAQ:                   http://cygwin.com/faq/
> 


__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: 1.3.11(CVS): Possible bug involving temp file generation

[Nicholas Wourms]

Pavel,

It worked like a charm :).  What was the problem and how did you solve it,
if I might ask?

Cheers,
Nicholas
--- Pavel Tsekov <ptsekov@syntrex.com> wrote:
> NW> patch: **** can't create `/cygdrive/c/WINDOWS/TEMP/po319437' : Bad
> file
> NW> number
> 
> Try the latest snapshot dll and see if it works now.
> 
> 
> --
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
> Bug reporting:         http://cygwin.com/bugs.html
> Documentation:         http://cygwin.com/docs.html
> FAQ:                   http://cygwin.com/faq/
> 


__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re[2]: 1.3.11(CVS): Possible bug involving temp file generation

[Pavel Tsekov]

Check this thread: http://cygwin.com/ml/cygwin/2002-06/msg00158.html

I've looked at the strace log you've attached and I saw that the code
reached a point which it wasn't supposed to reach under Win9x/ME.

This is the line from the strace.log - normally this won't be printed
on Win9x:
 2142   57784 [main] PATCH 601141 handle_to_fn: nt name ''

NW> It worked like a charm :).  What was the problem and how did you solve it,
NW> if I might ask?


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: 1.3.11(CVS): Possible bug involving temp file generation

[Christopher Faylor]

On Wed, Jun 05, 2002 at 03:43:58PM +0200, Pavel Tsekov wrote:
>Check this thread: http://cygwin.com/ml/cygwin/2002-06/msg00158.html
>
>I've looked at the strace log you've attached and I saw that the code
>reached a point which it wasn't supposed to reach under Win9x/ME.
>
>This is the line from the strace.log - normally this won't be printed
>on Win9x:
> 2142   57784 [main] PATCH 601141 handle_to_fn: nt name ''
>
>NW> It worked like a charm :).  What was the problem and how did you solve it,
>NW> if I might ask?

Actually, it is not supposed to make it that far anywhere unless the file
is opened from the command line in stdout.  I don't know how it could affect
temp file generation.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re[2]: 1.3.11(CVS): Possible bug involving temp file generation

[Pavel Tsekov]

>>Check this thread: http://cygwin.com/ml/cygwin/2002-06/msg00158.html
>>
>>I've looked at the strace log you've attached and I saw that the code
>>reached a point which it wasn't supposed to reach under Win9x/ME.
>>
>>This is the line from the strace.log - normally this won't be printed
>>on Win9x:
>> 2142   57784 [main] PATCH 601141 handle_to_fn: nt name ''
>>
>>NW> It worked like a charm :).  What was the problem and how did you solve it,
>>NW> if I might ask?

CF> Actually, it is not supposed to make it that far anywhere unless the file
CF> is opened from the command line in stdout.  I don't know how it could affect
CF> temp file generation.

I have a question - what is the return value of NtQueryObject () if
the ntdll.dll is not found i.e. you're executing on Win9x ? Is it 0 or
-1 ? It seems from the strace.log the it is 0 but I want to be sure.

If it is 0 there is a problem - see below:

  // This buffer is uninitialized, so it make contain random garbage
  // (or maybe not ?).
  // From the strace output we know that its first char is zero though
  // obviously we're lucky :).
  char win32_fn[MAX_PATH + 100];

  // sys_wcstombs is a macro which expands to:
  // #define sys_wcstombs(tgt,src,len) \
  //          WideCharToMultiByte((current_codepage==ansi_cp?CP_ACP:CP_OEMCP),0,(src),-1,(tgt),(len),NULL,NULL)
  //
  // In the case of WinME ntfn->Name.Length would be 0 (zero).
  // From the MSDN documentation on WideCharToMultiByte
  //   lpMultiByteStr
  //     [out] Points to the buffer to receive the translated string.
  //   cbMultiByte
  //     [in] Specifies the size, in bytes, of the buffer pointed to by
  //     the lpMultiByteStr parameter. If this value is zero, the function returns
  //     the number of bytes required for the buffer. (In this case, the lpMultiByteStr
  //     buffer is not used.)
  sys_wcstombs (win32_fn, ntfn->Name.Buffer, ntfn->Name.Length);
  debug_printf ("nt name '%s'", win32_fn);
  
  // We leave here with posix_fn an emptry string.
  if (!strncasematch (win32_fn, DEVICE_PREFIX, DEVICE_PREFIX_LEN)
      || !QueryDosDevice (NULL, fnbuf, sizeof (fnbuf)))
    return strcpy (posix_fn, win32_fn);


Later in dtable::init_std_file_from_handle we have this:

 path_conv pc;
 // The pointer which should be returned from build_fhandler_from_name
 // ()will be NULL if name is empty string, which will cause a segfault.
 build_fhandler_from_name (fd, name, handle, pc)->init (handle, myaccess,
                            pc.binmode ());

I have actually tested this on my machine by setting, from inside the
debugger, OBJECT_NAME_INFORMATION->Name.Length to 0 after the call to
NtObjectQuery (). This was necessary because I don't have access to
any Win9x machines.

Hope this helps and sounds plausible. Btw this can explain the problem
with 'patch' causing STATUS_ACCESS_VIOLATION (if you have checked the
log). It doesn't explain this though:

> NW> patch: **** can't create `/cygdrive/c/WINDOWS/TEMP/po319437' : Bad
> file

I have never looked at this issue - so if it was there and it was
fixed I dont't why. I was speaking only on the STATUS_ACCESS_VIOLATION
issue.


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: 1.3.11(CVS): Possible bug involving temp file generation

[Corinna Vinschen]

On Thu, Jun 06, 2002 at 04:22:10PM +0200, Pavel Tsekov wrote:
> I have a question - what is the return value of NtQueryObject () if
> the ntdll.dll is not found i.e. you're executing on Win9x ? Is it 0 or
> -1 ? It seems from the strace.log the it is 0 but I want to be sure.
> 
> If it is 0 there is a problem - see below:

It's not 0.  See autoload.cc.

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re[2]: 1.3.11(CVS): Possible bug involving temp file generation

[Pavel Tsekov]

>> I have a question - what is the return value of NtQueryObject () if
>> the ntdll.dll is not found i.e. you're executing on Win9x ? Is it 0 or
>> -1 ? It seems from the strace.log the it is 0 but I want to be sure.
>> 
>> If it is 0 there is a problem - see below:

CV> It's not 0.  See autoload.cc.

I did, but got some hard time groking it :(

But how do you explain this then (taken from the strace.log attached
by Nicholas Wourms) ?

**********************************************
Program name: C:\CYGNUS\CYGWIN\BIN\PATCH.EXE (601141)
App version:  1003.9, api: 0.51
DLL version:  1003.11, api: 0.53
DLL build:    2002-06-04 09:27
OS version:   Windows ME-4.90
Date/Time:    2002-06-04 10:31:36
**********************************************

 2142   57784 [main] PATCH 601141 handle_to_fn: nt name ''

 From what you say and what I can see in the code it look like this
 shouldn't be hapenning.


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: 1.3.11(CVS): Possible bug involving temp file generation

[Corinna Vinschen]

On Thu, Jun 06, 2002 at 05:11:00PM +0200, Pavel Tsekov wrote:
> CV> It's not 0.  See autoload.cc.
> 
> I did, but got some hard time groking it :(
> 
> But how do you explain this then (taken from the strace.log attached
> by Nicholas Wourms) ?
> 
> **********************************************
> Program name: C:\CYGNUS\CYGWIN\BIN\PATCH.EXE (601141)
> App version:  1003.9, api: 0.51
> DLL version:  1003.11, api: 0.53
> DLL build:    2002-06-04 09:27
> OS version:   Windows ME-4.90
> Date/Time:    2002-06-04 10:31:36
> **********************************************
> 
>  2142   57784 [main] PATCH 601141 handle_to_fn: nt name ''
> 
>  From what you say and what I can see in the code it look like this
>  shouldn't be hapenning.

He used the version of 2002-06-04 while Chris patched
handle_to_fn() on 2002-06-05 ;-)

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: 1.3.11(CVS): Possible bug involving temp file generation

[Nicholas Wourms]

Possibly that could explain it, though I did forget to mention another
variable in the situation.

With that build, I had patched the symbols and the newlib ?key? (I forgot
the exact name) to allow cygserver to operate and provide shared memory. 
When it seemed to be broken for Windows ME (and I determined that Robert's
lack of interest in my bug reports meant he wasn't wanting to work on it
atm), I decided to revert to using cygipc.  So I did not add the symbol
and key patches to the new build from cvs.  Just thought I'd mention this
fact as well...

Cheers,
Nicholas

P.S. - Robert, I know you do a ton of work and are busy, so please realize
that no offense or critism was intended by my remark :-).

--- Corinna Vinschen <corinna-cygwin@cygwin.com> wrote:
> On Thu, Jun 06, 2002 at 05:11:00PM +0200, Pavel Tsekov wrote:
> > CV> It's not 0.  See autoload.cc.
> > 
> > I did, but got some hard time groking it :(
> > 
> > But how do you explain this then (taken from the strace.log attached
> > by Nicholas Wourms) ?
> > 
> > **********************************************
> > Program name: C:\CYGNUS\CYGWIN\BIN\PATCH.EXE (601141)
> > App version:  1003.9, api: 0.51
> > DLL version:  1003.11, api: 0.53
> > DLL build:    2002-06-04 09:27
> > OS version:   Windows ME-4.90
> > Date/Time:    2002-06-04 10:31:36
> > **********************************************
> > 
> >  2142   57784 [main] PATCH 601141 handle_to_fn: nt name ''
> > 
> >  From what you say and what I can see in the code it look like this
> >  shouldn't be hapenning.
> 
> He used the version of 2002-06-04 while Chris patched
> handle_to_fn() on 2002-06-05 ;-)
> 
> Corinna
> 
> -- 
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Developer                                mailto:cygwin@cygwin.com
> Red Hat, Inc.
> 
> --
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
> Bug reporting:         http://cygwin.com/bugs.html
> Documentation:         http://cygwin.com/docs.html
> FAQ:                   http://cygwin.com/faq/
> 


__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re[2]: 1.3.11(CVS): Possible bug involving temp file generation

[Pavel Tsekov]

Hello Corinna,

Thursday, June 06, 2002, 5:28:42 PM, you wrote:

CV> On Thu, Jun 06, 2002 at 05:11:00PM +0200, Pavel Tsekov wrote:
>> CV> It's not 0.  See autoload.cc.
>> 
>> I did, but got some hard time groking it :(
>> 
>> But how do you explain this then (taken from the strace.log attached
>> by Nicholas Wourms) ?
>> 
>> **********************************************
>> Program name: C:\CYGNUS\CYGWIN\BIN\PATCH.EXE (601141)
>> App version:  1003.9, api: 0.51
>> DLL version:  1003.11, api: 0.53
>> DLL build:    2002-06-04 09:27
>> OS version:   Windows ME-4.90
>> Date/Time:    2002-06-04 10:31:36
>> **********************************************
>> 
>>  2142   57784 [main] PATCH 601141 handle_to_fn: nt name ''
>> 
>>  From what you say and what I can see in the code it look like this
>>  shouldn't be hapenning.

CV> He used the version of 2002-06-04 while Chris patched
CV> handle_to_fn() on 2002-06-05 ;-)

Corinna, do you mean the changes in version 1.92 of dtable.cc ? I dont't see how
this patch helps to solve the problem I'm describing ?


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re[2]: 1.3.11(CVS): Possible bug involving temp file generation

[Pavel Tsekov]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

>> I have a question - what is the return value of NtQueryObject () if
>> the ntdll.dll is not found i.e. you're executing on Win9x ? Is it 0 or
>> -1 ? It seems from the strace.log the it is 0 but I want to be sure.
>> 
>> If it is 0 there is a problem - see below:

CV> It's not 0.  See autoload.cc.

I've just tested this by the following change in autoload.cc:

LoadDLLfuncEx2 (NtQueryObject, 20, ntdlltest, 1, 1)

There is no ntdlltest.dll on my machine though the call to
NtQueryObject () returns 0.

I'am attaching the output of the 'strings' utility I've run on the
newly built cygwin1.dll.

I hope this helps.

[-- Attachment #2: strings.cygwin1.dll.bz2 --]
[-- Type: application/octet-stream, Size: 32556 bytes --]

[-- Attachment #3: Type: text/plain, Size: 214 bytes --]

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: 1.3.11(CVS): Possible bug involving temp file generation

[Christopher Faylor]

On Thu, Jun 06, 2002 at 06:22:37PM +0200, Pavel Tsekov wrote:
>>> I have a question - what is the return value of NtQueryObject () if
>>> the ntdll.dll is not found i.e. you're executing on Win9x ? Is it 0 or
>>> -1 ? It seems from the strace.log the it is 0 but I want to be sure.
>>> 
>>> If it is 0 there is a problem - see below:
>
>CV> It's not 0.  See autoload.cc.
>
>I've just tested this by the following change in autoload.cc:
>
>LoadDLLfuncEx2 (NtQueryObject, 20, ntdlltest, 1, 1)
>
>There is no ntdlltest.dll on my machine though the call to
>NtQueryObject () returns 0.

Yep.  It's a bug.  I just fixed it in CVS.

Thanks.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: 1.3.11(CVS): Possible bug involving temp file generation

[Christopher Faylor]

On Thu, Jun 06, 2002 at 07:47:35PM -0400, Christopher Faylor wrote:
>On Thu, Jun 06, 2002 at 06:22:37PM +0200, Pavel Tsekov wrote:
>>>> I have a question - what is the return value of NtQueryObject () if
>>>> the ntdll.dll is not found i.e. you're executing on Win9x ? Is it 0 or
>>>> -1 ? It seems from the strace.log the it is 0 but I want to be sure.
>>>> 
>>>> If it is 0 there is a problem - see below:
>>
>>CV> It's not 0.  See autoload.cc.
>>
>>I've just tested this by the following change in autoload.cc:
>>
>>LoadDLLfuncEx2 (NtQueryObject, 20, ntdlltest, 1, 1)
>>
>>There is no ntdlltest.dll on my machine though the call to
>>NtQueryObject () returns 0.
>
>Yep.  It's a bug.  I just fixed it in CVS.
>
>Thanks.

I should reiterate that this code is *only* called when a cygwin process
is invoked from a non-cygwin process with stdin/stdout/stderr redirected
to a disk file.

It has nothing to do with temp file creation or normal file creation.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re[2]: 1.3.11(CVS): Possible bug involving temp file generation

[Pavel Tsekov]

Hello Christopher,

Friday, June 07, 2002, 1:49:17 AM, you wrote:

CF> I should reiterate that this code is *only* called when a cygwin process
CF> is invoked from a non-cygwin process with stdin/stdout/stderr redirected
CF> to a disk file.

CF> It has nothing to do with temp file creation or normal file creation.

I am aware of this fact - explaining me once is sufficient (in most
cases) :)

The original post introduced some confusion. While explaining how
to reproduce the problem with the temp file, another bug was
introduced - the STATUS_ACCESS_VIOLATION in patch (from the
strace.log). I was trying to catch this one.

Check http://cygwin.com/ml/cygwin/2002-06/msg00278.html - at the
bottom lines.

And clearly this post of mine,
http://cygwin.com/ml/cygwin/2002-06/msg00210.html, is *WRONG*. I assume
your changes in v 1.92 of dtable.cc fixed the 'Bad file
number' problem.

It's cool that now both of the problems are fixed! :)


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/