public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
* Bash 3.02 (w/small patch)
@ 1999-03-15  6:54 Glenn Spell
       [not found] ` < 199903151453.GAA02478@shell4.ba.best.com >
  1999-03-31 19:45 ` Glenn Spell
  0 siblings, 2 replies; 6+ messages in thread
From: Glenn Spell @ 1999-03-15  6:54 UTC (permalink / raw)
  To: Cygwin List

A new version of Bash (3.02) was released about a month ago.
The package is available at < ftp://ftp.gnu.org/gnu/bash/ >.

It seems to be faster than earlier releases even without
Trevor's spawn modifications.

With the following patch it compiles and runs fine on Cygwin.

--------------------------------------------------------------
diff -u3 -rN bash-2.03-orig/Makefile.in bash-2.03/Makefile.in
--- bash-2.03-orig/Makefile.in	Thu Feb 18 12:07:38 1999
+++ bash-2.03/Makefile.in	Sun Mar 14 05:42:46 1999
@@ -58,7 +58,7 @@
 	$(CC) $(CCFLAGS) -c $<
 
 # The name of this program and some version information.
-Program = bash
+Program = bash.exe
 Version = @BASHVERS@
 PatchLevel = @BASHPATCH@
 RELSTATUS = release
diff -u3 -rN bash-2.03-orig/config-top.h bash-2.03/config-top.h
--- bash-2.03-orig/config-top.h	Tue Dec 15 13:24:38 1998
+++ bash-2.03/config-top.h	Sun Mar 14 05:06:36 1999
@@ -45,7 +45,9 @@
 #endif
 
 /* Default primary and secondary prompt strings. */
-#define PPROMPT "\\s-\\v\\$ "
+#if defined (PROMPT_STRING_DECODE)
+#  define PPROMPT "\\s-\\v\\$ "
+#endif
 #define SPROMPT "> "
 
 /* System-wide .bashrc file for interactive shells. */
diff -u3 -rN bash-2.03-orig/execute_cmd.c bash-2.03/execute_cmd.c
--- bash-2.03-orig/execute_cmd.c	Tue Jan 26 16:23:50 1999
+++ bash-2.03/execute_cmd.c	Mon Mar 15 06:17:46 1999
@@ -2787,8 +2787,10 @@
   /* A subshell is neither a login shell nor interactive. */
   login_shell = interactive = 0;
 
+#if defined (JOB_CONTROL)
   jobs_hack = (builtin == jobs_builtin) &&
 		((subshell_environment & SUBSHELL_ASYNC) == 0 || pipe_out != NO_PIPE);
+#endif
 
   subshell_environment = SUBSHELL_ASYNC;
 
diff -u3 -rN bash-2.03-orig/variables.c bash-2.03/variables.c
--- bash-2.03-orig/variables.c	Tue Nov 10 13:29:46 1998
+++ bash-2.03/variables.c	Sun Mar 14 22:44:18 1999
@@ -282,7 +282,7 @@
   /* set up the prompts. */
   if (interactive_shell)
     {
-#if defined (PROMPT_STRING_DECODE)
+#if defined (PROMPT_STRING_DECODE) || defined (__CYGWIN32__)
       set_if_not ("PS1", primary_prompt);
 #else
       if (current_user.uid == -1)
--------------------------------------------------------------

-glenn

-- 
            Glenn Spell <glenn@gs.fay.nc.us>
         Fayetteville, North Carolina, U. S. A.
  ____________________________________________________
  ... blue skies ... happy trails ... sweet dreams ...

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bash 3.02 (w/small patch)
       [not found] ` < 199903151453.GAA02478@shell4.ba.best.com >
@ 1999-03-15  8:08   ` Chet Ramey
       [not found]     ` < 990315160647.AA14489.SM@nike.ins.cwru.edu >
  1999-03-31 19:45     ` Chet Ramey
  0 siblings, 2 replies; 6+ messages in thread
From: Chet Ramey @ 1999-03-15  8:08 UTC (permalink / raw)
  To: glenn; +Cc: cygwin, chet

>  /* Default primary and secondary prompt strings. */
> -#define PPROMPT "\\s-\\v\\$ "
> +#if defined (PROMPT_STRING_DECODE)
> +#  define PPROMPT "\\s-\\v\\$ "
> +#endif
>  #define SPROMPT "> "

This is unnecessary.  Look at config-bot.h.  If PROMPT_STRING_DECODE
is not defined, PPROMPT is redefined to "$ ".

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
( ``Discere est Dolere'' -- chet)

Chet Ramey, Case Western Reserve University	Internet: chet@po.CWRU.Edu

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bash 3.02 (w/small patch)
       [not found]     ` < 990315160647.AA14489.SM@nike.ins.cwru.edu >
@ 1999-03-16 10:32       ` Glenn Spell
  1999-03-31 19:45         ` Glenn Spell
  0 siblings, 1 reply; 6+ messages in thread
From: Glenn Spell @ 1999-03-16 10:32 UTC (permalink / raw)
  To: chet; +Cc: cygwin

Chet Ramey wrote:
> >  /* Default primary and secondary prompt strings. */
> > -#define PPROMPT "\\s-\\v\\$ "
> > +#if defined (PROMPT_STRING_DECODE)
> > +#  define PPROMPT "\\s-\\v\\$ "
> > +#endif
> 
> This is unnecessary.  Look at config-bot.h.  If PROMPT_STRING_DECODE
> is not defined, PPROMPT is redefined to "$ ".

You're right, of course. However, the purpose of that change is to
eliminate the redefining. Is there any reason not to do so?

Egcs issues warnings on redefinitions. Since this one is in
config.h there are just too many warnings... it's distracting.

On the other hand, thanks for the nice package.

-glenn

-- 
            Glenn Spell <glenn@gs.fay.nc.us>
         Fayetteville, North Carolina, U. S. A.
  ____________________________________________________
  ... blue skies ... happy trails ... sweet dreams ...

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bash 3.02 (w/small patch)
  1999-03-16 10:32       ` Glenn Spell
@ 1999-03-31 19:45         ` Glenn Spell
  0 siblings, 0 replies; 6+ messages in thread
From: Glenn Spell @ 1999-03-31 19:45 UTC (permalink / raw)
  To: chet; +Cc: cygwin

Chet Ramey wrote:
> >  /* Default primary and secondary prompt strings. */
> > -#define PPROMPT "\\s-\\v\\$ "
> > +#if defined (PROMPT_STRING_DECODE)
> > +#  define PPROMPT "\\s-\\v\\$ "
> > +#endif
> 
> This is unnecessary.  Look at config-bot.h.  If PROMPT_STRING_DECODE
> is not defined, PPROMPT is redefined to "$ ".

You're right, of course. However, the purpose of that change is to
eliminate the redefining. Is there any reason not to do so?

Egcs issues warnings on redefinitions. Since this one is in
config.h there are just too many warnings... it's distracting.

On the other hand, thanks for the nice package.

-glenn

-- 
            Glenn Spell <glenn@gs.fay.nc.us>
         Fayetteville, North Carolina, U. S. A.
  ____________________________________________________
  ... blue skies ... happy trails ... sweet dreams ...

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bash 3.02 (w/small patch)
  1999-03-15  8:08   ` Chet Ramey
       [not found]     ` < 990315160647.AA14489.SM@nike.ins.cwru.edu >
@ 1999-03-31 19:45     ` Chet Ramey
  1 sibling, 0 replies; 6+ messages in thread
From: Chet Ramey @ 1999-03-31 19:45 UTC (permalink / raw)
  To: glenn; +Cc: cygwin, chet

>  /* Default primary and secondary prompt strings. */
> -#define PPROMPT "\\s-\\v\\$ "
> +#if defined (PROMPT_STRING_DECODE)
> +#  define PPROMPT "\\s-\\v\\$ "
> +#endif
>  #define SPROMPT "> "

This is unnecessary.  Look at config-bot.h.  If PROMPT_STRING_DECODE
is not defined, PPROMPT is redefined to "$ ".

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
( ``Discere est Dolere'' -- chet)

Chet Ramey, Case Western Reserve University	Internet: chet@po.CWRU.Edu

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Bash 3.02 (w/small patch)
  1999-03-15  6:54 Bash 3.02 (w/small patch) Glenn Spell
       [not found] ` < 199903151453.GAA02478@shell4.ba.best.com >
@ 1999-03-31 19:45 ` Glenn Spell
  1 sibling, 0 replies; 6+ messages in thread
From: Glenn Spell @ 1999-03-31 19:45 UTC (permalink / raw)
  To: Cygwin List

A new version of Bash (3.02) was released about a month ago.
The package is available at < ftp://ftp.gnu.org/gnu/bash/ >.

It seems to be faster than earlier releases even without
Trevor's spawn modifications.

With the following patch it compiles and runs fine on Cygwin.

--------------------------------------------------------------
diff -u3 -rN bash-2.03-orig/Makefile.in bash-2.03/Makefile.in
--- bash-2.03-orig/Makefile.in	Thu Feb 18 12:07:38 1999
+++ bash-2.03/Makefile.in	Sun Mar 14 05:42:46 1999
@@ -58,7 +58,7 @@
 	$(CC) $(CCFLAGS) -c $<
 
 # The name of this program and some version information.
-Program = bash
+Program = bash.exe
 Version = @BASHVERS@
 PatchLevel = @BASHPATCH@
 RELSTATUS = release
diff -u3 -rN bash-2.03-orig/config-top.h bash-2.03/config-top.h
--- bash-2.03-orig/config-top.h	Tue Dec 15 13:24:38 1998
+++ bash-2.03/config-top.h	Sun Mar 14 05:06:36 1999
@@ -45,7 +45,9 @@
 #endif
 
 /* Default primary and secondary prompt strings. */
-#define PPROMPT "\\s-\\v\\$ "
+#if defined (PROMPT_STRING_DECODE)
+#  define PPROMPT "\\s-\\v\\$ "
+#endif
 #define SPROMPT "> "
 
 /* System-wide .bashrc file for interactive shells. */
diff -u3 -rN bash-2.03-orig/execute_cmd.c bash-2.03/execute_cmd.c
--- bash-2.03-orig/execute_cmd.c	Tue Jan 26 16:23:50 1999
+++ bash-2.03/execute_cmd.c	Mon Mar 15 06:17:46 1999
@@ -2787,8 +2787,10 @@
   /* A subshell is neither a login shell nor interactive. */
   login_shell = interactive = 0;
 
+#if defined (JOB_CONTROL)
   jobs_hack = (builtin == jobs_builtin) &&
 		((subshell_environment & SUBSHELL_ASYNC) == 0 || pipe_out != NO_PIPE);
+#endif
 
   subshell_environment = SUBSHELL_ASYNC;
 
diff -u3 -rN bash-2.03-orig/variables.c bash-2.03/variables.c
--- bash-2.03-orig/variables.c	Tue Nov 10 13:29:46 1998
+++ bash-2.03/variables.c	Sun Mar 14 22:44:18 1999
@@ -282,7 +282,7 @@
   /* set up the prompts. */
   if (interactive_shell)
     {
-#if defined (PROMPT_STRING_DECODE)
+#if defined (PROMPT_STRING_DECODE) || defined (__CYGWIN32__)
       set_if_not ("PS1", primary_prompt);
 #else
       if (current_user.uid == -1)
--------------------------------------------------------------

-glenn

-- 
            Glenn Spell <glenn@gs.fay.nc.us>
         Fayetteville, North Carolina, U. S. A.
  ____________________________________________________
  ... blue skies ... happy trails ... sweet dreams ...

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~1999-03-31 19:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-03-15  6:54 Bash 3.02 (w/small patch) Glenn Spell
     [not found] ` < 199903151453.GAA02478@shell4.ba.best.com >
1999-03-15  8:08   ` Chet Ramey
     [not found]     ` < 990315160647.AA14489.SM@nike.ins.cwru.edu >
1999-03-16 10:32       ` Glenn Spell
1999-03-31 19:45         ` Glenn Spell
1999-03-31 19:45     ` Chet Ramey
1999-03-31 19:45 ` Glenn Spell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).