From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glenn Spell To: chet@po.cwru.edu Cc: cygwin@sourceware.cygnus.com Subject: Re: Bash 3.02 (w/small patch) Date: Tue, 16 Mar 1999 10:32:00 -0000 Message-id: <199903161831.KAA20883@shell4.ba.best.com> In-reply-to: < 990315160647.AA14489.SM@nike.ins.cwru.edu > from Chet Ramey at "Mar 15, 99 11:06:47 am" References: <990315160647.AA14489.SM@nike.ins.cwru.edu> X-SW-Source: 1999-03/msg00510.html Chet Ramey wrote: > > /* Default primary and secondary prompt strings. */ > > -#define PPROMPT "\\s-\\v\\$ " > > +#if defined (PROMPT_STRING_DECODE) > > +# define PPROMPT "\\s-\\v\\$ " > > +#endif > > This is unnecessary. Look at config-bot.h. If PROMPT_STRING_DECODE > is not defined, PPROMPT is redefined to "$ ". You're right, of course. However, the purpose of that change is to eliminate the redefining. Is there any reason not to do so? Egcs issues warnings on redefinitions. Since this one is in config.h there are just too many warnings... it's distracting. On the other hand, thanks for the nice package. -glenn -- Glenn Spell Fayetteville, North Carolina, U. S. A. ____________________________________________________ ... blue skies ... happy trails ... sweet dreams ... -- Want to unsubscribe from this list? Send a message to cygwin-unsubscribe@sourceware.cygnus.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glenn Spell To: chet@po.cwru.edu Cc: cygwin@sourceware.cygnus.com Subject: Re: Bash 3.02 (w/small patch) Date: Wed, 31 Mar 1999 19:45:00 -0000 Message-ID: <199903161831.KAA20883@shell4.ba.best.com> References: <990315160647.AA14489.SM@nike.ins.cwru.edu> X-SW-Source: 1999-03n/msg00510.html Message-ID: <19990331194500.vWNW46nbbDUFHkKti0zSgMO7RI1vO1kz6zF0oydNPDc@z> Chet Ramey wrote: > > /* Default primary and secondary prompt strings. */ > > -#define PPROMPT "\\s-\\v\\$ " > > +#if defined (PROMPT_STRING_DECODE) > > +# define PPROMPT "\\s-\\v\\$ " > > +#endif > > This is unnecessary. Look at config-bot.h. If PROMPT_STRING_DECODE > is not defined, PPROMPT is redefined to "$ ". You're right, of course. However, the purpose of that change is to eliminate the redefining. Is there any reason not to do so? Egcs issues warnings on redefinitions. Since this one is in config.h there are just too many warnings... it's distracting. On the other hand, thanks for the nice package. -glenn -- Glenn Spell Fayetteville, North Carolina, U. S. A. ____________________________________________________ ... blue skies ... happy trails ... sweet dreams ... -- Want to unsubscribe from this list? Send a message to cygwin-unsubscribe@sourceware.cygnus.com