public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Horak Daniel <horak@mmp.plzen-city.cz>
To: "'pgsql-hackers@postgreSQL.org'" <pgsql-hackers@postgreSQL.org>
Cc: "'cygwin@sourceware.cygnus.com'" <cygwin@sourceware.cygnus.com>,
	"'Joost Kraaijeveld'" <JKraaijeveld@askesis.nl>
Subject: backend freezeing on win32 fixed (I hope ;-) )
Date: Tue, 31 Aug 1999 23:49:00 -0000	[thread overview]
Message-ID: <2E7F82FAC1FCD2118E1500A024B3BF907DED3B@exchange.mmp.plzen-city.cz> (raw)
Message-ID: <19990831234900.nX2492SQwKXBD6mWBY9l0kAKoX0dZdhVz_tGUPKqc8o@z> (raw)

Hi,

I think I have fixed the freezing of the postgres backend on Windows NT. Now
it survives 5 regression test in a cycle with some concurrent connections
during running the tests.

Where the problem was (manual backtrace):
- InitPostgres() (utils/init/postinit.c)
- InitProcess() (storage/lmgr/proc.c)
- IpcSemaphoreCreate() (storage/ipc/ipc.c)
- semget() (now in libcygipc - sem.c)
- sem_connect() (sem.c)
- WaitForSingleObject() (win32 system call)
- freezing....

It have looked like a problem with initializing the same semaphore for
second time (they are "preinitialized" for performance reasons in
InitProcGlobal() in storage/lmgr/proc.c)

The fix (made for v6.5.1) is here:
-------------------------------
--- src/backend/storage/lmgr/proc.c.old	Sat Aug 14 16:50:19 1999
+++ src/backend/storage/lmgr/proc.c	Sat Aug 14 16:50:52 1999
@@ -160,6 +160,7 @@
 		 * Pre-create the semaphores for the first maxBackends
processes,
 		 * unless we are running as a standalone backend.
 		 */
+#ifndef __CYGWIN__
 		if (key != PrivateIPCKey)
 		{
 			for (i = 0;
@@ -180,6 +181,7 @@
 				ProcGlobal->freeSemMap[i] = (1 <<
PROC_NSEMS_PER_SET);
 			}
 		}
+#endif /* __CYGWIN__ */
 	}
 }
------------------------------- 

				Dan

PS: I have packed the tree after "make install" for 6.5.1 with the patch
above, so it is a "binary distribution".

----------------------------------------------
Daniel Horak
network and system administrator
e-mail: horak@mmp.plzen-city.cz
privat e-mail: dan.horak@email.cz ICQ:36448176
----------------------------------------------

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com

             reply	other threads:[~1999-08-31 23:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-08-16  2:36 Horak Daniel [this message]
1999-08-16  7:08 ` [HACKERS] " Tom Lane
1999-08-16 10:08   ` Chris Faylor
1999-08-31 23:49     ` Chris Faylor
1999-08-31 23:49   ` Tom Lane
1999-08-31 23:49 ` Horak Daniel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2E7F82FAC1FCD2118E1500A024B3BF907DED3B@exchange.mmp.plzen-city.cz \
    --to=horak@mmp.plzen-city.cz \
    --cc=JKraaijeveld@askesis.nl \
    --cc=cygwin@sourceware.cygnus.com \
    --cc=pgsql-hackers@postgreSQL.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).