Re: make 3.79.1-4 'make: /bin/sh.exe: Command not found' when running without sh.exe

Re: make 3.79.1-4 'make: /bin/sh.exe: Command not found' when running without sh.exe

[Christopher Faylor]

Trying again, cc'ing the original sender.

cgf

On Thu, Nov 15, 2001 at 10:30:54PM -0500, Christopher Faylor wrote:
>On Thu, Nov 15, 2001 at 07:00:13PM -0800, Craig Hackney wrote:
>>
>>	There appears to be a problem with this version of make please
>>	see below.
>
>Thanks for the analysis.
>
>The patch below should fix this, right?
>
>cgf

2001-11-15  Christopher Faylor  <cgf@redhat.com>

	* main.c (main): Invert sense of test to ensure that unixy_shell is set
	to zero if MAKE_MODE is not set to UNIX.

Index: main.c
===================================================================
RCS file: /cvs/cvsfiles/devo/make/main.c,v
retrieving revision 1.47
diff -u -p -r1.47 main.c
--- main.c	2001/06/26 19:12:04	1.47
+++ main.c	2001/11/16 03:20:03
@@ -870,11 +870,10 @@ int main (int argc, char ** argv)
     char *make_mode_env;
 
     /* Read the environment variable MAKE_MODE */
-    /* If it's "UNIX", set unixy_shell to 1.  If it's "WIN32" or
-       anything else, stay with the default of 0. */
+    /* If it's not "UNIX", set unixy_shell to 0. */
     make_mode_env = getenv ("MAKE_MODE");
-    if (make_mode_env && strcaseequ (make_mode_env, "UNIX"))
-      unixy_shell = 1;
+    if (make_mode_env && !strcaseequ (make_mode_env, "UNIX"))
+      unixy_shell = 0;
   }
 #endif /* __CYGWIN__ */

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

make 3.79.1-4 'make: /bin/sh.exe: Command not found' when running without sh.exe

[Craig Hackney]

	There appears to be a problem with this version of make please
	see below.

	The ChangeLog.Cygnus file contains information on a change that
	causes an error if sh.exe is not in /bin when make is run.

---------
        * main.c (main): Avoid setting no_default_sh_exe to 0 in all cases.
        Default to /bin/sh.exe on Cygwin.  Lookup COMSPEC for --win32.
---------

	The default shell is set to a unix style shell, ie. /bin/sh,
	main.c contains code that checks the MAKE_MODE environment
	variable see below..

---------
    /* Read the environment variable MAKE_MODE */
    /* If it's "UNIX", set unixy_shell to 1.  If it's "WIN32" or
       anything else, stay with the default of 0. */
    make_mode_env = getenv ("MAKE_MODE");
    if (make_mode_env && strcaseequ (make_mode_env, "UNIX"))
      unixy_shell = 1;
---------

	The above code checks to see if the MAKE_MODE is 'unix' and, if
	it is sets unixy_shell (which is already set since the default
	shell is now /bin/sh). Any other setting, i.e. WIN32, will use
	the default, which is a unix shell. So make is looking for 
	/bin/sh even when MAKE_MODE is set to WIN32, the only workaround
	is to specify --win32 as a command line option to make.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Re: make 3.79.1-4 'make: /bin/sh.exe: Command not found' when running without sh.exe

[Christopher Faylor]

On Thu, Nov 15, 2001 at 07:00:13PM -0800, Craig Hackney wrote:
>
>	There appears to be a problem with this version of make please
>	see below.

Thanks for the analysis.

The patch below should fix this, right?

cgf

2001-11-15  Christopher Faylor  <cgf@redhat.com>

	* main.c (main): Invert sense of test to ensure that unixy_shell is set
	to zero if MAKE_MODE is not set to UNIX.

Index: main.c
===================================================================
RCS file: /cvs/cvsfiles/devo/make/main.c,v
retrieving revision 1.47
diff -u -p -r1.47 main.c
--- main.c	2001/06/26 19:12:04	1.47
+++ main.c	2001/11/16 03:20:03
@@ -870,11 +870,10 @@ int main (int argc, char ** argv)
     char *make_mode_env;
 
     /* Read the environment variable MAKE_MODE */
-    /* If it's "UNIX", set unixy_shell to 1.  If it's "WIN32" or
-       anything else, stay with the default of 0. */
+    /* If it's not "UNIX", set unixy_shell to 0. */
     make_mode_env = getenv ("MAKE_MODE");
-    if (make_mode_env && strcaseequ (make_mode_env, "UNIX"))
-      unixy_shell = 1;
+    if (make_mode_env && !strcaseequ (make_mode_env, "UNIX"))
+      unixy_shell = 0;
   }
 #endif /* __CYGWIN__ */

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/