From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: [1.7] rename/renameat error
Date: Wed, 23 Sep 2009 09:22:00 -0000 [thread overview]
Message-ID: <20090923092209.GX20981@calimero.vinschen.de> (raw)
In-Reply-To: <loom.20090922T225033-801@post.gmane.org>
On Sep 22 21:02, Eric Blake wrote:
> Eric Blake <ebb9 <at> byu.net> writes:
>
> > > > > Cygwin 1.7 is
> > > > > detecting this situation (which is a step up from 1.5 which did the
> rename
> > > > > anyways), but sets errno to EBUSY instead of EINVAL.
> > > >
> > > > Thanks for catching. Feel free to fix the rename function accordingly.
> > >
> > > OK, I'll look into it (I don't know how large the patch will be, yet).
> >
> > And link("a","f/.") should not create "f" as a regular file, either. I'm
> still
> > looking at where to patch things.
>
> I've got a patch in testing for both of these issues. But while looking at
> path.cc, I've noticed a couple of things:
>
> The code doesn't do a very good job of remembering lengths it has already
> seen. For example, with relative paths, the code in normalize_posix_path does
> cwd.get, then strchr; it seems like since cwd.get already knows how many bytes
> it copied, that a simple API modification would pass that information back to
> the caller so that the caller doesn't have to use strchr to find the end of the
> string. Anything we can do to avoid rescanning strings of known length will
> provide speedups in path handling.
This one might be worth a shot, if it's an easy patch.
> I'm also wondering whether it is time to finally emulate Linux by requiring
> that when doing pathname resolution of 'a/..', that 'a' actually exist (either
> as a directory or a symlink to directory), instead of silently ignoring that
> part of the string. Should I go ahead and spend time working up a patch for
> this?
This is something which I have on my TODO list for a long time, but I
never saw a simple way to implement this without losing a lot of the
already lousy performance of the path conversion. Additionally the path
conversion code is already quite complicated and I fear the unwanted
side effects such a change could have. Therefore, I tend to think of
this as a welcome post-1.7.1 change.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
next prev parent reply other threads:[~2009-09-23 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-07 15:48 Eric Blake
2009-09-07 19:21 ` Corinna Vinschen
2009-09-08 22:56 ` Eric Blake
2009-09-09 16:37 ` Eric Blake
2009-09-09 17:43 ` Christopher Faylor
2009-09-21 10:46 ` Corinna Vinschen
2009-09-22 21:02 ` Eric Blake
2009-09-23 9:22 ` Corinna Vinschen [this message]
2009-09-23 14:01 ` Christopher Faylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090923092209.GX20981@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).