From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17363 invoked by alias); 23 Sep 2009 09:22:24 -0000 Received: (qmail 17355 invoked by uid 22791); 23 Sep 2009 09:22:23 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Sep 2009 09:22:19 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 2DE016D5598; Wed, 23 Sep 2009 11:22:09 +0200 (CEST) Date: Wed, 23 Sep 2009 09:22:00 -0000 From: Corinna Vinschen To: cygwin@cygwin.com Subject: Re: [1.7] rename/renameat error Message-ID: <20090923092209.GX20981@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <4AA52B5E.8060509@byu.net> <20090907192046.GA12492@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-02-20) Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com X-SW-Source: 2009-09/txt/msg00576.txt.bz2 On Sep 22 21:02, Eric Blake wrote: > Eric Blake byu.net> writes: > > > > > > Cygwin 1.7 is > > > > > detecting this situation (which is a step up from 1.5 which did the > rename > > > > > anyways), but sets errno to EBUSY instead of EINVAL. > > > > > > > > Thanks for catching. Feel free to fix the rename function accordingly. > > > > > > OK, I'll look into it (I don't know how large the patch will be, yet). > > > > And link("a","f/.") should not create "f" as a regular file, either. I'm > still > > looking at where to patch things. > > I've got a patch in testing for both of these issues. But while looking at > path.cc, I've noticed a couple of things: > > The code doesn't do a very good job of remembering lengths it has already > seen. For example, with relative paths, the code in normalize_posix_path does > cwd.get, then strchr; it seems like since cwd.get already knows how many bytes > it copied, that a simple API modification would pass that information back to > the caller so that the caller doesn't have to use strchr to find the end of the > string. Anything we can do to avoid rescanning strings of known length will > provide speedups in path handling. This one might be worth a shot, if it's an easy patch. > I'm also wondering whether it is time to finally emulate Linux by requiring > that when doing pathname resolution of 'a/..', that 'a' actually exist (either > as a directory or a symlink to directory), instead of silently ignoring that > part of the string. Should I go ahead and spend time working up a patch for > this? This is something which I have on my TODO list for a long time, but I never saw a simple way to implement this without losing a lot of the already lousy performance of the path conversion. Additionally the path conversion code is already quite complicated and I fear the unwanted side effects such a change could have. Therefore, I tend to think of this as a welcome post-1.7.1 change. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple