public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf-use-the-mailinglist-please@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: Mercurial not returning with 20110601 snapshot
Date: Sat, 04 Jun 2011 01:14:00 -0000	[thread overview]
Message-ID: <20110604011359.GA30631@ednor.casa.cgf.cx> (raw)
In-Reply-To: <BANLkTim7+mG41OifRJnx0S4JxMWc+scMRA@mail.gmail.com>

On Thu, Jun 02, 2011 at 09:05:57AM -0400, Chris Sutcliffe wrote:
>On 2 June 2011 08:27, Christopher Faylor wrote:
>> On Thu, Jun 02, 2011 at 06:43:40AM -0400, Chris Sutcliffe wrote:
>>>Testing the 20110601 snapshot I've run in to an issue where Mercurial
>>>(specifically python) will not return to the command line when the
>>>command completes:
>>>
>>>I'm guessing this is related to the recent changes to pipe handling?
>>
>> Like other guesses about this: not necessarily.
>
>Fair enough, I should know better than to assume.

Or, maybe I should just listen to your guesses.  You were right.  I made
a change to the pipe code to speed up select and forgot to detect EOF
conditions.  It was a pretty glaring oversight on my part.  This follows
on the heels of my completely screwing up non-blocking reads on pipes so
my track record hasn't been great in this area.

The problem was easy to duplicate:

echo hello | ssh someplace cat

There were also several other problems with tty/console handling.  My
attempt to merge some of the console and pty handling has proved to be
pretty tricky to get right.  The console problems were tickled by strace
so they were harder than usual to track down.

Anyway, thanks for noticing the problem.  It should be fixed in the
snapshot that is being generated now.

http://cygwin.com/snapshots/

Only the snapshot > 2011-06-01 will have the fix.

cgf

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

  parent reply	other threads:[~2011-06-04  1:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 10:44 Chris Sutcliffe
2011-06-02 12:28 ` Christopher Faylor
2011-06-02 13:06   ` Chris Sutcliffe
2011-06-02 13:34     ` Ryan Johnson
2011-06-02 13:46       ` marco atzeri
2011-06-02 15:48         ` Chris Sutcliffe
2011-06-03  2:25           ` Christopher Faylor
2011-06-03  3:32             ` Ryan Johnson
2011-06-04  1:14     ` Christopher Faylor [this message]
2011-06-04  1:57       ` Chris Sutcliffe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110604011359.GA30631@ednor.casa.cgf.cx \
    --to=cgf-use-the-mailinglist-please@cygwin.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).