From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: untarring symlinks with ../ fails randomly, silghtly OT
Date: Mon, 04 Jul 2011 11:34:00 -0000 [thread overview]
Message-ID: <20110704113319.GC20822@calimero.vinschen.de> (raw)
In-Reply-To: <4E119C61.7070505@cs.utoronto.ca>
On Jul 4 06:56, Ryan Johnson wrote:
> On 04/07/2011 6:46 AM, Corinna Vinschen wrote:
> >On Jul 4 11:15, Wolf Geldmacher wrote:
> >>As an aside:
> >> I also used to have some trouble with "rm -rf" of a directory
> >> hierarchy failing more or less reproducibly (like: 80% of the
> >> time) because files were presumably still "in use". Repeating
> >> the command several times would succeed, though.
> >>
> >> Downgrading from cygwin1.dll/1.7.9.1 to cygwin1.dll/1.7.8.1
> >> seems to have solved that issue as well - still have to see
> >> the first "retry to delete".
> >>
> >>This may or may not be related to the original report, as it also reeks
> >>of a race condition during file/directory operations.
> >I can neither reproduce the tar problem, nor can I reprocude the rm
> >problem. I tried this under 2008R2 which is basically the same as your
> >W7-64 bit. I used local and remote drives to test the issue but to no
> >avail.
> >
> >Are you sure this isn't a BLODA problem which is triggered by the
> >changes in 1.7.9?
> >
> >I just took a look through the changes between 1.7.8 and 1.7.9, and
> >the list of changes which affect filesystem access is pretty small:
> >
> >[snip]
> >
> >So, is it possible that the request for WRITE_DAC access in the call to
> >NtCreateFile triggers some hiccup of your virus checker? It could easily
> >explain both effects.
> I have also seen the rm -rf problem occasionally on my w7-64
> machine, and I don't think anything from BLODA is installed.
Also with 1.7.8? Given the minor number of FS-related changes, it's
so very unlikely that they would cause a differnce between 1.7.8 and
1.7.9.
> However, I haven't noticed the issue since disabling the search
> indexer on my machine. I did this on the hunch that I often delete
> large directory trees which aren't very old (e.g. after
> untar/configure/make of some source package), and that it wouldn't
> be a big surprise if indexing and cygwin's rm don't mix for whatever
> reason.
Hard to imagine that setting the WRITE_DAC flag would interfere with the
search indexer. On second thought, the flag is only set if a file does
not exist yet and NtCreateFile gets called to create the file. That
makes it especially unlikely that this would affect unlinking.
However, given that you can reproduce the issue, could you test the
scenario again? If the issue occurs, can you disable the following code
in fhandler.cc and see if it changes anything?
616 else if (!exists () && has_acls ())
617 /* If we are about to create the file and the filesystem supports
618 ACLs, we will overwrite the DACL after the call to NtCreateFile.
619 This requires a handle with additional WRITE_DAC access,
620 otherwise set_file_sd has to open the file again. */
621 access |= WRITE_DAC;
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
next prev parent reply other threads:[~2011-07-04 11:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 12:43 untarring symlinks with ../ fails randomly Wolf Geldmacher
2011-06-30 13:37 ` Corinna Vinschen
2011-06-30 15:05 ` Ken Brown
2011-06-30 15:26 ` Corinna Vinschen
2011-06-30 15:28 ` Wolf Geldmacher
2011-07-04 9:16 ` untarring symlinks with ../ fails randomly, silghtly OT Wolf Geldmacher
2011-07-04 10:47 ` Corinna Vinschen
2011-07-04 10:56 ` Ryan Johnson
2011-07-04 11:34 ` Corinna Vinschen [this message]
2011-07-04 11:55 ` Corinna Vinschen
2011-07-04 12:07 ` Wolf Geldmacher
2011-07-04 12:22 ` Ryan Johnson
2011-07-04 14:21 ` Corinna Vinschen
2011-07-04 15:13 ` Corinna Vinschen
2011-07-05 12:12 ` Corinna Vinschen
2011-07-04 15:05 ` Ryan Johnson
2011-07-04 21:44 ` Mark Geisert
2011-07-04 12:00 ` Wolf Geldmacher
2011-07-05 12:12 ` Corinna Vinschen
2011-07-05 12:21 ` Ryan Johnson
2011-07-05 17:02 ` Wolf Geldmacher
2011-07-05 15:53 ` Wolf Geldmacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704113319.GC20822@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).