From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26765 invoked by alias); 8 Nov 2011 05:53:27 -0000 Received: (qmail 26756 invoked by uid 22791); 8 Nov 2011 05:53:26 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,UNPARSEABLE_RELAY X-Spam-Check-By: sourceware.org Received: from nm27.access.bullet.mail.mud.yahoo.com (HELO nm27.access.bullet.mail.mud.yahoo.com) (66.94.237.92) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Tue, 08 Nov 2011 05:53:08 +0000 Received: from [66.94.237.195] by nm27.access.bullet.mail.mud.yahoo.com with NNFMP; 08 Nov 2011 05:53:08 -0000 Received: from [66.94.237.120] by tm6.access.bullet.mail.mud.yahoo.com with NNFMP; 08 Nov 2011 05:53:08 -0000 Received: from [127.0.0.1] by omp1025.access.mail.mud.yahoo.com with NNFMP; 08 Nov 2011 05:53:08 -0000 Received: (qmail 26158 invoked from network); 8 Nov 2011 05:53:07 -0000 X-Yahoo-SMTP: jenXL62swBAWhMTL3wnej93oaS0ClBQOAKs8jbEbx_o- Received: from cgf.cx (cgf@98.110.183.46 with login) by smtp102.vzn.mail.bf1.yahoo.com with SMTP; 07 Nov 2011 21:53:07 -0800 PST Received: from localhost (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id 844BC13C0D3 for ; Tue, 8 Nov 2011 00:53:06 -0500 (EST) Date: Tue, 08 Nov 2011 05:53:00 -0000 From: Christopher Faylor To: cygwin@cygwin.com Subject: Re: ptsname_r Message-ID: <20111108055306.GA11449@ednor.casa.cgf.cx> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <4EB82DF9.7080408@redhat.com> <20111107193521.GA30056@ednor.casa.cgf.cx> <4EB8437B.5090600@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EB8437B.5090600@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com X-SW-Source: 2011-11/txt/msg00129.txt.bz2 On Mon, Nov 07, 2011 at 01:45:47PM -0700, Eric Blake wrote: >On 11/07/2011 12:35 PM, Christopher Faylor wrote: >> On Mon, Nov 07, 2011 at 12:14:01PM -0700, Eric Blake wrote: >>> Since ptsname() is not thread-safe on all platforms, it would be nice if >>> cygwin could also export ptsname_r() to match glibc. >>> >>> If no one beats me to it, I'll try and submit patches this week. >> >> I'll do it. I've been in this code recently so it's fresh in my mind. > >Thanks. Also, even with your patches of today, ptsname() is still not >thread-safe; should we be sticking that in a thread-local buffer rather >than in static storage, similar to how other functions like strerror() >are thread-safe? Why would we do that when it hasn't been thread-safe for years and it is acceptable behavior for it not to be. The thread-local storage is precious and I don't see a pressing need for this to be thread-safe. cgf -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple