public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf-use-the-mailinglist-please@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: gnome-keyring bug in snapshots
Date: Mon, 05 Dec 2011 05:02:00 -0000	[thread overview]
Message-ID: <20111205050210.GA22950@ednor.casa.cgf.cx> (raw)
In-Reply-To: <1323050598.6872.5.camel@YAAKOV04>

On Sun, Dec 04, 2011 at 08:03:18PM -0600, Yaakov (Cygwin/X) wrote:
>On Sun, 2011-12-04 at 14:27 -0500, Christopher Faylor wrote:
>> The real problem seemed to be a change introduced after 1.7.9 which
>> subtly broke the handling of signals during I/O.  That should be fixed
>> in the latest snapshot but, like so much of what I've worked on in Cygwin
>> lately, it touched a fundamental part of the code.  I wish I hadn't had
>> to make this change just before 1.7.10 but, in theory, it should make
>> it possible for a signal handler to be caught in a thread - that's a first
>> for Cygwin and it's something I've been meaning to get to for a while.
>
>The 20111204 snapshot fixes gnome-keyring.  Thanks!

That's a relief.  I have to admit that this is one of the few times that
I fixed a problem without first understanding the root cause.  I saw
that there was something fishy going on but it didn't seem to relate to
the gnome-keyring problem.  But after several stabs at fixing the fishy
problem, the gnome-keyring problem vanished.

>> This isn't perfect though and I hope that doesn't mean that I've
>> introduced other corner case problems.
>
>I'll continue testing CVS HEAD and see what happens.  How much more
>churn are you planning before 1.7.10?

I think (unless Corinna disagrees) that the current snapshot should be
considered 1.7.10rc1.  I really don't want to perturb the source code
any more now unless it's absolutely necessary.  Even this current fix is
basically just a band-aid.  I hope to rework some of the signal handling
for 1.7.11 to make things a little less ugly.

cgf

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

      reply	other threads:[~2011-12-05  5:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30  4:14 Yaakov (Cygwin/X)
2011-12-03 18:45 ` Christopher Faylor
2011-12-03 21:31   ` Christopher Faylor
2011-12-03 23:04     ` Corinna Vinschen
2011-12-04 19:27       ` Christopher Faylor
2011-12-05  2:03         ` Yaakov (Cygwin/X)
2011-12-05  5:02           ` Christopher Faylor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111205050210.GA22950@ednor.casa.cgf.cx \
    --to=cgf-use-the-mailinglist-please@cygwin.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).