From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16293 invoked by alias); 5 Dec 2011 05:02:28 -0000 Received: (qmail 16283 invoked by uid 22791); 5 Dec 2011 05:02:26 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mho-03-ewr.mailhop.org (HELO mho-01-ewr.mailhop.org) (204.13.248.66) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Dec 2011 05:02:12 +0000 Received: from pool-173-76-42-41.bstnma.fios.verizon.net ([173.76.42.41] helo=cgf.cx) by mho-01-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1RXQgt-000LUG-6i for cygwin@cygwin.com; Mon, 05 Dec 2011 05:02:11 +0000 Received: from localhost (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id A2A7313C0D3 for ; Mon, 5 Dec 2011 00:02:10 -0500 (EST) X-Mail-Handler: MailHop Outbound by DynDNS X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1872FFobjn6Wq+tJjLEgCiA Date: Mon, 05 Dec 2011 05:02:00 -0000 From: Christopher Faylor To: cygwin@cygwin.com Subject: Re: gnome-keyring bug in snapshots Message-ID: <20111205050210.GA22950@ednor.casa.cgf.cx> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <20111203184459.GA21371@ednor.casa.cgf.cx> <20111203213047.GA24925@ednor.casa.cgf.cx> <20111203230408.GC12518@calimero.vinschen.de> <20111204192741.GA21203@ednor.casa.cgf.cx> <1323050598.6872.5.camel@YAAKOV04> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1323050598.6872.5.camel@YAAKOV04> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com X-SW-Source: 2011-12/txt/msg00068.txt.bz2 On Sun, Dec 04, 2011 at 08:03:18PM -0600, Yaakov (Cygwin/X) wrote: >On Sun, 2011-12-04 at 14:27 -0500, Christopher Faylor wrote: >> The real problem seemed to be a change introduced after 1.7.9 which >> subtly broke the handling of signals during I/O. That should be fixed >> in the latest snapshot but, like so much of what I've worked on in Cygwin >> lately, it touched a fundamental part of the code. I wish I hadn't had >> to make this change just before 1.7.10 but, in theory, it should make >> it possible for a signal handler to be caught in a thread - that's a first >> for Cygwin and it's something I've been meaning to get to for a while. > >The 20111204 snapshot fixes gnome-keyring. Thanks! That's a relief. I have to admit that this is one of the few times that I fixed a problem without first understanding the root cause. I saw that there was something fishy going on but it didn't seem to relate to the gnome-keyring problem. But after several stabs at fixing the fishy problem, the gnome-keyring problem vanished. >> This isn't perfect though and I hope that doesn't mean that I've >> introduced other corner case problems. > >I'll continue testing CVS HEAD and see what happens. How much more >churn are you planning before 1.7.10? I think (unless Corinna disagrees) that the current snapshot should be considered 1.7.10rc1. I really don't want to perturb the source code any more now unless it's absolutely necessary. Even this current fix is basically just a band-aid. I hope to rework some of the signal handling for 1.7.11 to make things a little less ugly. cgf -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple