From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31253 invoked by alias); 20 Jun 2013 05:47:18 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 31242 invoked by uid 89); 20 Jun 2013 05:47:17 -0000 X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mho-03-ewr.mailhop.org (HELO mho-01-ewr.mailhop.org) (204.13.248.66) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 20 Jun 2013 05:47:17 +0000 Received: from pool-108-49-156-142.bstnma.fios.verizon.net ([108.49.156.142] helo=cgf.cx) by mho-01-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1UpXiF-000M91-Jk for cygwin@cygwin.com; Thu, 20 Jun 2013 05:47:15 +0000 Received: from localhost (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id 6E15660125 for ; Thu, 20 Jun 2013 01:47:15 -0400 (EDT) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19RgxYGPyvshCBODyiBEdF8 Date: Thu, 20 Jun 2013 06:35:00 -0000 From: Christopher Faylor To: cygwin@cygwin.com Subject: Re: Bug with Cygwin's 'quilt' is actually in 'patch' Message-ID: <20130620054715.GC5122@ednor.casa.cgf.cx> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <51BFEB6E.2040404@codespunk.com> <51BFF1F9.4040205@codespunk.com> <51C277A4.20709@codespunk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51C277A4.20709@codespunk.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-SW-Source: 2013-06/txt/msg00523.txt.bz2 On Wed, Jun 19, 2013 at 11:31:48PM -0400, Matt D. wrote: >I've been looking further into this and it appears as though the problem >is in 'patch' not 'quilt'. quilt is actually a collection of bash >scripts and calls patch to do the actual patching. > >Using the same example I provided earlier in the thread, the same error >occurs when calling patch directly: > >$ patch Imakefile patches/test.patch > >Running dos2unix on test.patch will allow the patch to apply >successfully. However, this is WRONG. Imakefile and the initially >created test.patch both use CRLF line endings. The patch should >definitely NOT apply by introducing actual disparity. > >To summarize, the patch to Imakefile (CRLF) will apply if it is >converted to LF line endings. Using the '--binary' switch seems to be a >workaround for this issue. Sorry but we're emulating Linux here. You shouldn't have CRLF endings on your text file if you want the tools to work reliably. cgf -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple