Re: MSYS mode (continue)

[Corinna Vinschen <corinna-cygwin@cygwin.com>]

On Jul  4 12:34, Kai Tietz wrote:
> 2013/7/4 Alexey Pavlov wrote:
> > 2013/7/4 Corinna Vinschen:
> >> On Jul  4 12:37, Alexey Pavlov wrote:
> >>> 2013/7/4 Corinna Vinschen:
> >>> > On Jul  4 13:09, Alexey Pavlov wrote:
> >>> >> 2013-06-18  Alexey Pavlov
> >>> >>
> >>> >> * mount.cc: Allow using a shortened version of mount points in /etc/fstab
> >>> >> * utsname.h: Increase sysname fiels size.
> >>> >> * uname.cc: Allow changing OS name by MSYSTEM environment variable.
> >>> >> [...SNIP...]
> >>> >
> >>> > Can we please move patch submissions to the cygwin-patches mailing list?
> >>> > Thank you.
> >>> >
> >>> >> Index: cygwin/include/sys/utsname.h
> >>> >> ===================================================================
> >>> >> RCS file: /cvs/src/src/winsup/cygwin/include/sys/utsname.h,v
> >>> >> retrieving revision 1.3
> >>> >> diff -u -p -r1.3 utsname.h
> >>> >> --- cygwin/include/sys/utsname.h 21 Jan 2013 04:38:31 -0000 1.3
> >>> >> +++ cygwin/include/sys/utsname.h 18 Jun 2013 11:39:27 -0000
> >>> >> @@ -17,7 +17,7 @@ extern "C" {
> >>> >>
> >>> >>  struct utsname
> >>> >>  {
> >>> >> -  char sysname[20];
> >>> >> +  char sysname[21];
> >>> >
> >>> > We can't do that.  struct utsname is a publically facing structure.
> >>> > If you change the size, you're breaking compatibility with existing
> >>> > applications.
> >>> >
> >>> > You should better drop some character from the string you want to enter
> >>> > here.
> >>> >
> >>>
> >>> I can't drop any symbol from "MINGW32" word :)
> >>
> >> That's not 20 chars long.
> >>
> > Yes. But not only this need to be in 20 symbols. On cygwin 20 symbols is:
> >
> > CYGWIN_NT-6.1-WOW64\0
> >
> > But
> >
> > MINGW32_NT-6.1-WOW64\0
> >
> > is 21 symbol.
> 
> Hmm, out of curiousity.  Why is the name MINGW_NT-6.1-WOW64\0 not
> suitable.  For what is this 32 good for?
> 
> > Regards,
> > Alexey.
> 
> Sorry, for this stupid question.

No sorry here, it's not stupid.  I agree, why not just drop the "32"?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple