From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Cc: DJ Delorie <dj@redhat.com>, Kai Tietz <ktietz@redhat.com>
Subject: Re: Core dump on 32-bit Cygwin if program calls dlopen
Date: Thu, 24 Jul 2014 13:45:00 -0000 [thread overview]
Message-ID: <20140724134516.GC12212@calimero.vinschen.de> (raw)
In-Reply-To: <CAEwic4aBPee5ojhAb9zYh95P3b8VJfXsZBefEGRkBU5SHnpX8w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2590 bytes --]
On Jul 24 15:08, Kai Tietz wrote:
> 2014-07-22 15:20 GMT+02:00 Corinna Vinschen wrote:
> > On Jul 22 13:59, Jon TURNEY wrote:
> >> On 22/07/2014 09:27, Corinna Vinschen wrote:
> >> >On Jul 17 20:24, Corinna Vinschen wrote:
> >> >>On Jul 17 16:31, Jon TURNEY wrote:
> >> >>>On 17/07/2014 08:37, Corinna Vinschen wrote:
> >> >>>>It's the libgcc DLL which gives us grief, so a new libgcc package is
> >> >>>>sufficent, afaics. We should check if this DLL fixes the problem and
> >> >>>>then make it "curr" soon, I think.
> >> >>>
> >> >>>I briefly tested this other patch with my test case from the mail above, and
> >> >>>it doesn't seem to help.
> >> >>>[...]
> >> >>I asked DJ to take another look, but I guess ultimately we need the
> >> >>attention of one of the GCC Windows maintainers. Kai Tietz seems to be
> >> >>unavailable right now, unfortunately.
> >> >
> >> >Looks like I totally misunderstood DJ's patch. The patch does *not*
> >> >change libgcc, it changes cygmin-crtbegin.c, thus the crtbegin.o file
> >> >which is statically linked into the executable.
> >> >
> >> >That means, to fix the issue, you don't have to replace libgcc, you
> >> >have to recompile the executable against the new crtbegin.o.
> >> >
> >> >DJ still claims his patch is the correct one. The simple testcase
> >> >dlopen'ing cyggs-9.dll works fine with the new crtbegin.o, according to
> >> >him.
> >>
> >> Sorry, I hadn't tested it correctly.
> >
> > No worries, this was my fault. Talking about building a new libgcc
> > rather than building a new crtbegin.o was bound to lead everyone
> > off track :|
> >
> >> Building my test with an updated crtbegin.o as well, my test case is fixed.
> >
> > Nice!
> >
> >> I agree this patch seems better than my suggested one, as it makes crtbegin
> >> do the right thing in the face of unbalanced libgcc load/unload, rather than
> >> attempting to balance the libgcc load/unload as mine does.
> >
> > Ok. I CC'ed DJ so he knows all is good, and then we probably need a
> > windows GCC maintainer to approve the patch I guess. Kai? Ping?
> >
>
> Hi Corinna
>
> As I we spoke yesterday on irc, I took already a look to DJ's patch
> and it is sensible. If DJ sends patch upstream to gcc's ML, and put
> me CC, I will review it asap.
Thanks a lot!
JonY, any chance we could get a gcc package with the new crtbegin.o
soon?
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-24 13:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 23:42 Ken Brown
2014-07-15 9:03 ` Corinna Vinschen
2014-07-15 11:45 ` Ken Brown
2014-07-15 13:08 ` Corinna Vinschen
2014-07-15 13:56 ` JonY
2014-07-15 14:39 ` Corinna Vinschen
2014-07-16 7:02 ` Corinna Vinschen
2014-07-16 22:03 ` JonY
2014-07-17 7:37 ` Corinna Vinschen
2014-07-17 15:31 ` Jon TURNEY
2014-07-17 18:24 ` Corinna Vinschen
2014-07-20 22:02 ` JonY
2014-07-22 8:27 ` Corinna Vinschen
2014-07-22 13:00 ` Jon TURNEY
2014-07-22 13:20 ` Corinna Vinschen
2014-07-24 13:08 ` Kai Tietz
2014-07-24 13:45 ` Corinna Vinschen [this message]
2014-07-24 22:15 ` JonY
2014-07-25 12:37 ` Corinna Vinschen
2014-07-15 13:34 Houder
2014-07-15 14:45 Jan Nijtmans
2014-07-15 15:29 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724134516.GC12212@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
--cc=dj@redhat.com \
--cc=ktietz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).