[ANNOUNCEMENT] Updated: sqlite3-3.8.7.1-1 for Cygwin/Cygwin64

[ANNOUNCEMENT] Updated: sqlite3-3.8.7.1-1 for Cygwin/Cygwin64

[Jan Nijtmans]

SQLite is a software library that implements a self-contained,
serverless, zero-configuration, transactional SQL database engine

Changes since 3.8.6-1
=====================
* Updated to upstream 3.8.7.1 release. See:
     <http://www.sqlite.org/changes.html>
  Main new feature: "pragma threads=?" (default=0, max = 8). This
  enables SQLite to use multiple processor cores at the same
  time for sorting operations. See:
    <http://www.sqlite.org/pragma.html#pragma_threads>
* Additional SQLite (minor) bug-fixes, cherry-picked from SQLite trunk:
  * Add special handling for static mutexes in sqlite3_mutex_alloc()
    when automatic calls to sqlite3_initialize() are enabled
    <http://www.sqlite.org/src/info/7857d27caa>
  * Fix the %c format character in sqlite3VXPrintf() so that it correctly
    handles precisions larger than 70
    <http://www.sqlite.org/src/info/08a27440f1>
  * Fix a (probably harmless) bug in the CSV output mode of
    the command-line shell
    <http://www.sqlite.org/src/info/19fe4a0a47>
  * Change the command-line shell man-page to use the ".tr"
    troff directive instead of ".cc" for escaping the initial "."
    characters in the ".help" output
    <http://www.sqlite.org/src/info/67f0d469da>
* Additional SQLite bug-fixes, rejected (apparently) upstream
  but important (and simple) enough for Cygwin:
  * VFS filename truncation issues
    <http://www.sqlite.org/src/info/c060923a54>
  * Wrong filename handling in sqlite3_load_extension() for Cygwin
    <http://osdir.com/ml/sqlite-users/2014-02/msg00431.html>
  * pragma database_list returns win32 paths on Cygwin
    <http://osdir.com/ml/sqlite-users/2014-02/msg00515.html>
  * ISO time leap second
    <http://osdir.com/ml/sqlite-users/2014-07/msg00606.html>
  * update to Unicode 7.0 for FTS3 tokenizer

--
Jan Nijtmans

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] Updated: sqlite3-3.8.7.1-1 for Cygwin/Cygwin64

[Alexpux]

> 4 нояб. 2014 г., в 15:26, Jan Nijtmans написал(а):
> 
> SQLite is a software library that implements a self-contained,
> serverless, zero-configuration, transactional SQL database engine
> 
> Changes since 3.8.6-1
> =====================
> * Updated to upstream 3.8.7.1 release. See:
>     <http://www.sqlite.org/changes.html>
>  Main new feature: "pragma threads=?" (default=0, max = 8). This
>  enables SQLite to use multiple processor cores at the same
>  time for sorting operations. See:
>    <http://www.sqlite.org/pragma.html#pragma_threads>
> * Additional SQLite (minor) bug-fixes, cherry-picked from SQLite trunk:
>  * Add special handling for static mutexes in sqlite3_mutex_alloc()
>    when automatic calls to sqlite3_initialize() are enabled
>    <http://www.sqlite.org/src/info/7857d27caa>
>  * Fix the %c format character in sqlite3VXPrintf() so that it correctly
>    handles precisions larger than 70
>    <http://www.sqlite.org/src/info/08a27440f1>
>  * Fix a (probably harmless) bug in the CSV output mode of
>    the command-line shell
>    <http://www.sqlite.org/src/info/19fe4a0a47>
>  * Change the command-line shell man-page to use the ".tr"
>    troff directive instead of ".cc" for escaping the initial "."
>    characters in the ".help" output
>    <http://www.sqlite.org/src/info/67f0d469da>
> * Additional SQLite bug-fixes, rejected (apparently) upstream
>  but important (and simple) enough for Cygwin:
>  * VFS filename truncation issues
>    <http://www.sqlite.org/src/info/c060923a54>
>  * Wrong filename handling in sqlite3_load_extension() for Cygwin
>    <http://osdir.com/ml/sqlite-users/2014-02/msg00431.html>
>  * pragma database_list returns win32 paths on Cygwin
>    <http://osdir.com/ml/sqlite-users/2014-02/msg00515.html>
>  * ISO time leap second
>    <http://osdir.com/ml/sqlite-users/2014-07/msg00606.html>
>  * update to Unicode 7.0 for FTS3 tokenizer
> 

Hi!
We tried to update MSYS2 sqlite3 to the same version and found that on i686 doesn’t work properly because the wrong calling convention is used when calling GetModuleHandleW and SetDllDirectoryW.
Here is the patch to fix this issue:

diff -Naur sqlite-autoconf-3080701-orig/sqlite3.c sqlite-autoconf-3080701/sqlite3.c
--- sqlite-autoconf-3080701-orig/sqlite3.c	2014-11-08 20:34:01.593800000 +0300
+++ sqlite-autoconf-3080701/sqlite3.c	2014-11-08 20:37:42.146600000 +0300
@@ -33758,14 +33758,14 @@
   { "GetModuleHandleW",         (SYSCALL)0,                      0 },
 #endif
 
-#define osGetModuleHandleW ((HMODULE(*)(LPCWSTR))aSyscall[76].pCurrent)
+#define osGetModuleHandleW ((HMODULE(WINAPI*)(LPCWSTR))aSyscall[76].pCurrent)
 
 #if defined(SQLITE_WIN32_HAS_WIDE) && !defined(SQLITE_OMIT_LOAD_EXTENSION)
   { "SetDllDirectoryW",         (SYSCALL)SetDllDirectoryW,       0 },
 #else
   { "SetDllDirectoryW",         (SYSCALL)0,                      0 },
 #endif
 
-#define osSetDllDirectoryW ((BOOL(*)(LPCWSTR))aSyscall[77].pCurrent)
+#define osSetDllDirectoryW ((BOOL(WINAPI*)(LPCWSTR))aSyscall[77].pCurrent)
 
 #if defined(__CYGWIN__)
   { "getenv",                   (SYSCALL)getenv,                 0 },

Regards,
Alexey.

> --
> Jan Nijtmans
> 
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
> 


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] Updated: sqlite3-3.8.7.1-1 for Cygwin/Cygwin64

[Jan Nijtmans]

2014-11-08 22:41 GMT+01:00 Alexpux:
> Hi!
> We tried to update MSYS2 sqlite3 to the same version and found that on i686 doesn’t work properly because the wrong calling convention is used when calling GetModuleHandleW and SetDllDirectoryW.
> Here is the patch to fix this issue:

Thank you very much!

sqlite3-3.8.7.1-2 for Cygwin (i686 only) is available now with this fix
(SetDllDirectoryW was used for Cygwin too, so this might have had
an undesired side effect, even though I am not aware of any).

win32/win64 dll's using the same amalgamation sources are available here:
       <http://sourceforge.net/projects/cyqlite/files/3.8.7/>
those dll's should be usable for msys2 as-is (if there is something wrong
with that, please let me know).

Regards,
            Jan Nijtmans

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] Updated: sqlite3-3.8.7.1-1 for Cygwin/Cygwin64

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

On Nov 10 12:36, Jan Nijtmans wrote:
> 2014-11-08 22:41 GMT+01:00 Alexpux:
> > Hi!
> > We tried to update MSYS2 sqlite3 to the same version and found that on i686 doesn’t work properly because the wrong calling convention is used when calling GetModuleHandleW and SetDllDirectoryW.
> > Here is the patch to fix this issue:
> 
> Thank you very much!
> 
> sqlite3-3.8.7.1-2 for Cygwin (i686 only) is available now with this fix
> (SetDllDirectoryW was used for Cygwin too, so this might have had
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    What for?  This should not be necessary.
    
If this is for loading modules via dlopen, the solution should be to
either to add the directory to LD_LIBRARY_PATH, or enhance Cygwin if
it's an issue with loading dependent DLLs.  We can still add 
LoadLibraryEx(LOAD_WITH_ALTERED_SEARCH_PATH).

Ultimately a Cygwin application should not have to call Win32 functions,
except if there's really no way around it.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [ANNOUNCEMENT] Updated: sqlite3-3.8.7.1-1 for Cygwin/Cygwin64

[Jan Nijtmans]

2014-11-10 12:55 GMT+01:00 Corinna Vinschen <corinna-cygwin@cygwin.com>:
> If this is for loading modules via dlopen, the solution should be to
> either to add the directory to LD_LIBRARY_PATH, or enhance Cygwin if
> it's an issue with loading dependent DLLs.  We can still add
> LoadLibraryEx(LOAD_WITH_ALTERED_SEARCH_PATH).
>
> Ultimately a Cygwin application should not have to call Win32 functions,
> except if there's really no way around it.

I'm fully aware of that. But until my patches to the "unix-cygwin" VFS
are not accepted upstream I like to keep the "win32" VFS working
as well. So people can choose whether they like the Win32 way
or the Cygwin way, both simply work.

Regards,
       Jan Nijtmans

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] Updated: sqlite3-3.8.7.1-1 for Cygwin/Cygwin64

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]

On Nov 10 13:51, Jan Nijtmans wrote:
> 2014-11-10 12:55 GMT+01:00 Corinna Vinschen <corinna-cygwin@cygwin.com>:
> > If this is for loading modules via dlopen, the solution should be to
> > either to add the directory to LD_LIBRARY_PATH, or enhance Cygwin if
> > it's an issue with loading dependent DLLs.  We can still add
> > LoadLibraryEx(LOAD_WITH_ALTERED_SEARCH_PATH).
> >
> > Ultimately a Cygwin application should not have to call Win32 functions,
> > except if there's really no way around it.
> 
> I'm fully aware of that. But until my patches to the "unix-cygwin" VFS
> are not accepted upstream I like to keep the "win32" VFS working
> as well. So people can choose whether they like the Win32 way
> or the Cygwin way, both simply work.

Ok, no worries.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]