From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15250 invoked by alias); 23 Mar 2015 10:08:27 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 15241 invoked by uid 89); 23 Mar 2015 10:08:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: calimero.vinschen.de Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Mar 2015 10:08:25 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 6C3ECA80930; Mon, 23 Mar 2015 11:08:23 +0100 (CET) Date: Mon, 23 Mar 2015 16:39:00 -0000 From: Corinna Vinschen To: cygwin@cygwin.com Subject: Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared. Message-ID: <20150323100823.GE3017@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <20150228143653.ab0a6bf854db294105e1d5f3@nifty.ne.jp> <20150228135947.GZ11124@calimero.vinschen.de> <20150302210508.1be5c1ed4753508431842913@nifty.ne.jp> <20150318145854.GC2368@calimero.vinschen.de> <20150319074942.6c18c8fe0199037f028687dd@nifty.ne.jp> <20150319083451.GA8398@calimero.vinschen.de> <20150320191232.GJ2368@calimero.vinschen.de> <20150321104031.9dc198eb8aa4e7652e0a7a51@nifty.ne.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+xNpyl7Qekk2NvDX" Content-Disposition: inline In-Reply-To: <20150321104031.9dc198eb8aa4e7652e0a7a51@nifty.ne.jp> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-03/txt/msg00390.txt.bz2 --+xNpyl7Qekk2NvDX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1570 Hi Takashi, On Mar 21 10:40, Takashi Yano wrote: > Hi Corinna, >=20 > On Fri, 20 Mar 2015 20:12:32 +0100 > Corinna Vinschen wrote: >=20 > > > For the time being, can you send your assignment as PDF via email > > > to my company email address just so > > > we make sure it arrived in *some* way? > >=20 > > Even better. We got legal approval that we can use signed PDFs via > > email alone, and that sending snail mail isn't required anymore. > > Just sendthe PDF to . >=20 > Thank you very much for your effort for approving > PDF copyright assignment. >=20 > I have just sent it via e-mail. And it's all set, finally. Thanks a lot for not giving up on us :) With this out of the way, I'm just looking through your patch and it looks good to me. I have only a few minor style nits: + rc ++; No space between the variable and the increment operator, please. + if ((get_ttyp ()->ti.c_oflag & ONOCR) && get_ttyp ()->col= umn =3D=3D 0) Please try to keep lines <=3D 80 chars: + if ((get_ttyp ()->ti.c_oflag & ONOCR) + && get_ttyp ()->column =3D=3D 0) However, due to the changes in fhandler_tty.cc, this patch doesn't apply cleanly anymore. Any chance you could resend it (ideally to the cygwin-patches ML) diff'ed against git HEAD? Thanks a lot, Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --+xNpyl7Qekk2NvDX Content-Type: application/pgp-signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVD+YXAAoJEPU2Bp2uRE+glm4QAIieveYI5y3HGkBiPPqV8WEz GGUxHB6wcUI0RUIEtZUzWCZikmwtm/SqF0N78GrVvIyuRuByEnk0nQJ6FNj90R4r PMYY8SKmgHzC23YwRlAv5klqfgzt2Slwyw/VM2Ktrgqic9w5l9Uwh641oyWUIN6C /e10CXifa+aNmoM4J/5nC1/OH2jV1rHH+gXB4R+6Tj5LATip/3s/iJKkNCNP9fdR mJ2TuPpkY1JNkpFOgtX4gwTjS5Cgo40S5Ztq8tbJuYkFy6bFj0yMWvTqOGqTKfcO wsYDY+MWqof+NsnURmD/QAEDTy5Z8WAtzpyhVdquMoNbG7bh9QN1/+oMgJSIDY0j BmUxnc1B3WsHwkm1XlU2iv25dpLe3bfQe3bY5OKYoLxjvkYdi+HwSU9pUd6GeMoK tix+WlCZcKlbmvVkJYT1z1yu0OSBOYgr9zZQF1CZ+m44Go9EKgdLMdSFnqL5yYng 4rT/fL1KXKX1BQ56GboN1V2SbQXQ8qJIOxtbfGxp0mBvbYuEw9pPHjUDkJPnuKDE GUGEa/qCD6lV7dN3aMqHngwktjp8PalS2n+ZC2svfc/MjlSSS5Vogn13GB4qeZpT bkB8TznMM46eTgWM0TSiWqVtUCJgSATI8AjqGwh3VbMyzIqzFMY+vfOh3chdH3WR T9Sw6z6Gd4ePMVwJ0VA2 =IEHZ -----END PGP SIGNATURE----- --+xNpyl7Qekk2NvDX--