From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112861 invoked by alias); 25 Mar 2015 11:20:45 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 112847 invoked by uid 89); 25 Mar 2015 11:20:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_SORBS_DUL,SPF_PASS autolearn=ham version=3.3.2 X-HELO: conuserg003-v.nifty.com Received: from conuserg003.nifty.com (HELO conuserg003-v.nifty.com) (202.248.45.244) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (DES-CBC3-SHA encrypted) ESMTPS; Wed, 25 Mar 2015 11:20:43 +0000 Received: from Express5800-S70 (ntsitm305199.sitm.nt.ftth.ppp.infoweb.ne.jp [121.93.68.199]) (authenticated) by conuserg003-v.nifty.com with ESMTP id t2PBKKmE014001 for ; Wed, 25 Mar 2015 20:20:21 +0900 X-Nifty-SrcIP: [121.93.68.199] Date: Wed, 25 Mar 2015 12:41:00 -0000 From: Takashi Yano To: cygwin@cygwin.com Subject: Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared. Message-Id: <20150325202046.f6b6f40c0245145760d72391@nifty.ne.jp> In-Reply-To: <20150323100823.GE3017@calimero.vinschen.de> References: <20150228143653.ab0a6bf854db294105e1d5f3@nifty.ne.jp> <20150228135947.GZ11124@calimero.vinschen.de> <20150302210508.1be5c1ed4753508431842913@nifty.ne.jp> <20150318145854.GC2368@calimero.vinschen.de> <20150319074942.6c18c8fe0199037f028687dd@nifty.ne.jp> <20150319083451.GA8398@calimero.vinschen.de> <20150320191232.GJ2368@calimero.vinschen.de> <20150321104031.9dc198eb8aa4e7652e0a7a51@nifty.ne.jp> <20150323100823.GE3017@calimero.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00451.txt.bz2 Hi Corinna, On Mon, 23 Mar 2015 11:08:23 +0100 Corinna Vinschen wrote: > With this out of the way, I'm just looking through your patch and it > looks good to me. I have only a few minor style nits: > > + rc ++; > > No space between the variable and the increment operator, please. > > + if ((get_ttyp ()->ti.c_oflag & ONOCR) && get_ttyp ()->column == 0) > > Please try to keep lines <= 80 chars: > > + if ((get_ttyp ()->ti.c_oflag & ONOCR) > + && get_ttyp ()->column == 0) Thank you for checking my patch. > However, due to the changes in fhandler_tty.cc, this patch doesn't > apply cleanly anymore. Any chance you could resend it (ideally to the > cygwin-patches ML) diff'ed against git HEAD? I will post a revised patch to cygwin-patches ML soon. Thank you in advance. -- Takashi Yano -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple