On Apr  1 21:31, Qian Hong wrote:
> Hi Corinna,
> 
> On Wed, Apr 1, 2015 at 8:22 PM, Corinna Vinschen
> <corinna-cygwin@cygwin.com> wrote:
> >
> > I now `git push'ed and re-created the April's fool snapshot *with* the
> > patch to address your issue.
> Thanks for the quick fix.
> 
> I tested a little bit but it doesn't work, and my patch to Wine still works.
> 
> Unfortunately it would be a bit tricky for me to provide a backtrace
> very soon due to limited debug symbol support of WineDbg. Before look
> deeper, could we confirm we are testing the same binary?
> 
> I'm testing:
>  x86/cygwin1-20150401.dll.xz
> 
> $ sha1sum cygwin1-20150401.dll.xz
> 01d5092d48f3742cedcb28ea646b10088373d549  cygwin1-20150401.dll.xz
> 
> $ sha1sum cygwin1-20150401.dll
> 5619b74582a6584626c6dc05106698f9560d0d8a  cygwin1-20150401.dll
> 
> I renamed cygwin1-20150401.dll to  cygwin1.dll and copied to
> C:\cygwin\bin\cygwin1.dll
> 
> But Wine bash.exe still crashes, in a slightly different way:
> originally, it complains about access to invalid memory address
> 0x00000002, now it turns to invalid address 0x00000000 => not sure
> this is useful information.

A bit more debugging would be useful.  I debugged this on native
Windows and the code is not accessing a negative index to the domain
list anymore.  From my POV *this* part of the code is working as
desired.

> Here is some strace.exe output:
> 
>   228  142321 [main] bash 11 __get_lcid_from_locale: LCID=0x0409
>   659  142980 [main] bash 11 pwdgrp::fetch_account_from_windows: line:
> <Administrators:S-1-5-32-544:544:>
>   715  143695 [main] bash 11 pwdgrp::fetch_account_from_windows: line:
> <LOCAL:S-1-2-0:66048:>
>   146  143841 [main] bash 11 pwdgrp::fetch_account_from_windows: line:
> <INTERACTIVE:S-1-5-4:4:>
>   141  143982 [main] bash 11 pwdgrp::fetch_account_from_windows: line:
> <Authenticated Users:S-1-5-11:11:>
>   155  144137 [main] bash 11 pwdgrp::fetch_account_from_windows: line:
> <Users:S-1-5-32-545:545:>
> --- Process 11, exception c0000005 at 6113FD85

That's a crash in wcsncpy.  Where's the NULL pointer coming from?
The pointer I created for the domain name points to an empty
unicode string, it's not NULL.

Oh, hang on.

On Windows, the name part of the logon sid is the login sid as 
a string.  So, if the login sid is S-1-5-5-0-1234, the name of the
sid is L"S-1-5-5-0-1234".

Is it possible that Wine doesn't reflect that?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat