From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34893 invoked by alias); 1 Apr 2015 13:45:58 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 34848 invoked by uid 89); 1 Apr 2015 13:45:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_50 autolearn=ham version=3.3.2 X-HELO: calimero.vinschen.de Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Apr 2015 13:45:57 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 93748A8096E; Wed, 1 Apr 2015 15:45:54 +0200 (CEST) Date: Wed, 01 Apr 2015 13:45:00 -0000 From: Corinna Vinschen To: cygwin@cygwin.com Cc: Qian Hong Subject: Re: Cygwin / MSYS2 runtime fails on Wine beause of accessing to (*ReferencedDomains)->Domains[-1] Message-ID: <20150401134554.GW13285@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com, Qian Hong References: <20150401103733.GA4835@calimero.vinschen.de> <20150401113620.GA11571@calimero.vinschen.de> <20150401122206.GA5725@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0lx/R+CYDdR/AN/7" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-04/txt/msg00025.txt.bz2 --0lx/R+CYDdR/AN/7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2593 On Apr 1 21:31, Qian Hong wrote: > Hi Corinna, >=20 > On Wed, Apr 1, 2015 at 8:22 PM, Corinna Vinschen > wrote: > > > > I now `git push'ed and re-created the April's fool snapshot *with* the > > patch to address your issue. > Thanks for the quick fix. >=20 > I tested a little bit but it doesn't work, and my patch to Wine still wor= ks. >=20 > Unfortunately it would be a bit tricky for me to provide a backtrace > very soon due to limited debug symbol support of WineDbg. Before look > deeper, could we confirm we are testing the same binary? >=20 > I'm testing: > x86/cygwin1-20150401.dll.xz >=20 > $ sha1sum cygwin1-20150401.dll.xz > 01d5092d48f3742cedcb28ea646b10088373d549 cygwin1-20150401.dll.xz >=20 > $ sha1sum cygwin1-20150401.dll > 5619b74582a6584626c6dc05106698f9560d0d8a cygwin1-20150401.dll >=20 > I renamed cygwin1-20150401.dll to cygwin1.dll and copied to > C:\cygwin\bin\cygwin1.dll >=20 > But Wine bash.exe still crashes, in a slightly different way: > originally, it complains about access to invalid memory address > 0x00000002, now it turns to invalid address 0x00000000 =3D> not sure > this is useful information. A bit more debugging would be useful. I debugged this on native Windows and the code is not accessing a negative index to the domain list anymore. From my POV *this* part of the code is working as desired. > Here is some strace.exe output: >=20 > 228 142321 [main] bash 11 __get_lcid_from_locale: LCID=3D0x0409 > 659 142980 [main] bash 11 pwdgrp::fetch_account_from_windows: line: > > 715 143695 [main] bash 11 pwdgrp::fetch_account_from_windows: line: > > 146 143841 [main] bash 11 pwdgrp::fetch_account_from_windows: line: > > 141 143982 [main] bash 11 pwdgrp::fetch_account_from_windows: line: > > 155 144137 [main] bash 11 pwdgrp::fetch_account_from_windows: line: > > --- Process 11, exception c0000005 at 6113FD85 That's a crash in wcsncpy. Where's the NULL pointer coming from? The pointer I created for the domain name points to an empty unicode string, it's not NULL. Oh, hang on. On Windows, the name part of the logon sid is the login sid as=20 a string. So, if the login sid is S-1-5-5-0-1234, the name of the sid is L"S-1-5-5-0-1234". Is it possible that Wine doesn't reflect that? Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --0lx/R+CYDdR/AN/7 Content-Type: application/pgp-signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVG/aSAAoJEPU2Bp2uRE+gipAP/A/cGj8r5nDanqcLzDBo7yEd 5NjsljnIfoR19FdfIBWa48nj2BUkhwhSeji6k71W38L/54eZfIyEoH8cMZ3HMnxO G/SXocfmLKEo/+eXGgsBPlOxnJRWQi0CCvS3oRB78GrAWNU644FNWbyhkD1rSWDV wqQVhhWvzJnjjvOBJhjJQmPZrFDxzk0oRYS0m541y10RRol/TJ4nKS47Jwgf/3By 72RX1M7U7dR3QuOxi57DBczDeuKLu7OTfU5U/FcIBkdmuihtUaA5adSh8BRfoET4 IZEpdC3GgQgyiVpUEl9bgBkiLGlywI2c2ljE+rog8eUWimtyrT8qd4cRE4J5wev5 z0ZTVJ8Ph+W/nrxoa9szJvLKF3lDu3rlxygHpghQqvsgnPd9ER9rmur2rr3B4fpi F5MRKoB9QIdmxg0YdSZK7QDymjfdXvMDRDd0etNiRWu/DCabThI4UrqZpdmN0hcx F2vClOZZWlPyz1ZqiAGCLCah6DM3oB7dEuPOU+NAQjAiSn+zcTC4XZKrLvSRcCOY UPlyNjTLlBV5o7c8oiHWOCTA4UAmalns5f1ommnp8B+be6ke6HBsBW1Eiv/3yflD SwpZDNmkajDlnU34t9oJPK6gdAbpFpxliEpY8/WDnHZXHMRrpuYOlmsv+ev5zZeX fg84G9Bppw4kXqNgnIuL =hGPz -----END PGP SIGNATURE----- --0lx/R+CYDdR/AN/7--