Re: Cygwin hangs up if several keys are typed during outputting a lot of texts.

[Corinna Vinschen <corinna-cygwin@cygwin.com>]

[-- Attachment #1: Type: text/plain, Size: 2007 bytes --]

Hi Takashi,

On Apr  5 20:55, Takashi Yano wrote:
> Hi Corinna,
> 
> On Sat, 4 Apr 2015 10:43:54 +0200
> Corinna Vinschen <corinna-cygwin@cygwin.com> wrote:
> 
> > That should have been fixed by cbb9849fa76f1dbe6c66d91b68d9a10f46f1ba69.
> > You have to rebuild Cygwin to make this change have an effect.
> > 
> > Alternatively you could checkout f992ae6f4da99b6a200cfc146b96e8e921ca1e70
> > to ignore the ucontext stuff for now.
> 
> Hmm, even after cbb9849fa76f1dbe6c66d91b68d9a10f46f1ba69,
> it does not work in my environment.
> 
> But ok, f992ae6f4da99b6a200cfc146b96e8e921ca1e70 works.
> 
> Using f992ae6f4da99b6a200cfc146b96e8e921ca1e70, the problem
> you had pointed out has been regenerated. Same problem can
> be regenerated with a simple test case below.
> 
> #include <windows.h>
> 
> int main()
> {
> 	HANDLE hCons;
> 	DWORD n;
> 
> 	hCons = GetStdHandle(STD_OUTPUT_HANDLE);
> 	WriteFile(hCons, "AAAA\n", 5, &n, NULL);
> 	WriteFile(hCons, "BBBB\n", 5, &n, NULL);
> 	WriteFile(hCons, "CCCC\n", 5, &n, NULL);
> 	CloseHandle(hCons);
> 	return 0;
> }
> 
> This is caused obviously by the patch I had proposed.
> Post processing, in which \n is converted to \r\n, was in
> the read process previously, so it had effect to the test
> case above.
> 
> However, now the post processing is in the write process,
> so it does not have effect against direct WriteFile() to
> the pipe.
> 
> Unfortunately, I have no idea for the moment....

The problem is that the patch shifted processing from the pty master to
the slave, but the slave isn't necessarily a well-behaved Cygwin process.

I think we should move opost processing back to the master side.  Would
it be much of a problem to restructure your patch to do that, without
re-introducing the old problems your patch fixed?


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]