From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: Cygwin hangs up if several keys are typed during outputting a lot of texts.
Date: Thu, 16 Apr 2015 09:10:00 -0000 [thread overview]
Message-ID: <20150416091004.GA24584@calimero.vinschen.de> (raw)
In-Reply-To: <20150416090533.GB3657@calimero.vinschen.de>
[-- Attachment #1: Type: text/plain, Size: 2051 bytes --]
On Apr 16 11:05, Corinna Vinschen wrote:
> Hi Takashi,
>
> On Apr 16 09:26, Takashi Yano wrote:
> > So OPOST processing should be in master side for native windows program.
> > However, to solve the second problem I had pointed out in
> > http://cygwin.com/ml/cygwin/2015-02/msg00929.html ,
> > OPOST processing should be done on a timing when slave calls write().
> >
> > To solve this antinomy, I have made a patch attached.
> >
> > With this patch, new pipe is introduced to handle OPSOT-process separately
> > between native windows program and cygwin program.
> >
> > Data from cygwin program is passed through the pipe newly introduced.
> > In this case, process_opost_output() is called in fhandler_pty_slave::write().
> > Master reads data, which is already applied OPOST process, from the
> > new pipe.
> >
> > On the other hands, for native windows program, data is written into
> > conventional pipe. Master forwarding thread, which is also newly
> > introduced, reads conventional pipe and forward the data to the pipe
> > newly introduced by calling process_opost_output(). This makes OPOST
> > processing be done in master side.
> >
> > I have confirmed that the both problem is fixed with this patch.
>
> Ok, but... this is a really big patch and it complicates the pty code
> even more. Is there really no other option as far as the TCSADRAIN
> problem is concerned?
>
> What strikes me as weird is that neither fhandler_pty_slave::tcsetattr
> nor fhandler_pty_master::tcsetattr give a damn for the optional_actions
> parameter. They simply overwrite the tc settings. So I'm wondering,
> wouldn't it be possible to add code to the tcsetattr implementation
> instead, so that TCSADRAIN/TCSAFLUSH are honored and than only have one
> place for OPOST handling?
...and additionally don't have to maintain yet another handle.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-04-16 9:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 12:40 Takashi Yano
2015-02-28 13:16 ` Denis Excoffier
2015-02-28 17:56 ` Corinna Vinschen
2015-03-02 11:45 ` Takashi Yano
2015-03-02 14:44 ` Corinna Vinschen
2015-03-02 14:50 ` Corinna Vinschen
2015-03-04 11:36 ` Takashi Yano
2015-03-04 12:43 ` Corinna Vinschen
2015-03-04 18:22 ` Corinna Vinschen
2015-03-04 20:25 ` Corinna Vinschen
2015-03-05 12:12 ` Takashi Yano
2015-03-05 13:31 ` Corinna Vinschen
2015-04-03 4:07 ` Takashi Yano
2015-04-03 4:19 ` Takashi Yano
2015-04-03 11:32 ` Corinna Vinschen
2015-04-04 6:55 ` Takashi Yano
2015-04-04 8:43 ` Corinna Vinschen
2015-04-05 11:54 ` Takashi Yano
2015-04-07 9:11 ` Corinna Vinschen
2015-04-13 10:31 ` Takashi Yano
2015-04-14 7:35 ` Corinna Vinschen
2015-04-16 0:26 ` Takashi Yano
2015-04-16 9:05 ` Corinna Vinschen
2015-04-16 9:10 ` Corinna Vinschen [this message]
2015-04-17 11:27 ` Takashi Yano
2015-04-17 12:10 ` Corinna Vinschen
2015-04-17 12:25 ` Corinna Vinschen
2015-04-20 11:40 ` Takashi Yano
2015-04-20 15:12 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150416091004.GA24584@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).