public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Cc: JonY <10walls@gmail.com>
Subject: Re: wspiapi.h uses _N conflicting with ctype.h
Date: Mon, 03 Aug 2015 13:46:00 -0000	[thread overview]
Message-ID: <20150803134602.GC18434@calimero.vinschen.de> (raw)
In-Reply-To: <CAOC2fq-Gsqj3zZa-X+w_jHDdob0bO0iUSVk--PoGoj-YaiyQ4Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

On Aug  3 04:17, Michael Enright wrote:
> Here's a reduction of a problem I had compiling v8:
> 
> #include <ctype.h>
> #include "wspiapi.h"
> char array[5];
> __wspiapi_countof_helper(array);
> 
> The reduction isn't realistic but the problem is real.
> 
> On one hand, ctype.h uses _N and it is within its "rights" to do so as
> ctype.h is part of the standard library. The statement that uses _N
> initially is "#define _N 04", so _N enters the global space of defined
> macros.
> 
> On the other hand the template __wspiapi_countof_helper uses _N as the
> name of one of its parameters. This usage is in the domain of strings
> that can be interpreted as references to macros by the preprocessor,
> so the _N gets interpreted by the post-preprocessor phases as 04,
> causing some distress.
> 
> So... the win32 headers are free to use
> leading-underscore-capital-letter symbols or no?

It's unfortunate, but with their right, just like the std headers.

> Anyway, how can this be addressed?

The best result would be if you (or we) could convince the mingw-w64
guys not to use _N.  Jon?  Any chance you could apply a patch to use
_n with lower case n?

For the time being, you can push/pop the clashing macros prior to
including the problematic header(s):

  #include <ctype.h>
  #pragma push_macro ("_N")
  #undef _N
  #include <wspiapi.h>
  #pragma pop_macro("_N")


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-08-03 13:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03 11:17 Michael Enright
2015-08-03 13:46 ` Corinna Vinschen [this message]
2015-08-03 22:45   ` JonY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150803134602.GC18434@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=10walls@gmail.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).