public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: Group Permissions on root folders problem (Windows 10 TP build 10061)
Date: Thu, 10 Sep 2015 17:49:00 -0000	[thread overview]
Message-ID: <20150910174933.GE26699@calimero.vinschen.de> (raw)
In-Reply-To: <55F1BF8A.2050907@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1725 bytes --]

On Sep 10 11:36, Eric Blake wrote:
> On 09/10/2015 11:31 AM, Corinna Vinschen wrote:
> 
> >>>> -      if [ "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" ]
> >>>> +      if [ "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" \
> >>>> +	   -a "${LOGONSERVER}" != "\\\\MicrosoftAccount" ]
> >>>>        then
> >>>>  	# Lowercase of USERDOMAIN
> >>>>        	csih_PRIVILEGED_USERNAME="${COMPUTERNAME,,*}+${username}"
> >>>
> >>> Thanks a lot, much appreciated.  Patch applied.
> >>
> >> [ ... -a ... ] is not portable; there are some inherently ambiguous
> >> situations that it cannot handle. POSIX recommends that you spell it [
> >> ... ] && [ ... ] instead.
> > 
> > Does this matter in this very situation?  This is always running under
> > bash, btw.  Bash's a requirement for the csih helper script.
> 
> Because you are at least using bash, you will get consistent behavior;
> and because both ... are 3-argument tests, it is unlikely that one of
> the tests can be confused with other operators like '(' or ')'.  So, I
> guess it's okay to leave it alone here.  But even with bash, the use of
> -a can cause problems when testing user-supplied variables that might
> happen to expand to text that looks like potential operators.

Feel free to change that in the csih repo.  Csih is under git now,
see https://sourceware.org/git/?p=cygwin-csih.git.  You're in the
cygwin-apps group, so you have checkin rights.

If I didn't mention that before, I'm glad for any help since I only took
over because Chuck disappeared.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-09-10 17:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAMH9mcFEL3mao+m-DEYM84kC1HOPeSBpZXD+mDf0USobF9oY7g@mail.gmail.com>
2015-06-16 13:23 ` Brian Buchanan
2015-06-16 15:58   ` Corinna Vinschen
2015-09-05  6:59     ` Takashi Yano
2015-09-06 11:44       ` Corinna Vinschen
2015-09-10 11:05         ` Takashi Yano
2015-09-10 17:23           ` Corinna Vinschen
2015-09-10 17:27             ` Eric Blake
2015-09-10 17:31               ` Corinna Vinschen
2015-09-10 17:36                 ` Eric Blake
2015-09-10 17:49                   ` Corinna Vinschen [this message]
2015-09-11  0:50                   ` Andrey Repin
2015-09-11  1:24                     ` Eric Blake
2015-09-11  2:05                       ` Andrey Repin
2015-09-11 10:04         ` Takashi Yano
2015-09-11 11:10           ` Corinna Vinschen
2015-09-11 12:33             ` Takashi Yano
2015-09-11 15:18               ` Corinna Vinschen
     [not found]     ` <DJzl1r0012qVqVd01Jzm3c>
2015-09-10 15:49       ` David A Cobb
2015-09-10 16:07         ` Ken Brown
2015-09-10 17:29           ` Corinna Vinschen
     [not found]         ` <FU891r01R2qVqVd01U8Bkq>
2015-09-10 20:41           ` David A Cobb
2015-04-29 14:45 Brian Buchanan
2015-04-30  8:24 ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150910174933.GE26699@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).