From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: Bash unable to print epoch timestamp
Date: Thu, 29 Oct 2015 08:19:00 -0000 [thread overview]
Message-ID: <20151029074151.GC5319@calimero.vinschen.de> (raw)
In-Reply-To: <loom.20151028T180008-140@post.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1786 bytes --]
On Oct 28 17:20, Brian Inglis wrote:
> Corinna Vinschen <corinna-cygwin <at> cygwin.com> writes:
> > On Oct 26 19:16, Brian Inglis wrote:
> > > Sorry - redo with the file existing!
> >
> > No worries, I applied your other patch since it also cleaned up some
> > whitespaces and, for some reason, the below patch didn't apply cleanly.
>
> Email paste may have converted tabs to spaces - need to work out how to
> email inline text attachments without tab expansion in tbird - paste on
> gmane (below) seems to retain tabs - may try that in future.
>
> > There was just one problem:
> >
> > > + {
> > > + long offset; /* offset < 0 => W of GMT, > 0 => E of GMT:
> > > + offset = 0; subtract to get UTC */
> >
> > This setting the offset to 0 is necessary, but commented out. Typo?
> > I fixed this before committing the patch.
>
> Thanks - total brain fart - Doh! Interesting that gcc -Wall -Wextra did not
> catch this - used to be reliable warning about conditionally uninitialized
> variables!
>
> Please check that the second set of tests in Vec1 includes the following, as
> it was not in my very first patch email, which you may not have received:
> @@ -1502,6 +1575,7 @@ const struct test Vec1[] = {
> { CQ("%p"), 2+1, EXP(CQ("PM")) },
> { CQ("%r"), 11+1, EXP(CQ("11:01:13 PM")) },
> { CQ("%R"), 5+1, EXP(CQ("23:01")) },
> + { CQ("%s"), 2+1, EXP(CQ("1215054073")) },
> { CQ("%S"), 2+1, EXP(CQ("13")) },
> { CQ("%t"), 1+1, EXP(CQ("\t")) },
> { CQ("%T"), 8+1, EXP(CQ("23:01:13")) },
Check. This was in your patch so it's upstream now.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-29 7:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <562A996C.9070904@SystematicSw.ab.ca>
2015-10-26 19:54 ` Brian Inglis
2015-10-26 20:22 ` Brian Inglis
2015-10-27 9:27 ` Brian Inglis
2015-10-27 9:28 ` Brian Inglis
2015-10-27 9:54 ` Corinna Vinschen
2015-10-29 2:50 ` Brian Inglis
2015-10-29 8:19 ` Corinna Vinschen [this message]
2015-10-22 7:04 Brian Inglis
2015-10-22 8:46 ` Brian Inglis
2015-10-22 10:29 ` Corinna Vinschen
2015-10-26 10:50 ` Corinna Vinschen
2015-10-26 23:11 ` Brian Inglis
-- strict thread matches above, loose matches on Subject: below --
2015-10-21 12:25 chere 1.4 bug(?) - "Bash Prompt Here" not shown under Libraries folders cpengr
2015-10-21 16:51 ` Achim Gratz
2015-10-21 18:01 ` cpengr
2015-10-21 18:05 ` Bash unable to print epoch timestamp Don Harrop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151029074151.GC5319@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).