public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.3.0-0.6
Date: Thu, 05 Nov 2015 17:55:00 -0000	[thread overview]
Message-ID: <20151105175546.GB20857@calimero.vinschen.de> (raw)
In-Reply-To: <20151105092448.GC18221@calimero.vinschen.de>

[-- Attachment #1: Type: text/plain, Size: 2149 bytes --]

On Nov  5 10:24, Corinna Vinschen wrote:
> On Nov  4 22:25, Achim Gratz wrote:
> > Achim Gratz writes:
> > > Just confirmed this on another system.  If I kill the child, then the
> > > parent resumes and finishes the test loop alright and it can be
> > > interrupted again from the shell.  The hang happens after the first test
> > > succeeds in both the parent and child.
> > 
> > I have just managed to kill the parent (returning the shell prompt) and
> > have the child complete the test loop output to the terminal.  So I
> > guess the communication ping-pong is somehow buggered up so that pipes
> > start blocking.
> 
> Staring into the latest version of my new function to remove pending
> signals, after having some *more* coffee, it seems pretty clear I
> screwed this up nicely.
> 
> What I was missing all the time was to iterate over the list of pending
> signals if there's a pending signal which doesn't have to be cleared.
> This case was just missing.  Duh!  I guess I didn't really cover myself
> in glory here...
> 
> I applied yet another patch and uploaded a new developer snapshot
> (this time *with* the ACL changes) to https://cygwin.com/snapshots/
> 
> Can you please give it a try ASAP?

For the records, I got a testcase from Achim to reproduce the issue
which, incidentally, is still present in that snapshot.  It turned out
that the problem Achim was reporting has nothing to do with the new code
clearing pending signals.  It was a completely different bug, which just
showed another behaviour due to the signal change.

In fact what happened was a deadlock when parent and child process
were industriously trying to lock a file using flock(2).  This must
have been present for a long time, in fact.

I (hopefully) fixed the issue and uploaded yet another developer
snapshot to https://cygwin.com/snapshots/ (with ACL changes again).

New test release follows soon.

Achim, thanks for the report and the testcase.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-11-05 17:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04  9:42 Corinna Vinschen
2015-11-04 18:36 ` Achim Gratz
2015-11-04 21:07   ` Achim Gratz
2015-11-04 21:26     ` Achim Gratz
2015-11-05  9:24       ` Corinna Vinschen
2015-11-05 17:55         ` Corinna Vinschen [this message]
2015-11-05 17:58           ` Corinna Vinschen
2015-11-05 19:19             ` Achim Gratz
2015-11-06  0:28               ` Jan Bruun Andersen
2015-11-06  8:48                 ` Corinna Vinschen
2015-11-06 17:30                   ` Jan Bruun Andersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151105175546.GB20857@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).