From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60727 invoked by alias); 23 Nov 2015 22:31:25 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 60712 invoked by uid 89); 23 Nov 2015 22:31:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wm0-f41.google.com Received: from mail-wm0-f41.google.com (HELO mail-wm0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 23 Nov 2015 22:31:23 +0000 Received: by wmww144 with SMTP id w144so2422731wmw.0 for ; Mon, 23 Nov 2015 14:31:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=So1sBc7mdlshhF7hzWCjkoeU+Hv1cGwstt7SCiARrp4=; b=NPsl7RTt12lGN6O2GxFwvy0CW5XvGsNMinIKsbx3Y9Ri1P6z+DZKJKXybvr1yf7fR+ PwXn6kx4XGZV4g3nBHm70/1ZeVU/q6XM60aOBwaIOIlUJIkys70mYYmmRKog02b1opu+ zntRAWMDg2bf3Kw1o2IXS1MXLSY/qDqD9fHMOpz6j1JkbqR7lWwe5WuFyBtgLK16eSVn x0LLJcNV3PbonVTPECTxYr7NPagmCY/I6lMaG2IxE/OQpnzaS+QqrKiLhILquUEXySnn wiwXkEccWMfSeX4+PivjJoggE4mZQ/1u1c/N2jMp/XWkPKM6Qz/R8kEMti4GXYnjdoB9 v5Ww== X-Gm-Message-State: ALoCoQn3dQa7amIZtwzZeFpDNk517Fj/0cdClyBoMd70ilJ3lr83FJwFUW8eKfEixGntX2kQKi3s X-Received: by 10.28.24.199 with SMTP id 190mr22809821wmy.101.1448317880177; Mon, 23 Nov 2015 14:31:20 -0800 (PST) Received: from dinwoodie.org ([2001:ba8:0:1c0::9:1]) by smtp.gmail.com with ESMTPSA id jt9sm15361980wjc.24.2015.11.23.14.31.19 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 23 Nov 2015 14:31:19 -0800 (PST) Date: Mon, 23 Nov 2015 22:40:00 -0000 From: Adam Dinwoodie To: cygwin@cygwin.com Subject: Re: Https proxy auth issue with git in cygwin 2.2.1 Message-ID: <20151123223117.GB14466@dinwoodie.org> References: <20150921103100.GF14466@dinwoodie.org> <20151005202249.GM14466@dinwoodie.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00371.txt.bz2 On Fri, Oct 16, 2015 at 12:26:14PM +0000, Johan Laenen wrote: > Adam Dinwoodie dinwoodie.org> writes: > > > I think I've found the problem, and you're right -- Git has changed the > > way it makes the curl call. The culprit is commit 5841520b in the > > upstream Git repository, which has the following commit message: > > > > | http: always use any proxy auth method available > > | > > | We set CURLOPT_PROXYAUTH to use the most secure authentication > > | method available only when the user has set configuration variables > > | to specify a proxy. However, libcurl also supports specifying a > > | proxy through environment variables. In that case libcurl defaults > > | to only using the Basic proxy authentication method, because we do > > | not use CURLOPT_PROXYAUTH. > > | > > | Set CURLOPT_PROXYAUTH to always use the most secure authentication > > | method available, even when there is no git configuration telling us > > | to use a proxy. This allows the user to use environment variables to > > | configure a proxy that requires an authentication method different > > | from Basic. > > > > I can't confirm this is the problem, though, as I don't have a test > > environment that uses NTLM. > > > > Do you have the ability to either run a test version of Git I can > > produce that patches out this change, or (better) to build Git yourself > > without this patch to see if that is indeed the change that's causing > > the problem? > > > > Hi There, > > I can into the exact same problem after upgrading to the latest cygwin version. > > So, following your advice, I took git-2.6.1.tar.gz from github, untarred, > and modified http.c: > > $ diff git-2.6.1/http.c t/git-2.6.1/http.c > 466,467c466,468 > < if (curl_http_proxy) { > < curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy); > --- > > if (curl_http_proxy) { > > curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy); > > } > 469c470 > < curl_easy_setopt(result, CURLOPT_PROXYAUTH, CURLAUTH_ANY); > --- > > curl_easy_setopt(result, CURLOPT_PROXYAUTH, CURLAUTH_ANY); > 471d471 > < } > > One make configure, ./configure, make and make install I can confirm that > unpatching the change undoes the problem :) Hi Johan, I've just spotted this email while trawling through other Cygwin/Git related things; somehow I missed it when it was first sent. I see you've raised this on the upstream Git mailing list already, and there's been some useful discussion there, so I'm not proposing any further discussion on this list. I just wanted to reply with my Git maintainer hat on and acknowledge the discussion has moved upstream. Cheers, Adam -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple