From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4261 invoked by alias); 7 Jan 2016 14:43:51 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 4246 invoked by uid 89); 7 Jan 2016 14:43:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-101.9 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,KHOP_DYNAMIC,RCVD_IN_PBL,RDNS_DYNAMIC,USER_IN_WHITELIST autolearn=no version=3.3.2 spammy=corinna, Vinschen, vinschen, Maintainer X-HELO: calimero.vinschen.de Received: from ipbcc02fe8.dynamic.kabel-deutschland.de (HELO calimero.vinschen.de) (188.192.47.232) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Jan 2016 14:43:49 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id AE7F9A80460; Thu, 7 Jan 2016 15:43:47 +0100 (CET) Date: Thu, 07 Jan 2016 14:43:00 -0000 From: Corinna Vinschen To: cygwin@cygwin.com Subject: Re: Issues in utmp/utmpx headers Message-ID: <20160107144347.GD20447@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NklN7DEeGtkPCoo3" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2016-01/txt/msg00060.txt.bz2 --NklN7DEeGtkPCoo3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1623 On Dec 29 05:16, Brian Inglis wrote: > > > David Lee gmail.com> writes: > > >> While trying to port bsdgames to Cygwin I spotted the following issu= es: > > >> (1) In /usr/include/utmpx.h, utmpxname() is declared a void function. > > >> Should it return int? > > >> (2) In /usr/include/sys/utmp.h, utmpname() is declared a void > > >> function. Should it return int? > > >> (3) _PATH_UTMPX is not defined in any system headers. >=20 > > On 28 December 2015 at 03:02, Brian Inglis > > systematicsw.ab.ca> wrote: > > > Search packages for missing files e.g. > > > https://cygwin.com/cgi-bin2/package-grep.cgi?grep=3Dutmp.h&arch=3Dx86= _64 > > > brings up package cygwin-devel and cygwin32. > > > Download and run setup and select cygwin-devel to install the headers= and > > > libraries. >=20 > David Lee gmail.com> writes: > > The issue isn't missing, not-installed packages. The issues are (1) > > some function declaration seem wrong; and (2) a constant is missing. >=20 > Pardon my reading comprehension bork!=20 >=20 > The utmpname implementation in newlib-cygwin/winsup/cygwin/syscalls.cc > could probably be improved to: avoid a memory leak; return -1 if=20 > strdup fails, zero otherwise; This function is supposed to be called only once, so is it worth the additional effort? > default the path if a null pointer or string > argument is passed.=20 The function now returns int and -1 if path is invalid. Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --NklN7DEeGtkPCoo3 Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWjnmjAAoJEPU2Bp2uRE+g/8cP/1x+zyTJ7RsbxSSv6w0eMlEl UnGlDx/ToALW7gMYRvdANByXqJWgotf49ALj9s3GoE8rjzy9jztCm4XrdeOQ9P08 AQrzMAJM5fxHEhpa3flvV/OYZbHk9uQ2C48zY3zpmtneGYSPMyPNsbR9jFdpxFsH dt8+Y3v0rnXfj6/pDUdemVcm+pAwZ/AfU/bKd3+z7/KzlBVRJgJ8RlvW9ijknqXd +ZE5n4BlWpMTyOWJlGrtuTAQZW1elrz/YhBglYrJ1BmHRYxnmYQVREhhWywWXX+e pVDtmMdFySoDDpsu1+HkfB4Q1IPHytw3+2GsH59ynaguwb+42qHhWfQ5zUrhQcRT bNB9+tXsBbn9rrL4CRbxuUtPiGXCzY5+waDh6wvMVTy9icD1EMlPrYja3TDk+MwJ onWK238O/TTVTRS6AgBUsfeeV1sRB+E0j5SJ7F2fzFBBX0WJIEWtzCfMcbsXOCCz xRYG8fFV7p5+CgbK3TUxB7YmRR/HZjPnltoZ9N9vQOeLnNh4aI3MzPCOa+sK3PJ8 HDTQGzlkWvtCt9UhTMw69SqEGiH9wgDKt7QGb5KYJGYJHFYE+oPQhbwhq97Pn4Zd zS+p5oDWg7u4F0zIxywyJYkt+Rc5wPzOdsz1hXa9tbLU1ceal3/CQbSU2wo5rUHn CsaVVeWBDqE3YGcD0Vyc =VVNG -----END PGP SIGNATURE----- --NklN7DEeGtkPCoo3--