From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17133 invoked by alias); 8 Feb 2016 14:10:19 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 17120 invoked by uid 89); 8 Feb 2016 14:10:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-94.7 required=5.0 tests=BAYES_20,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_PBL,RDNS_DYNAMIC,USER_IN_WHITELIST autolearn=no version=3.3.2 spammy=H*R:D*cygwin.com, H*R:U*cygwin, H*MI:sk:kJY-wz0, H*f:CAFo71_5 X-HELO: calimero.vinschen.de Received: from ipbcc0d020.dynamic.kabel-deutschland.de (HELO calimero.vinschen.de) (188.192.208.32) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Feb 2016 14:10:17 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 86D0FA804E5; Mon, 8 Feb 2016 15:10:15 +0100 (CET) Date: Mon, 08 Feb 2016 14:10:00 -0000 From: Corinna Vinschen To: cygwin@cygwin.com Subject: Re: Problem with new acl code and cdrtools Message-ID: <20160208141015.GD12975@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <20160208131835.GC12975@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2iBwrppp/7QCDedR" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2016-02/txt/msg00075.txt.bz2 --2iBwrppp/7QCDedR Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1526 On Feb 8 15:31, Ismail Donmez wrote: > On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen > wrote: > > On Feb 8 12:01, Ismail Donmez wrote: > >> Hi, > >> > >> cdrtools has some code to detect Solaris style ACLs: > >> > >> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \ > >> defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT) > >> # define HAVE_SUN_ACL 1 /* Sun UFS ACL's present */ > >> #endif > >> > >> Since cygwin still seems to be defining aclfromtext() and acltotext() > >> functions (which are not defined in POSIX) cdrtools thinks this a > >> Solaris-style system and get up getting a compile error later on. > > > > Probably due to including sys/acl.h. Does swtiching to cygwin/acl.h > > help? Or changing the above check to prefer POSIX ACLs over Solaris > > ACLs? >=20 > This is a generic code so I don't want to add a cygwin specific > dependency there. Is there a preprocessor definition for cygwin > version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+ If you include cygwin/version.h you could use the version definitions. Alternatively we could allow to use the Solaris ACL functions even if only including sys/acl.h, given some macro: sys/acl.h: #ifdef __USE_OLD_SOLARIS_ACL_FUNCTIONS # include #else [...POSIX definitions...] #endif Would that help? Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --2iBwrppp/7QCDedR Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWuKHHAAoJEPU2Bp2uRE+gUkYP/2AH6ym+zdp9qIqe4TaLNGfE 9LRTWbg370dK5TUFS/pABzCzqEJfMsP/TA5ua4XmpOEnj9PWk5bE6tVDoaCCd2dA xTFjfv6h7XAI+3ynJSMK7zrpR0IU1nIi4aOSXKQT+5TCcPCod+BEOwOLMfWUn7CI nWVnw/THrSnYjVI8siXVGERsxBDd2dErf9iiCEHxfOkyyKhT0n+4+50fvn/ia8ci nuzUviIbnAQqqR3GPpnlp5U8ADQjC6F3O5M414pM7OXM7nD3BJ6zksEijuLiYWBa oIHMmgHnl319PYU8H3qPGwu1zdxp78znYyF7fOjHxdRiZ26YlfxsNqN9dmUy0+DJ 4x3G3QjEMsNS0dKzXjFQ3WqsKaaEGLGoA8MJDyl9rfWV9opVs/0//JwOJhLtLjR0 AstxVNlnqFS9EfiqSzAOrvMpWM38/zjpscikZALGFDbFE2US1DQAz6fPNU0uyk3F nYu/WT02X22NXfhWEtJTAX2K9UanPKXhjiv9BQj/BWbvUUwgsHKM47v9ETrnrBhg Y/rEvJGjxmS+GIw302yeef39qKr2G5WuQLilJXCxIlIJO32rqeyFkZwnznpM1Yyv G0jFoooVSs42DlOQypJSt3Zt5nLdYUA1X724FzY91UdZXMaQc6lGV/8VoKczhrAB t+n39hz2iuIsrA/ZvcPe =RkMk -----END PGP SIGNATURE----- --2iBwrppp/7QCDedR--