From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110160 invoked by alias); 8 Feb 2016 14:36:34 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 110146 invoked by uid 89); 8 Feb 2016 14:36:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-94.7 required=5.0 tests=BAYES_40,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_PBL,RDNS_DYNAMIC,USER_IN_WHITELIST autolearn=no version=3.3.2 spammy=H*R:D*cygwin.com, H*R:U*cygwin, Hx-languages-length:1892, H*f:CAFo71_57DCPp X-HELO: calimero.vinschen.de Received: from ipbcc0d020.dynamic.kabel-deutschland.de (HELO calimero.vinschen.de) (188.192.208.32) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Feb 2016 14:36:32 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 5ADE7A804E5; Mon, 8 Feb 2016 15:36:30 +0100 (CET) Date: Mon, 08 Feb 2016 14:36:00 -0000 From: Corinna Vinschen To: cygwin@cygwin.com Subject: Re: Problem with new acl code and cdrtools Message-ID: <20160208143630.GG12975@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <20160208131835.GC12975@calimero.vinschen.de> <20160208141015.GD12975@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oOB74oR0WcNeq9Zb" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2016-02/txt/msg00079.txt.bz2 --oOB74oR0WcNeq9Zb Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1931 On Feb 8 16:13, Ismail Donmez wrote: > On Mon, Feb 8, 2016 at 4:10 PM, Corinna Vinschen > wrote: > > On Feb 8 15:31, Ismail Donmez wrote: > >> On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen > >> wrote: > >> > On Feb 8 12:01, Ismail Donmez wrote: > >> >> Hi, > >> >> > >> >> cdrtools has some code to detect Solaris style ACLs: > >> >> > >> >> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \ > >> >> defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT) > >> >> # define HAVE_SUN_ACL 1 /* Sun UFS ACL's present */ > >> >> #endif > >> >> > >> >> Since cygwin still seems to be defining aclfromtext() and acltotext= () > >> >> functions (which are not defined in POSIX) cdrtools thinks this a > >> >> Solaris-style system and get up getting a compile error later on. > >> > > >> > Probably due to including sys/acl.h. Does swtiching to cygwin/acl.h > >> > help? Or changing the above check to prefer POSIX ACLs over Solaris > >> > ACLs? > >> > >> This is a generic code so I don't want to add a cygwin specific > >> dependency there. Is there a preprocessor definition for cygwin > >> version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+ > > > > If you include cygwin/version.h you could use the version definitions. > > > > Alternatively we could allow to use the Solaris ACL functions even if > > only including sys/acl.h, given some macro: > > > > sys/acl.h: > > > > #ifdef __USE_OLD_SOLARIS_ACL_FUNCTIONS > > # include > > #else > > [...POSIX definitions...] > > #endif > > > > Would that help? >=20 > That should help, I cook a patch and send to cdrecord maintainer. Wait, that's a bit premature. I'm not even sure yet if the macro name is ok. Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --oOB74oR0WcNeq9Zb Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWuKfuAAoJEPU2Bp2uRE+ghQsP/1LGrIPpghyob4SRNy/WRXsX Zg6yFOnVJvyNhI4Se3nuxzST4+862i+mMshxvPS34u+Oaxcz3Kj+slAcXpivtaAt 97mznfHYMjhYpTBRrc7zgSDBwcps82TgsiKV6q4bAePt0iprLXieHJgC2rRYPlEK IPoZGQfsatU5tXtpORmw+Xgkb3R4pK1Feh+notN+zlFUiIHu8Y2RdgC3TEj9gPnU uhiQTy7Oc/rVxS2xIomJBaHA1Htw9TjhGg/wr9GgVKXdJ9z0hO0v9PgzoSv6UX/H uJkiVrYXjkeqeduiqekX+IRc7QbqoOL9oP9XeabUVIHMck5SMVLQd6KEfnyhoSxp qBndgeE3rF4sQwN/CCqrQ3rqbmBHylRrhL5R6NtG0/1d6TZuxPnocUZh3SPYdoGb I0yYRGd9tiWtMrzV9Q2RVBW/KV1wh8ktF+IEfKj590SWHvvZMT8vkMOlatGUpwS1 /qixgHZofU2F0B8F3Z1Pb/MZy15SnWct9WbX+jkzpyDEUi9GViMAGKAuxrKpx49I yC/tyvZrH6sHI4LT5sHznXcyE12dlj7oiYk14INlvA7fGxiDrFuBwY8wltI6ZfNu rcHbQ5wADgzwa0jqhGBnbSk2/xZ7UIIx6BrSFOOTS3krP6pD+yq+Wkdxa1h7RVVf GuO4cvhEbH5oMJaIMADS =teve -----END PGP SIGNATURE----- --oOB74oR0WcNeq9Zb--