public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: Problem with line buffering and getc function on 1.7.33.
Date: Sat, 12 Mar 2016 22:29:00 -0000	[thread overview]
Message-ID: <20160312222921.GD3567@calimero.vinschen.de> (raw)
In-Reply-To: <20160312193946.GB3567@calimero.vinschen.de>

[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]

On Mar 12 20:39, Corinna Vinschen wrote:
> On Mar 11 16:05, Kaz Kylheku wrote:
> > We can reproduce the problem with just file streams using
> > a much simpler program:
> > 
> > #include <stdio.h>
> > 
> > int main(void)
> > {
> >   FILE *out = fopen("file", "w+");
> >   setvbuf(out, (char *) NULL, _IOLBF, 0);
> >   getc(out);
> >   clearerr(out);
> >   fseek(out, 0, SEEK_SET);
> >   putc('a', out);
> >   putc('b', out);
> >   putc('c', out);
> >   putc('d', out);
> >   putc('e', out);
> >   putc('\n', out);
> >   fclose(out);
> >   return 0;
> > }
> > 
> > The contents of file end up being "\n": one empty
> > line, instead of "abcde\n":
> > 
> >   $ cat file
> > 
> >   $
> 
> Thanks for the testcase.  I can reproduce the issue and I see where the
> problem occurs, but I'm still puzzled.  Comparing the code in our newlib
> C library with its BSD counterparts, I could swear the same behaviour
> happens on OpenBSD as well.  If not (which needs testing), I wonder why
> and where newlib's actually different.  Right now I don't see the
> difference.

I do now.  Basically it's setvbuf screwing up the internal flags in the
FILE structure.  I took the liberty to update newlib's setvbuf to the
OpenBSD version locally and I'm going to apply my patches to newlib
soon.  I'll provide a new 2.5.0 test release of Cygwin with this patch
tomorrow or early next week.


Thanks again for the testcase,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-03-12 22:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 21:57 Kaz Kylheku
2016-03-11 22:14 ` Marco Atzeri
2016-03-12  0:05   ` Kaz Kylheku
2016-03-12 19:39     ` Corinna Vinschen
2016-03-12 22:29       ` Corinna Vinschen [this message]
2016-03-13  0:37         ` Kaz Kylheku
2016-03-13 10:47           ` Corinna Vinschen
2016-03-13  0:41         ` Kaz Kylheku
2016-03-13 11:06           ` Corinna Vinschen
2016-03-13 11:37             ` Corinna Vinschen
  -- strict thread matches above, loose matches on Subject: below --
2016-03-11 19:17 Kaz Kylheku
2016-03-11 20:09 ` Yaakov Selkowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160312222921.GD3567@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).