[ANNOUNCEMENT] TEST RELEASE: Cygwin 2.6.0-0.3

[ANNOUNCEMENT] TEST RELEASE: Cygwin 2.6.0-0.3

[Corinna Vinschen]

Hi Cygwin developers and maintainers,
Hi everyone else,


I uploaded a new Cygwin test release 2.6.0-0.3.

Supposed to fix the problems reported in
https://cygwin.com/ml/cygwin/2016-07/msg00306.html and
https://cygwin.com/ml/cygwin/2016-07/msg00308.html.

=======================================================================

For those building Cygwin from source, the new code is only available
in the topic/locales branch yet.

=======================================================================

The 2.6.0 release is going to introducing the locale_t datatype, as well
as all functions related to locale_t locales and per-thread locales per
POSIX-1.2008.

So, rather than just providing a single, per-process locale, you can now
create new locales ("newlocale") and set it as locale for the current
thread ("uselocale") or use it directly with one of the new functions
taking a locale_t as parameter (i.e. isalpha_l).

The full list of new interfaces is:

  newlocale, freelocale, duplocale, uselocale

  isalnum_l, isalpha_l, isascii_l, isblank_l, iscntrl_l, isdigit_l,
  isgraph_l, islower_l, isprint_l, ispunct_l, isspace_l, isupper_l,
  iswalnum_l, iswalpha_l, iswblank_l, iswcntrl_l, iswctype_l,
  iswdigit_l, iswgraph_l, iswlower_l, iswprint_l, iswpunct_l,
  iswspace_l, iswupper_l, iswxdigit_l, isxdigit_l
  
  toascii_l, tolower_l, toupper_l, towctrans_l, towlower_l, towupper_l,
  wctrans_l, wctype_l

  strcasecmp_l, strcoll_l, strncasecmp_l, strxfrm_l

  wcscasecmp_l, wcscoll_l, wcstrncasecmp_l, wcstrxfrm_l

  strfmon_l, strftime_l

=======================================================================

Since this is brand-new code, this code *will* have bugs.

It would be very helpful if interested developers and Cygwin package
maintainers could give this new stuff some good testing.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.6.0-0.3

[Ken Brown]

On 7/27/2016 8:36 AM, Corinna Vinschen wrote:
> Hi Cygwin developers and maintainers,
> Hi everyone else,
>
>
> I uploaded a new Cygwin test release 2.6.0-0.3.
>
> Supposed to fix the problems reported in
> https://cygwin.com/ml/cygwin/2016-07/msg00306.html

This is now fixed.  Here's another problem, with a very easy test case:

$ locale -a
Segmentation fault (core dumped)

Ken

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.6.0-0.3

[Denis Excoffier]

> On 2016-07-27 14:36, Corinna Vinschen wrote:
> 
> Hi Cygwin developers and maintainers,
> Hi everyone else,
> 
> 
> I uploaded a new Cygwin test release 2.6.0-0.3.
> 
> Supposed to fix the problems reported in
> https://cygwin.com/ml/cygwin/2016-07/msg00306.html and
> https://cygwin.com/ml/cygwin/2016-07/msg00308.html.
It does fix the 2nd problem. Thanks Corinna.

I also have the

% locale -a
Segmentation fault (core dumped)
%

Denis Excoffier.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.6.0-0.3

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

On Jul 27 10:58, Ken Brown wrote:
> On 7/27/2016 8:36 AM, Corinna Vinschen wrote:
> > Hi Cygwin developers and maintainers,
> > Hi everyone else,
> > 
> > 
> > I uploaded a new Cygwin test release 2.6.0-0.3.
> > 
> > Supposed to fix the problems reported in
> > https://cygwin.com/ml/cygwin/2016-07/msg00306.html
> 
> This is now fixed.  Here's another problem, with a very easy test case:
> 
> $ locale -a
> Segmentation fault (core dumped)

Confirmed.  I missed to set a variable in case of the "th_TH.TIS-620"
locale or the "thai" locale alias.  I'll build a 0.4 tomorrow.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.6.0-0.3

[Ken Brown]

On 7/27/2016 4:33 PM, Corinna Vinschen wrote:
> On Jul 27 10:58, Ken Brown wrote:
>> On 7/27/2016 8:36 AM, Corinna Vinschen wrote:
>>> Hi Cygwin developers and maintainers,
>>> Hi everyone else,
>>>
>>>
>>> I uploaded a new Cygwin test release 2.6.0-0.3.
>>>
>>> Supposed to fix the problems reported in
>>> https://cygwin.com/ml/cygwin/2016-07/msg00306.html
>>
>> This is now fixed.  Here's another problem, with a very easy test case:
>>
>> $ locale -a
>> Segmentation fault (core dumped)
> 
> Confirmed.  I missed to set a variable in case of the "th_TH.TIS-620"
> locale or the "thai" locale alias.  I'll build a 0.4 tomorrow.

This is fixed in 0.4, and that's the last of the regressions that I've found by running the emacs test suite.

I built and tested texlive with no problem.

I also tried to build icu, but there are some glitches due to the new POSIX guard in /usr/include/locale.h.  For example:

$ cat setlocale_test.cc
#include <istream>

$ g++ -c setlocale_test.cc --std=c++0x
In file included from /usr/lib/gcc/x86_64-pc-cygwin/5.4.0/include/c++/x86_64-pc-cygwin/bits/c++locale.h:41:0,
                 from /usr/lib/gcc/x86_64-pc-cygwin/5.4.0/include/c++/bits/localefwd.h:40,
                 from /usr/lib/gcc/x86_64-pc-cygwin/5.4.0/include/c++/ios:41,
                 from /usr/lib/gcc/x86_64-pc-cygwin/5.4.0/include/c++/istream:38,
                 from setlocale_test.cc:1:
/usr/lib/gcc/x86_64-pc-cygwin/5.4.0/include/c++/clocale:54:11: error: ‘::setlocale’ has not been declared
   using ::setlocale;
           ^
/usr/lib/gcc/x86_64-pc-cygwin/5.4.0/include/c++/clocale:55:11: error: ‘::localeconv’ has not been declared
   using ::localeconv;
           ^
In file included from /usr/lib/gcc/x86_64-pc-cygwin/5.4.0/include/c++/bits/localefwd.h:40:0,
                 from /usr/lib/gcc/x86_64-pc-cygwin/5.4.0/include/c++/ios:41,
                 from /usr/lib/gcc/x86_64-pc-cygwin/5.4.0/include/c++/istream:38,
                 from setlocale_test.cc:1:
/usr/lib/gcc/x86_64-pc-cygwin/5.4.0/include/c++/x86_64-pc-cygwin/bits/c++locale.h: In function ‘int std::__convert_from_v(int* const&, char*, int, const char*, ...)’:
/usr/lib/gcc/x86_64-pc-cygwin/5.4.0/include/c++/x86_64-pc-cygwin/bits/c++locale.h:60:19: error: ‘setlocale’ is not a member of ‘std’
     char* __old = std::setlocale(LC_NUMERIC, 0);
                   ^
/usr/lib/gcc/x86_64-pc-cygwin/5.4.0/include/c++/x86_64-pc-cygwin/bits/c++locale.h:67:2: error: ‘setlocale’ is not a member of ‘std’
  std::setlocale(LC_NUMERIC, "C");
  ^
/usr/lib/gcc/x86_64-pc-cygwin/5.4.0/include/c++/x86_64-pc-cygwin/bits/c++locale.h:83:2: error: ‘setlocale’ is not a member of ‘std’
  std::setlocale(LC_NUMERIC, __sav);


The errors go away if I move the prototypes of setlocale and localeconv outside of the new POSIX guard.

Ken

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.6.0-0.3

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 2534 bytes --]

On Jul 28 15:44, Ken Brown wrote:
> On 7/27/2016 4:33 PM, Corinna Vinschen wrote:
> > On Jul 27 10:58, Ken Brown wrote:
> >> On 7/27/2016 8:36 AM, Corinna Vinschen wrote:
> >>> Hi Cygwin developers and maintainers,
> >>> Hi everyone else,
> >>>
> >>>
> >>> I uploaded a new Cygwin test release 2.6.0-0.3.
> >>>
> >>> Supposed to fix the problems reported in
> >>> https://cygwin.com/ml/cygwin/2016-07/msg00306.html
> >>
> >> This is now fixed.  Here's another problem, with a very easy test case:
> >>
> >> $ locale -a
> >> Segmentation fault (core dumped)
> > 
> > Confirmed.  I missed to set a variable in case of the "th_TH.TIS-620"
> > locale or the "thai" locale alias.  I'll build a 0.4 tomorrow.
> 
> This is fixed in 0.4, and that's the last of the regressions that I've
> found by running the emacs test suite.
> 
> I built and tested texlive with no problem.
> 
> I also tried to build icu, but there are some glitches due to the new
> POSIX guard in /usr/include/locale.h.  For example: [...]
> 
> The errors go away if I move the prototypes of setlocale and
> localeconv outside of the new POSIX guard.

Ouch, right, they don't belong there.  What was I thinking?

Proposing this patch, can you give it a quick test?

diff --git a/newlib/libc/include/locale.h b/newlib/libc/include/locale.h
index f74e9c5..6b3b788 100644
--- a/newlib/libc/include/locale.h
+++ b/newlib/libc/include/locale.h
@@ -72,26 +72,26 @@ char *_EXFUN(_setlocale_r,(struct _reent *, int, const char *));
 struct lconv *_EXFUN(_localeconv_r,(struct _reent *));
 
 #if __POSIX_VISIBLE >= 200809
-
 locale_t _newlocale_r (struct _reent *, int, const char *, locale_t);
 void _freelocale_r (struct _reent *, locale_t);
 locale_t _duplocale_r (struct _reent *, locale_t);
 locale_t _uselocale_r (struct _reent *, locale_t);
+#endif /* __POSIX_VISIBLE >= 200809 */
 
 #ifndef _REENT_ONLY
 
 char *_EXFUN(setlocale,(int, const char *));
 struct lconv *_EXFUN(localeconv,(void));
 
+#if __POSIX_VISIBLE >= 200809
 locale_t newlocale (int, const char *, locale_t);
 void freelocale (locale_t);
 locale_t duplocale (locale_t);
 locale_t uselocale (locale_t);
+#endif /* __POSIX_VISIBLE >= 200809 */
 
 #endif /* _REENT_ONLY */
 
-#endif /* __POSIX_VISIBLE >= 200809 */
-
 _END_STD_C
 
 #endif /* _LOCALE_H_ */


Thanks (A LOT),
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.6.0-0.3

[Ken Brown]

On 7/28/2016 3:56 PM, Corinna Vinschen wrote:
> On Jul 28 15:44, Ken Brown wrote:
>> I also tried to build icu, but there are some glitches due to the new
>> POSIX guard in /usr/include/locale.h.  For example: [...]
>>
>> The errors go away if I move the prototypes of setlocale and
>> localeconv outside of the new POSIX guard.
>
> Ouch, right, they don't belong there.  What was I thinking?
>
> Proposing this patch, can you give it a quick test?
>
[...]

This works: icu builds and tests OK with this patch.

Ken

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.6.0-0.3

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

On Jul 28 16:21, Ken Brown wrote:
> On 7/28/2016 3:56 PM, Corinna Vinschen wrote:
> > On Jul 28 15:44, Ken Brown wrote:
> > > I also tried to build icu, but there are some glitches due to the new
> > > POSIX guard in /usr/include/locale.h.  For example: [...]
> > > 
> > > The errors go away if I move the prototypes of setlocale and
> > > localeconv outside of the new POSIX guard.
> > 
> > Ouch, right, they don't belong there.  What was I thinking?
> > 
> > Proposing this patch, can you give it a quick test?
> > 
> [...]
> 
> This works: icu builds and tests OK with this patch.

Thank you *very* much for testing, I'll apply the patch and create a
-0.5 test release.

I got no testing at all yet from other targets as far as the newlib side
is concerned so I'm a bit reluctant to merge the changes into master.
Maybe I should do exactly that to enforce testing...


Thanks again,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]