From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: issetugid - not declared when _XOPEN_SOURCE is also defined
Date: Thu, 10 Nov 2016 09:10:00 -0000 [thread overview]
Message-ID: <20161110091010.GB6075@calimero.vinschen.de> (raw)
In-Reply-To: <9bb90c12-b50b-faf9-b309-f916dd84bebe@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]
On Nov 9 14:41, cyg Simple wrote:
> On 11/9/2016 1:13 PM, cyg Simple wrote:
> > The following program demonstrates the issue. Should issetugid be
> > declared with this scenario?
> >
> > /*****************************************************/
> > #define _XOPEN_SOURCE 1 /* Causes declare warning */
> > #define __BSD_VISIBLE 1
> > #include <unistd.h>
> >
> > int main(int argc, char ** argv) {
> > int result;
> > result = issetugid();
> > }
> > /****************************************************/
> >
>
> Because when _XOPEN_SOURCE is 1 _DEFAULT_SOURCE doesn't get set which
> then #undef __BSD_VISIBLE and and sets it to 0. See
> /usr/include/sys/features.h.
>
> If I #define _DEFAULT_SOURCE 1 before the #include then the above code
> works. However, should it?
Yes. You have a bug in your code. Never (and I mean *never*) use the
__foo_VISIBLE macros in your code. Please read the long comment
preceeding the visibility macro handling in /usr/include/sys/features.h.
You want to use either _DEFAULT_SOURCE or _BSD_SOURCE (deprecated but
probably available for another 100 years).
Also, note the description of the __foo_VISIBLE macros later in the file.
It introduces the macros as "private" macros.
HTH,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-11-10 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 18:13 cyg Simple
2016-11-09 19:41 ` cyg Simple
2016-11-10 9:10 ` Corinna Vinschen [this message]
2016-11-11 7:31 ` cyg Simple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110091010.GB6075@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).