From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: ssh-host-config: patch fix debug option + broken for me on Vista (non-domain)
Date: Thu, 19 Jan 2017 10:38:00 -0000 [thread overview]
Message-ID: <20170119103840.GD13008@calimero.vinschen.de> (raw)
In-Reply-To: <84a7692e-041a-8b99-2ea9-fb1c784fc01c@shaddybaddah.name>
[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]
On Jan 18 14:34, Shaddy Baddah wrote:
> Hi,
>
> First please find attached a simple patch that fixes a problem I
> encountered running ssh-host-config with the --debug option.
Thanks, applied.
> And I'm sure the problem is that this well-intended change to the script
> fails on the assumption that LOGONSERVER is always populated. It isn't
> for me on Vista.
>
> cygwin-service-installation-helper.sh:2884: # This test succeeds on
> domain member machines only, not on DCs.
> cygwin-service-installation-helper.sh:2885: if [
> "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" \
> cygwin-service-installation-helper.sh:2886: -a "${LOGONSERVER}" !=
> "\\\\MicrosoftAccount" ]
> cygwin-service-installation-helper.sh:2887: then
> cygwin-service-installation-helper.sh:2888: # Lowercase of USERDOMAIN
> cygwin-service-installation-helper.sh:2889:
> csih_PRIVILEGED_USERNAME="${COMPUTERNAME,,*}+${username}"
> cygwin-service-installation-helper.sh:2890: fi
> cygwin-service-installation-helper.sh:2891: fi
>
> I fixed this by modifying the test to check LOGONSERVER is not empty:
>
> if [ -n "${LOGONSERVER}" -a "\\\\...
>
> Can this be fixed in the next release?
Sure, please provide a patch, I'll check it in and release a new csih
soonish.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-01-19 10:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 3:34 Shaddy Baddah
2017-01-18 3:38 ` Shaddy Baddah
2017-01-19 10:38 ` Corinna Vinschen [this message]
2017-01-19 11:26 ` Shaddy Baddah
2017-01-19 18:16 ` Corinna Vinschen
2017-01-20 22:40 ` szgyg
2017-01-23 3:13 ` Shaddy Baddah
2017-01-23 10:19 ` Corinna Vinschen
2017-01-23 19:50 ` Achim Gratz
2017-01-23 20:19 ` Wells, Roger K.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119103840.GD13008@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).