From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73548 invoked by alias); 19 Jan 2017 10:38:48 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 73513 invoked by uid 89); 19 Jan 2017 10:38:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-101.6 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Baddah, baddah, H*MI:sk:84a7692, H*f:sk:84a7692 X-HELO: drew.franken.de Received: from mail-n.franken.de (HELO drew.franken.de) (193.175.24.27) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Jan 2017 10:38:44 +0000 Received: from aqua.hirmke.de (aquarius.franken.de [193.175.24.89]) (Authenticated sender: aquarius) by mail-n.franken.de (Postfix) with ESMTPSA id 49DAE721E281A for ; Thu, 19 Jan 2017 11:38:41 +0100 (CET) Received: from calimero.vinschen.de (calimero.vinschen.de [192.168.129.6]) by aqua.hirmke.de (Postfix) with ESMTP id 893745E01C7 for ; Thu, 19 Jan 2017 11:38:40 +0100 (CET) Received: by calimero.vinschen.de (Postfix, from userid 500) id 6E6FAA80613; Thu, 19 Jan 2017 11:38:40 +0100 (CET) Date: Thu, 19 Jan 2017 10:38:00 -0000 From: Corinna Vinschen To: cygwin@cygwin.com Subject: Re: ssh-host-config: patch fix debug option + broken for me on Vista (non-domain) Message-ID: <20170119103840.GD13008@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <84a7692e-041a-8b99-2ea9-fb1c784fc01c@shaddybaddah.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3" Content-Disposition: inline In-Reply-To: <84a7692e-041a-8b99-2ea9-fb1c784fc01c@shaddybaddah.name> User-Agent: Mutt/1.7.1 (2016-10-04) X-SW-Source: 2017-01/txt/msg00250.txt.bz2 --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1463 On Jan 18 14:34, Shaddy Baddah wrote: > Hi, >=20 > First please find attached a simple patch that fixes a problem I > encountered running ssh-host-config with the --debug option. Thanks, applied. > And I'm sure the problem is that this well-intended change to the script > fails on the assumption that LOGONSERVER is always populated. It isn't > for me on Vista. >=20 > cygwin-service-installation-helper.sh:2884: # This test succeeds on > domain member machines only, not on DCs. > cygwin-service-installation-helper.sh:2885: if [ > "\\\\${COMPUTERNAME,,*}" !=3D "${LOGONSERVER,,*}" \ > cygwin-service-installation-helper.sh:2886: -a "${LOGONSERVER}" != =3D > "\\\\MicrosoftAccount" ] > cygwin-service-installation-helper.sh:2887: then > cygwin-service-installation-helper.sh:2888: # Lowercase of USERDOMAIN > cygwin-service-installation-helper.sh:2889: > csih_PRIVILEGED_USERNAME=3D"${COMPUTERNAME,,*}+${username}" > cygwin-service-installation-helper.sh:2890: fi > cygwin-service-installation-helper.sh:2891: fi >=20 > I fixed this by modifying the test to check LOGONSERVER is not empty: >=20 > if [ -n "${LOGONSERVER}" -a "\\\\... >=20 > Can this be fixed in the next release? Sure, please provide a patch, I'll check it in and release a new csih soonish. Thanks, Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYgJcwAAoJEPU2Bp2uRE+gBX4P+wU2LG4wbaWHSd+bH1mv9qjq PNEBsEqCA87OlhBUfQ61aVa9LCqeLqaC6CtMHX0W72BJeCS5EHoNYNma0qTULww0 fQAwVSPIQ5O5KqMkk8W1yNlPQtb0Jl9PFmdLByT7s10l/ocVQKTsHjb1VmTzf+8v vkuDZXbg/XAfHUtYuEgQhFSs83D75R3GYiVpSUZrrjx8JmOTa8iVzcfEFuHxdtfF No7NB9X/8tpatyUXlGE6kBVOG3OEmCY0a9o1KsebgBKaW8ynQwcpuToHMaWA0/+B RQfnFl6juU4ZUe+q+GmbhsH1WrMID8b3RmFyaed6u4Q2i995TOuxTO5Oseh9XioT /ZKobbE1mDVGPjao/viVIZq0Y/9HE2hYXFUbBU7fVduvIbxaqwJTE3YRc3XvWwzd HvXUr5+OfHM7TJN5BLO9djiG5ZYkmgoR8NLHJD7RFw7jp8RlO4lKX9YDbbxe8AeT h2bpBPTXpw/76aEHXqH9CzVG5lyQZZMrP/Hzxk8e3VjcAtMa8z6XQYWRoMBy+tDZ GFgld9gQXP7qJD8M1wE/B91mfh4ml/tFjonmGz3tudNatEWjhGXMsnTa3hi9aB/G pl87jituBv/38adPZVAXzs1H7OsSraR3sAstO4+XzeWNfAXP2dU3Qd5PGI3JrrIP JJwPLsaCrFgV1CZYDPef =slw2 -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--