On Jan 19 22:26, Shaddy Baddah wrote:
> 
> Hi,
> 
> On 19/01/17 21:38, Corinna Vinschen wrote:
> > On Jan 18 14:34, Shaddy Baddah wrote:
> ...
> 
> > > And I'm sure the problem is that this well-intended change to the script
> > > fails on the assumption that LOGONSERVER is always populated. It isn't
> > > for me on Vista.
> > > 
> > > cygwin-service-installation-helper.sh:2884:      # This test succeeds on
> > > domain member machines only, not on DCs.
> > > cygwin-service-installation-helper.sh:2885:      if [
> > > "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" \
> > > cygwin-service-installation-helper.sh:2886:        -a "${LOGONSERVER}" !=
> > > "\\\\MicrosoftAccount" ]
> > > cygwin-service-installation-helper.sh:2887:      then
> > > cygwin-service-installation-helper.sh:2888:     # Lowercase of USERDOMAIN
> > > cygwin-service-installation-helper.sh:2889:
> > > csih_PRIVILEGED_USERNAME="${COMPUTERNAME,,*}+${username}"
> > > cygwin-service-installation-helper.sh:2890:      fi
> > > cygwin-service-installation-helper.sh:2891:    fi
> > > 
> > > I fixed this by modifying the test to check LOGONSERVER is not empty:
> > > 
> > > if [ -n "${LOGONSERVER}" -a "\\\\...
> > > 
> > > Can this be fixed in the next release?
> > 
> > Sure, please provide a patch, I'll check it in and release a new csih
> > soonish.
> 
> I would, but there's a couple of hitches. Without understanding the
> syntax (and I should bring up the bash man page here, I will do after
> this), I can't be sure that the following test:
> 
> "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}"
> 
> wasn't designed to handled an empty LOGONSERVER variable.

No, it wasn't.  The idea is that if LOGONSERVER == COMPUTERNAME your
machine is not in a domain.  Actually, I *never* encountered an environment
in which LOGONSERVER isn't set.  Are you sure this isn't just some kind
of misconfiguration?  I don't think Cygwin is the only application
checking for LOGONSERVER.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat