From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1409 invoked by alias); 19 Jan 2017 18:16:55 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 1194 invoked by uid 89); 19 Jan 2017 18:16:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-101.6 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:2cb5cd9, sk:misconf, H*f:sk:2cb5cd9, H*MI:sk:2cb5cd9 X-HELO: drew.franken.de Received: from mail-n.franken.de (HELO drew.franken.de) (193.175.24.27) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Jan 2017 18:16:47 +0000 Received: from aqua.hirmke.de (aquarius.franken.de [193.175.24.89]) (Authenticated sender: aquarius) by mail-n.franken.de (Postfix) with ESMTPSA id 95069721E2822 for ; Thu, 19 Jan 2017 19:16:44 +0100 (CET) Received: from calimero.vinschen.de (calimero.vinschen.de [192.168.129.6]) by aqua.hirmke.de (Postfix) with ESMTP id 0543E5E0212 for ; Thu, 19 Jan 2017 19:16:44 +0100 (CET) Received: by calimero.vinschen.de (Postfix, from userid 500) id E032AA80585; Thu, 19 Jan 2017 19:16:43 +0100 (CET) Date: Thu, 19 Jan 2017 18:16:00 -0000 From: Corinna Vinschen To: cygwin@cygwin.com Subject: Re: ssh-host-config: patch fix debug option + broken for me on Vista (non-domain) Message-ID: <20170119181643.GB25162@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <84a7692e-041a-8b99-2ea9-fb1c784fc01c@shaddybaddah.name> <20170119103840.GD13008@calimero.vinschen.de> <2cb5cd97-a711-8d11-c07a-2534ee67298b@shaddybaddah.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7iMSBzlTiPOCCT2k" Content-Disposition: inline In-Reply-To: <2cb5cd97-a711-8d11-c07a-2534ee67298b@shaddybaddah.name> User-Agent: Mutt/1.7.1 (2016-10-04) X-SW-Source: 2017-01/txt/msg00258.txt.bz2 --7iMSBzlTiPOCCT2k Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2151 On Jan 19 22:26, Shaddy Baddah wrote: >=20 > Hi, >=20 > On 19/01/17 21:38, Corinna Vinschen wrote: > > On Jan 18 14:34, Shaddy Baddah wrote: > ... >=20 > > > And I'm sure the problem is that this well-intended change to the scr= ipt > > > fails on the assumption that LOGONSERVER is always populated. It isn't > > > for me on Vista. > > >=20 > > > cygwin-service-installation-helper.sh:2884: # This test succeeds= on > > > domain member machines only, not on DCs. > > > cygwin-service-installation-helper.sh:2885: if [ > > > "\\\\${COMPUTERNAME,,*}" !=3D "${LOGONSERVER,,*}" \ > > > cygwin-service-installation-helper.sh:2886: -a "${LOGONSERVER}= " !=3D > > > "\\\\MicrosoftAccount" ] > > > cygwin-service-installation-helper.sh:2887: then > > > cygwin-service-installation-helper.sh:2888: # Lowercase of USERDO= MAIN > > > cygwin-service-installation-helper.sh:2889: > > > csih_PRIVILEGED_USERNAME=3D"${COMPUTERNAME,,*}+${username}" > > > cygwin-service-installation-helper.sh:2890: fi > > > cygwin-service-installation-helper.sh:2891: fi > > >=20 > > > I fixed this by modifying the test to check LOGONSERVER is not empty: > > >=20 > > > if [ -n "${LOGONSERVER}" -a "\\\\... > > >=20 > > > Can this be fixed in the next release? > >=20 > > Sure, please provide a patch, I'll check it in and release a new csih > > soonish. >=20 > I would, but there's a couple of hitches. Without understanding the > syntax (and I should bring up the bash man page here, I will do after > this), I can't be sure that the following test: >=20 > "\\\\${COMPUTERNAME,,*}" !=3D "${LOGONSERVER,,*}" >=20 > wasn't designed to handled an empty LOGONSERVER variable. No, it wasn't. The idea is that if LOGONSERVER =3D=3D COMPUTERNAME your machine is not in a domain. Actually, I *never* encountered an environment in which LOGONSERVER isn't set. Are you sure this isn't just some kind of misconfiguration? I don't think Cygwin is the only application checking for LOGONSERVER. Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --7iMSBzlTiPOCCT2k Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYgQKLAAoJEPU2Bp2uRE+gu6kQAIsqBRTOu0zEYLlfKeruEIXS MOnNHcLrERPuX95bWu3LhZjCmAHJARw6Rfzh7vJj0QuS7RaANgWX4Ryc101XCURt AHx9WwvIQn+UO1x0SFBP41oDZvDKozhQqEJScdJQCcGnrVHvClXTNrzKg9U4KHZe 9KQNVXOzcEf2XJJJX4bzD5aufHZ+DvD9wIWF9hrHH1cnkLv8xuB+TeH75qt+68S+ rN7Zg/R4IqkhJuoHN5ldoaZauDnKzh31alfEWmW2KXuq/IJAX3iauMpzwDasDN1F vGhAzsgaoj8WtLJxTCUbDe7iDHVYZ0NGOC6XaJT0CFS9pGAUeeKlTdI7f632ZF01 U6vnNuCGrvFzItcvZ0hVxGjPw7kzwqV7XeWcCZ6hNRNd8iCGtrfLHCxgvq4aiuh1 p+E9bDAb2okZbRb1qVRlefWkdJcpTG3MpcnHP7BZUjPJ7R//CZv+WSodj+VH/VN5 sFXhqt5Odmej5p9FjDrwNW7BgwQ171v7BIIMSGktHJv75BOiQsnk9gd0uhjGBDLD SZ4hPFoqQPj+CUsppMPtZipYGelUstPrSYR41j+EDvrvDRFIVitJdALYE1GGAQ9B LagQd27g0mNo83oIvnT2jZl48krkl4PS8znTyy3/1Ny/CxbXoCxPIAwNG2ibojSD NE5jWyrIE5fqG1Cu7a9P =s6WX -----END PGP SIGNATURE----- --7iMSBzlTiPOCCT2k--