public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: Incorrect /proc/cpuinfo for AMD A6-9220
Date: Mon, 16 Apr 2018 07:59:00 -0000	[thread overview]
Message-ID: <20180416075920.GB2539@calimero.vinschen.de> (raw)
In-Reply-To: <CAH8yC8ngb9RuWkAs-Ld6qFswsh0qjfm-mrWLBTtgKM-zWjiPPw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

On Apr 13 20:36, Jeffrey Walton wrote:
> On Fri, Apr 13, 2018 at 7:51 AM, Corinna Vinschen
> <corinna-cygwin@cygwin.com> wrote:
> > On Apr 12 23:01, Jeffrey Walton wrote:
> >> Hi Everyone,
> >>
> >> I'm working on an AMD A6-9220 and seeing unusual results from
> >> /proc/cpuinfo. I think this may be an issue with the latest Cygwin. It
> >> may be present in earlier versions, too.
> >>
> >> Russinovich's coreinfo is shown below
> >> (https://docs.microsoft.com/en-us/sysinternals/downloads/coreinfo).
> >> Notice /proc/cpuinfo is missing aesni, pclmul, rdrand, SSE4.1, SSE4.2,
> >> AVX, etc.
> >
> > Note that, in theory, cpuinfo has to be extended for each new CPU
> > generation.  That's a lot of work for marginal gain (Cygwin's not a real
> > kernel) so I'm doing this only very seldomly.
> >
> > Patches welcome, of course!
> 
> Thanks Corinna. I think I found the file of interest at fhandler_proc.cc.
> 
> Whitespace is a bit off. It is a mix of tabs and space:
> 
>       if (features1 & (1 << 0))
>     print (" fpu");
>       if (features1 & (1 << 1))
>     print (" vme");
> 
> Should I perform a whitespace check-in before things begin? Or can you
> knock it out?

Whitespacing looks correct to me.  In vim speak, ts=8, sw=2.

Just add what you think is missing (make sure it matches AMD/Intel),
but stick to the whitespacing of the existing code.  Please check
https://cygwin.com/contrib.html.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-04-16  7:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13  3:01 Jeffrey Walton
2018-04-13 11:51 ` Corinna Vinschen
2018-04-14  0:37   ` Jeffrey Walton
2018-04-16  7:59     ` Corinna Vinschen [this message]
2018-04-16 15:19       ` Brian Inglis
  -- strict thread matches above, loose matches on Subject: below --
2018-04-13  2:56 Jeffrey Walton
2018-04-13  3:02 ` Jeffrey Walton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180416075920.GB2539@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).