public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Bill Stewart <bstewart@iname.com>
Cc: cygwin@cygwin.com
Subject: Re: sshd permits logon using disabled user?
Date: Thu, 24 Jan 2019 20:23:00 -0000	[thread overview]
Message-ID: <20190124202340.GN2802@calimero.vinschen.de> (raw)
In-Reply-To: <CANV9t=RAGYEqEXi3SHDR397TzvE9O3AUGaMJMCzk+_d3uM1d+Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2407 bytes --]

On Jan 24 09:48, Bill Stewart wrote:
> Hello Corinna,
> 
> I performed the following steps:
> 
> 1. Downloaded cygwin-20190124.tar.xz
> 2. Extracted it
> 3. Stopped sshd
> 4. Renamed existing /bin/cygwin1.dll to cygwin1-20181108.dll
> 5. Copied cygwin1.dll from download to /bin
> 6. Started sshd
> 
> Did I miss anything?

No, I did.

> It still allows logon with disabled account.

I should have tested pubkey auth as well but as it was I just tested
with pathword auth.  These methods take slightly different paths in
Cygwin when trying to switch the user account.

I pushed another patch and created new snapshots in the same location
https://cygwin.com/snapshots/.


HTH,
Corinna


> 
> Thanks,
> 
> Bill
> 
> 
> On Thu, Jan 24, 2019 at 8:45 AM Corinna Vinschen <corinna-cygwin@cygwin.com>
> wrote:
> 
> > On Jan 24 06:28, Bill Stewart wrote:
> > > I am running Windows 10 (1803) and experimenting with sshd installed as a
> > > Windows service.
> > >
> > > The computer is a domain member. I created a local computer account for
> > > testing.
> > >
> > > I created host keys and a public/private key pair to use to log on the
> > user.
> > >
> > > This works, except I notice that if I disable the Windows user account, I
> > > can still log on using ssh using that account.
> > >
> > > In the shell, logged on as the disabled user, the 'whoami' command
> > returns
> > > the name of the disabled user.
> > >
> > > This seems unexpected and not good.
> > >
> > > Why does sshd allow logon for a disabled user?
> >
> > Because the underlying Cygwin function responsible for changing the user
> > account only checks if the account exists.  It does not check for any of
> > the flags in the user DB.  Yet.
> >
> > I pushed a patch to disallow changing the user account to a disabled or
> > locked out account.
> >
> > I just uploaded new developer snapshots containing this change to
> > https://cygwin.com/snapshots/
> >
> > Please give them a try.
> >
> >
> > Thanks,
> > Corinna
> >
> > --
> > Corinna Vinschen
> > Cygwin Maintainer
> >
> 
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

-- 
Corinna Vinschen
Cygwin Maintainer

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-01-24 20:23 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-24 13:28 Bill Stewart
2019-01-24 15:45 ` Corinna Vinschen
2019-01-24 15:51   ` Stefan Baur
2019-01-24 15:59     ` Corinna Vinschen
2019-01-24 16:16       ` Stefan Baur
2019-01-24 16:36         ` Corinna Vinschen
2019-01-24 17:01           ` Stefan Baur
2019-01-26 19:05         ` Andrey Repin
2019-01-24 16:49   ` Bill Stewart
2019-01-24 20:23     ` Corinna Vinschen [this message]
2019-01-24 20:37       ` Bill Stewart
2019-01-25 16:56         ` Corinna Vinschen
2019-01-24 17:52   ` Bill Stewart
2019-01-24 17:58     ` Stefan Baur
2019-01-24 18:13       ` Bill Stewart
2019-01-24 19:17         ` Wayne Davison
2019-01-24 19:22           ` Stefan Baur
2019-01-26 19:20     ` Andrey Repin
     [not found] <1690850474.834980.1548391349102.ref@mail.yahoo.com>
2019-01-25  4:42 ` matthew patton via cygwin
2019-01-25 10:36   ` Stefan Baur
2019-01-25 15:34     ` Bill Stewart
2019-01-25 17:48       ` Stephen Paul Carrier
2019-01-25 18:03         ` Bill Stewart
2019-01-27 17:48           ` Sam Edge (Cygwin)
2019-01-27 22:10             ` Corinna Vinschen
2019-01-28 13:35               ` Sam Edge
2019-01-28  9:59           ` Corinna Vinschen
2019-01-28 15:02             ` Bill Stewart
2019-01-28 16:52               ` Corinna Vinschen
2019-01-28 17:19                 ` Bill Stewart
2019-01-28 18:39                   ` Corinna Vinschen
2019-01-28 20:14                     ` Bill Stewart
2019-01-28 21:50                       ` Bill Stewart
2019-01-28 22:24                         ` Bill Stewart
2019-01-29 11:57                         ` Corinna Vinschen
2019-01-29 12:12                           ` Corinna Vinschen
2019-01-29 17:05                             ` Corinna Vinschen
2019-01-29 18:18                               ` Bill Stewart
2019-01-29 18:30                                 ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190124202340.GN2802@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=bstewart@iname.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).