From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Michael Haubenwallner <michael.haubenwallner@ssi-schaefer.com>
Cc: cygwin@cygwin.com
Subject: Re: [ANNOUNCEMENT] TEST: Cygwin 3.0.0-0.7
Date: Fri, 08 Feb 2019 16:50:00 -0000 [thread overview]
Message-ID: <20190208165004.GS13951@calimero.vinschen.de> (raw)
In-Reply-To: <00970ac8-48e6-9776-e396-5ab78e55e61b@ssi-schaefer.com>
[-- Attachment #1: Type: text/plain, Size: 2350 bytes --]
On Feb 8 17:17, Michael Haubenwallner wrote:
>
>
> On 2/8/19 3:48 PM, Corinna Vinschen wrote:
> > On Feb 8 15:43, Michael Haubenwallner wrote:
> >> On 2/8/19 2:28 PM, Corinna Vinschen wrote:
> >>> On Feb 8 14:06, Corinna Vinschen wrote:
> >>>> On Feb 8 13:52, Michael Haubenwallner wrote:
> >>>>> On 2/8/19 1:23 PM, Corinna Vinschen wrote:
> >>>>>> On Feb 8 13:21, Corinna Vinschen wrote:
> >>>>>>> On Feb 8 12:51, Michael Haubenwallner wrote:
> >>>>>>>>
> >>>>>>>> For now it seems like there's an inconsistency with PIDs:
> >>>>>>>> A first process PID 100, receives PID 101 from spawn(),
> >>>>>>>> but in the new process getpid() returns 102:
> >>>>>>>>
> >>>>>>>> $ ./dospawn /bin/bash -c 'echo $$'
> >>>>>>>> 12625
> >>>>>>>> waitpid: pid 12624 status 0x0
> >>>>>>>
> >>>>>>> Oh, hmm. If you call spawnve, rather than execve, a new child pid
> >>>>>>> is generated in spawnve, rather than just keeping the callers pid.
> >>>>>>>
> >>>>>>> However, apparently the child invents its own pid in pinfo::thisproc
> >>>>>>> after being spawned. But actually this should only occur for forked
> >>>>>>> processes aore processes started from non-Cygwin parents.
> >>>>>>
> >>>>>> Does that help, by any chance:
> >>>>>> [nope]
> >>>>>
> >>>>> How should the child be informed at all about the new cygpid value generated in
> >>>>> parent's child_info_spawn::worker() ?
> >>>>
> >>>> I just realized this myself. The old method creating Cygwin pids just
> >>>> fetched the pid from GetCurrentProcessId(), which was right for spawned
> >>>> (but not execed) processes. For the new pid we might have to give this
> >>>> to the child via child_info_spawn.
> >>>
> >>> This works for me, can you test this, too, please?
> >>
> >> Looks good to me as well, I'm going to start my hours running use case now.
> >
> > Sounds good, thanks. I'll push this change now. We can always
> > rework it if it's insufficient.
>
> *** WARNING WARNING WARNING WARNING WARNING ***
> *** .../newlib-cygwin/winsup/cygwin/child_info.h: magic number for CHILD_INFO_MAGIC changed old 0x3ee00652U != new 0xf4531879U
> *** WARNING WARNING WARNING WARNING WARNING ***
>
> Seems like the CHILD_INFO_MAGIC bump is missing for this change, no?
Fixed.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-08 16:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 15:24 Corinna Vinschen
2019-02-07 16:14 ` Michael Haubenwallner
2019-02-07 18:27 ` Corinna Vinschen
2019-02-08 6:46 ` Michael Haubenwallner
2019-02-08 11:32 ` Corinna Vinschen
2019-02-08 11:51 ` Michael Haubenwallner
2019-02-08 12:21 ` Corinna Vinschen
2019-02-08 12:23 ` Corinna Vinschen
2019-02-08 12:52 ` Michael Haubenwallner
2019-02-08 13:06 ` Corinna Vinschen
2019-02-08 13:28 ` Corinna Vinschen
2019-02-08 14:43 ` Michael Haubenwallner
2019-02-08 14:49 ` Corinna Vinschen
2019-02-08 16:18 ` Michael Haubenwallner
2019-02-08 16:50 ` Corinna Vinschen [this message]
2019-02-08 16:35 ` Michael Haubenwallner
2019-02-08 16:58 ` Corinna Vinschen
2019-02-08 17:00 ` Corinna Vinschen
2019-02-11 11:50 ` Michael Haubenwallner
2019-02-11 13:33 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208165004.GS13951@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
--cc=michael.haubenwallner@ssi-schaefer.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).