From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75480 invoked by alias); 8 Feb 2019 16:50:10 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 75473 invoked by uid 89); 8 Feb 2019 16:50:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-100.4 required=5.0 tests=BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mout.kundenserver.de Received: from mout.kundenserver.de (HELO mout.kundenserver.de) (212.227.126.130) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Feb 2019 16:50:09 +0000 Received: from calimero.vinschen.de ([217.91.18.234]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MkHhB-1hXVZM1Kcj-00kisU; Fri, 08 Feb 2019 17:50:05 +0100 Received: by calimero.vinschen.de (Postfix, from userid 500) id 15BC4A804D0; Fri, 8 Feb 2019 17:50:04 +0100 (CET) Date: Fri, 08 Feb 2019 16:50:00 -0000 From: Corinna Vinschen To: Michael Haubenwallner Cc: cygwin@cygwin.com Subject: Re: [ANNOUNCEMENT] TEST: Cygwin 3.0.0-0.7 Message-ID: <20190208165004.GS13951@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: Michael Haubenwallner , cygwin@cygwin.com References: <20190208113158.GH13951@calimero.vinschen.de> <17e339bb-2115-bf22-7291-04215aab3150@ssi-schaefer.com> <20190208122126.GM13951@calimero.vinschen.de> <20190208122338.GN13951@calimero.vinschen.de> <20190208130635.GO13951@calimero.vinschen.de> <20190208132807.GP13951@calimero.vinschen.de> <6b182191-b235-fcbb-5b25-66243950043c@ssi-schaefer.com> <20190208144827.GR13951@calimero.vinschen.de> <00970ac8-48e6-9776-e396-5ab78e55e61b@ssi-schaefer.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2YJj5f1P6Th4nBRw" Content-Disposition: inline In-Reply-To: <00970ac8-48e6-9776-e396-5ab78e55e61b@ssi-schaefer.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2019-02/txt/msg00077.txt.bz2 --2YJj5f1P6Th4nBRw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2321 On Feb 8 17:17, Michael Haubenwallner wrote: >=20 >=20 > On 2/8/19 3:48 PM, Corinna Vinschen wrote: > > On Feb 8 15:43, Michael Haubenwallner wrote: > >> On 2/8/19 2:28 PM, Corinna Vinschen wrote: > >>> On Feb 8 14:06, Corinna Vinschen wrote: > >>>> On Feb 8 13:52, Michael Haubenwallner wrote: > >>>>> On 2/8/19 1:23 PM, Corinna Vinschen wrote: > >>>>>> On Feb 8 13:21, Corinna Vinschen wrote: > >>>>>>> On Feb 8 12:51, Michael Haubenwallner wrote: > >>>>>>>> > >>>>>>>> For now it seems like there's an inconsistency with PIDs: > >>>>>>>> A first process PID 100, receives PID 101 from spawn(), > >>>>>>>> but in the new process getpid() returns 102: > >>>>>>>> > >>>>>>>> $ ./dospawn /bin/bash -c 'echo $$' > >>>>>>>> 12625 > >>>>>>>> waitpid: pid 12624 status 0x0 > >>>>>>> > >>>>>>> Oh, hmm. If you call spawnve, rather than execve, a new child pid > >>>>>>> is generated in spawnve, rather than just keeping the callers pid. > >>>>>>> > >>>>>>> However, apparently the child invents its own pid in pinfo::thisp= roc > >>>>>>> after being spawned. But actually this should only occur for for= ked > >>>>>>> processes aore processes started from non-Cygwin parents. > >>>>>> > >>>>>> Does that help, by any chance: > >>>>>> [nope] > >>>>> > >>>>> How should the child be informed at all about the new cygpid value = generated in > >>>>> parent's child_info_spawn::worker() ? > >>>> > >>>> I just realized this myself. The old method creating Cygwin pids ju= st > >>>> fetched the pid from GetCurrentProcessId(), which was right for spaw= ned > >>>> (but not execed) processes. For the new pid we might have to give t= his > >>>> to the child via child_info_spawn. > >>> > >>> This works for me, can you test this, too, please? > >> > >> Looks good to me as well, I'm going to start my hours running use case= now. > >=20 > > Sounds good, thanks. I'll push this change now. We can always > > rework it if it's insufficient. >=20 > *** WARNING WARNING WARNING WARNING WARNING *** > *** .../newlib-cygwin/winsup/cygwin/child_info.h: magic number for CHILD_= INFO_MAGIC changed old 0x3ee00652U !=3D new 0xf4531879U > *** WARNING WARNING WARNING WARNING WARNING *** >=20 > Seems like the CHILD_INFO_MAGIC bump is missing for this change, no? Fixed. Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer --2YJj5f1P6Th4nBRw Content-Type: application/pgp-signature; name="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAlxdszsACgkQ9TYGna5E T6De0xAAknIjfPmvQfcUDOYzb14Gn7g9zerqGAe1KL761iWv+irJdinngs1ZfRZ0 xnfOzu5zRBF/wk5mAy473IEeLKaCde4nGvF7al8G7C+lflAx2GOOAnj/tzU4r+qY jW71FUpoGwX2mwjElfXYyA4tpSUIrchgo2gUXjCrUGCzu6XLSlNm/uqSzfzAANQl gKFriZU0V/SWQhioZy8k9EbsrPVtB5Xfv+c9RhT2nbzr8TSG8n1zJBEZ8/+DJAEs zG7GnxYOsI7HAyGVFASOhHOyWIH/7A0Dva/SHk+SxiVKBxYRTQTryvvcheO9mrjK 8hLxBgXVPtLMKbf3qb4t7Q/jJHhE/gagFkkpopvgzyxm288VBvBwPyht9mjuxNT5 ZMTeOjs2YV0koRIgIRLq3nVoY+zMn6W5a7oWgkdp0/3nY2+1Y2mOjbzixdL/H6Hx kVq9b5B1N8DIqf0z6CkE6UmfRKp0MURfaLDn5cwpEqMGSR0UqNuJjK9Hwey+vrve s+B13g4Qtkejj6KmGM08WKY5/6Rbb08vrba20ZUCmas63jMlt/3LjHKSD0SfkMmg uwW4FJ3Oglcs92C23oicn6mj7D/qhQ3NJQpMen4YQIvpVbU/hFNN9tCDrfCNyw8Z JYrWHSQtHQEhdJP3nhKl3UM3xe0kZTwqGxcxqRd+qiFl72Zl5qE= =+bFX -----END PGP SIGNATURE----- --2YJj5f1P6Th4nBRw--